From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id GNGoJ88EN2IRGQAAgWs5BA (envelope-from ) for ; Sun, 20 Mar 2022 11:41:19 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id yMghIM8EN2Ji1gAAG6o9tA (envelope-from ) for ; Sun, 20 Mar 2022 11:41:19 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 099D728246 for ; Sun, 20 Mar 2022 11:41:19 +0100 (CET) Received: from localhost ([::1]:45856 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nVszt-00086j-TW for larch@yhetil.org; Sun, 20 Mar 2022 06:41:17 -0400 Received: from eggs.gnu.org ([209.51.188.92]:54816) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nVsze-000843-RL for bug-guix@gnu.org; Sun, 20 Mar 2022 06:41:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:38962) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nVsze-0008At-JI for bug-guix@gnu.org; Sun, 20 Mar 2022 06:41:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nVsze-00015P-Hh for bug-guix@gnu.org; Sun, 20 Mar 2022 06:41:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#50329: [PATCH] Bundle icons for emacs-lsp-treemacs Resent-From: Roman Scherer Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sun, 20 Mar 2022 10:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50329 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Maxime Devos Received: via spool by 50329-submit@debbugs.gnu.org id=B50329.16477728194091 (code B ref 50329); Sun, 20 Mar 2022 10:41:02 +0000 Received: (at 50329) by debbugs.gnu.org; 20 Mar 2022 10:40:19 +0000 Received: from localhost ([127.0.0.1]:32852 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVsyw-00013u-Tu for submit@debbugs.gnu.org; Sun, 20 Mar 2022 06:40:19 -0400 Received: from mail-ej1-f53.google.com ([209.85.218.53]:36553) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVsyu-00013N-9M for 50329@debbugs.gnu.org; Sun, 20 Mar 2022 06:40:17 -0400 Received: by mail-ej1-f53.google.com with SMTP id bi12so24846739ejb.3 for <50329@debbugs.gnu.org>; Sun, 20 Mar 2022 03:40:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=burningswell-com.20210112.gappssmtp.com; s=20210112; h=references:user-agent:from:to:cc:subject:date:in-reply-to :message-id:mime-version; bh=TYtOpyZJtdn1DvLipEWa+hYA9DT2ctcqMWjP2rwjh90=; b=CwHfJLpA33EVGFvQOhj7hv+v3CmrurSe0DOP9zo3aL3YDWWMrlrbtqhoomLnz2R6Ti gkCGKXs+kBJSuu35gNnf13YC0j/eaVELiJ6Ee5XO/P96h2hvpBZn9MY53QGbY1vxuJaL hgUC7xqf7314iPMMIg7S4tBoX816bP0CxoPudyG4uXCQj1VfBgnE0jZ9ntxX/KYv7y5p lh9o6CMNavlBSTP7DVkBrmkwB5GcV6ZOrfayPKQ4V7Xzm8NGFYLNpX9szXf2Ux9FK9tY PkuO2goZ0+U1v8AbwemMaTdmfvV1dN29ECXeHsLqAEorzt/J0Cs0pmz9G3RTkE+O0f4z 3u4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:references:user-agent:from:to:cc:subject:date :in-reply-to:message-id:mime-version; bh=TYtOpyZJtdn1DvLipEWa+hYA9DT2ctcqMWjP2rwjh90=; b=dbl+0STBcxMg0Hd9kOMQzCUTkubzNETvWFEFmB29Cw+ANdsgI6JNx6jeNRLW5B54vN fXFb/BGci/jHwyyuB30h6MQn0Yt0hfyFARuOgurMTBCik9x6/ssm1XI56z4LRYYxSxCx ZLJFW9c8VdgUUEsuIIwTXtty6Chb45jRGy9TJ227SPbDffaKSb+0fT9UTkl+R5RJyxzu TtT28OnzJc/6K4+oKdcx9n+/JVgLCfb8xM+atSoGWUFtEg/L7AaHNRpq4yCs1qtugf6/ oYU0waQ1yalj4z/inG5QNp4X83ph5RxFHioHWeNjrjBhQbKZht/MYecr9TFC1CUnxO0J diUw== X-Gm-Message-State: AOAM531EsHX0QBIlLl3E/+qtoYVMenQspWfclMmZQGW03nI8/xc7gyMG M/gZoIraREDniZEGI9g84KFJDQ== X-Google-Smtp-Source: ABdhPJzY4NSlMCWXmB8jPhzHfwyNxZCv+bqyoGluWi7Bub9Kb8smnCQThAHsejIUTg5xwvSil/DAQQ== X-Received: by 2002:a17:906:19c6:b0:6ce:98a4:5ee6 with SMTP id h6-20020a17090619c600b006ce98a45ee6mr16105610ejd.567.1647772810118; Sun, 20 Mar 2022 03:40:10 -0700 (PDT) Received: from thinkpad (tmo-116-11.customers.d1-online.com. [80.187.116.11]) by smtp.gmail.com with ESMTPSA id u4-20020a170906780400b006ce69ff6050sm5684607ejm.69.2022.03.20.03.40.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Mar 2022 03:40:09 -0700 (PDT) References: <87fsnevtxi.fsf@burningswell.com> <8c532497fcfb965b7c60e93b3bbd8082b3acddf4.camel@telenet.be> <87wngp6l7n.fsf@burningswell.com> <7333ababd7753976b6165d1ce8d538586089015c.camel@telenet.be> User-agent: mu4e 1.6.10; emacs 28.0.50 From: Roman Scherer Date: Sun, 20 Mar 2022 11:35:19 +0100 In-reply-to: <7333ababd7753976b6165d1ce8d538586089015c.camel@telenet.be> Message-ID: <87sfrc7vqw.fsf@burningswell.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 50329@debbugs.gnu.org, Nicolas Goaziou Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1647772879; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=TYtOpyZJtdn1DvLipEWa+hYA9DT2ctcqMWjP2rwjh90=; b=dbdeRB7B4qIxNWc4BUTdhjbgn+1VtC3x+bzF+Jo4LFmlkQ2lp9uevSBSl1+7j/tLNYYsbH FLOGrrFIHbJEgoeOpCAPbf2xflv6eN6U7GNtR123FT+eNRlvyNUBFVXc67pwU5hJpnCOfT jFf/rfJaZUi/bbU3tls/QZyYoNJ/1LyNzdKjF/d9pqVM3MhKaUwI4PBAFoMDYQj37VPWND 09Mo2n0PxUipm2TpsUxFRVih4NB9k4w6VMiNHzNUUjxSL10A07gc3v8K69XDrce8xa6vzB TYCPMaBwJxT+MZiWBAn8Pl/ayzFSiQvpV9m26iv1p0sEQzlkq6nccd9PliU8Ew== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1647772879; a=rsa-sha256; cv=none; b=AlR1430u12qC87rcOO125RnXDMa/RuszJB5d3YbSAVL/EBCi7F19ujFMpYaG2vX0Ke6e4b aUflOeK3o7t7/iWVbZNnN8zEEH8kdD+D94iNm21XuV/r2QF99WX1N/zGMyFRbziAIhbkAb jBBzcr9+02dfpUPv/9o5UWO9lfqU8ceu9+c7iaOnW1HZbqyKeSC8CIhLeydE53oSNDMI3j WRmN5VZxMybxVN4ecFvUm93gIsreg48jBrGXRmtVsPYdjqOJnKlGUrUwVUYSuInwy86S1U Cx9AYYKkJ0R4YLuiPwYeVqVR01tNBhATz4RjtGJ/ifW2UXHsmnJxLp1V/qa34Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=burningswell-com.20210112.gappssmtp.com header.s=20210112 header.b=CwHfJLpA; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -1.13 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=burningswell-com.20210112.gappssmtp.com header.s=20210112 header.b=CwHfJLpA; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 099D728246 X-Spam-Score: -1.13 X-Migadu-Scanner: scn1.migadu.com X-TUID: nnRlYQrK7bU5 --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain Hi Maxime, ok, I see. Thanks for the explanation. I attached a patch that removes the icons from the source as per your suggestion. What do you think about this one? Thanks, Roman. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Remove-lsp-treemacs-icons-from-source.patch Content-Transfer-Encoding: quoted-printable Content-Description: Remove icons from source From=205468ef15c239133366314d0d5131e440c2e8893f Mon Sep 17 00:00:00 2001 From: r0man Date: Sat, 19 Mar 2022 15:33:24 +0100 Subject: [PATCH] Remove lsp-treemacs icons from source There's an issue [1] with the icon licenses of the Emacs lsp-treemacs package. This patch removes the icons directory from the sources. [1] https://github.com/emacs-lsp/lsp-treemacs/issues/123 =2D-- gnu/packages/emacs-xyz.scm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index dcd36291fb..1b6e54ef18 100644 =2D-- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -24426,6 +24426,8 @@ (define-public emacs-lsp-treemacs (url "https://github.com/emacs-lsp/lsp-treemacs") (commit version))) (file-name (git-file-name name version)) + (modules '((guix build utils))) + (snippet '(begin (delete-file-recursively "icons") #t)) (sha256 (base32 "05ivqa5900139jzjhwc3nggwznhm8564dz4ydcxym2ddd63571k0")))) (build-system emacs-build-system) =2D-=20 2.34.0 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Maxime Devos writes: > [[PGP Signed Part:Undecided]] > Roman Scherer schreef op zo 20-03-2022 om 09:59 [+0100]: >> Since the icons are not installed on a Guix system right now, I think >> we can leave the Guix emacs-lsp-treemacs packages as it is for now. >> >> Once upstream has added the licenses for the icons, we could take >> another look and maybe only install the ones that we are allowed to >> include. >> >> What do you think? > > Even though they are not currently installed, I would still remove > them from the 'source', as per (guix)Software Freedom: > >> Some otherwise free upstream package sources contain a small and >> optional subset that violates the above guidelines, for instance >> because this subset is itself non-free code. When that happens, >> the offending items are removed with appropriate patches or code >> snippets in the =E2=80=98origin=E2=80=99 form of the package (*note Defi= ning >> Packages::). This way, =E2=80=98guix build --source=E2=80=99 returns th= e =E2=80=9Cfreed=E2=80=9D >> source rather than the unmodified upstream source. > > That's about code, not icons, but the same principles apply I'd think. > (Though for some reason, the FSDG makes an exception for things like > images in the section =E2=80=98Non-functional Data=E2=80=99?) > > (In this case, the idea icons are likely to be non-free, the netbeans > and eclipse icons are presumabl non-free.) > > Even if the =E2=80=98Non-Functional Data=E2=80=99 exception is followed, = I think > the source should still remove things that do not seem to follow the > licensing requirements (*) (and hence, might be illegal to > redistribute), to avoid nasty surprises for users doing "guix build -- > sources=3Dtransitive foo bar ...". > > (*) TBC, I am not accusing emacs-lsp-treemacs of violating license > terms. Rather, it is not clear to me that it does _not_ violate > licensing terms, and I'd like any potential licensing concerns to be > investigated (and corrected, if necessary) before including the icons > in Guix. > > Greetings, > Maxime. > > [[End of PGP Signed Part]] --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQFTBAEBCAA9FiEE0iajOdjfRIFd3gygPdpSUn0qwZkFAmI3BIcfHHJvbWFuLnNj aGVyZXJAYnVybmluZ3N3ZWxsLmNvbQAKCRA92lJSfSrBmVOAB/9CykOJ9SPo1Aba 0tERgAXpncjPqsXqJ4onL4+SW1/Lo6eQN9bJXc2ciJ3xghaCifuKmo5zTC1ECFDO IjHNYRyAMGiIIXNrHxXtE5G93n4s9q2cTs3vkoaUQ5ZOCd9eQQHJbzrIZ0tcl8iB BgGgJLxorsJJiqxBaH72QrPb3nklg2Xb0C3we+hhsLhgUa2bY4TL++4kLJ7cf0uz LFBx7H7Z9P33Z+LUKpFBwmoO5z2m57fKCWl+wAyDli2cd2240T4C7/KYtxWNKIsa M5sB8T+3JmBO/YATo3vkG9WeVv07lAOxG6DD+4XEb3EUmCZkHFQO5GS2CDsQX6VD lI9rpRWv =HF2H -----END PGP SIGNATURE----- --==-=-=--