From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id MIhLLgEawGI8FwAAbAwnHQ (envelope-from ) for ; Sat, 02 Jul 2022 12:12:17 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id YHNoLQEawGIcHgAAG6o9tA (envelope-from ) for ; Sat, 02 Jul 2022 12:12:17 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id CDE93E45F for ; Sat, 2 Jul 2022 12:12:16 +0200 (CEST) Received: from localhost ([::1]:36072 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o7a6p-0006n5-MG for larch@yhetil.org; Sat, 02 Jul 2022 06:12:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40612) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o7a6c-0006mi-4E for bug-guix@gnu.org; Sat, 02 Jul 2022 06:12:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:45931) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o7a6b-00082f-RY for bug-guix@gnu.org; Sat, 02 Jul 2022 06:12:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o7a6b-0003CG-Ju for bug-guix@gnu.org; Sat, 02 Jul 2022 06:12:01 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#56297: Guix style imperfections Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sat, 02 Jul 2022 10:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56297 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Maxime Devos Cc: 56297@debbugs.gnu.org Received: via spool by 56297-submit@debbugs.gnu.org id=B56297.165675669112248 (code B ref 56297); Sat, 02 Jul 2022 10:12:01 +0000 Received: (at 56297) by debbugs.gnu.org; 2 Jul 2022 10:11:31 +0000 Received: from localhost ([127.0.0.1]:39828 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o7a67-0003BT-Em for submit@debbugs.gnu.org; Sat, 02 Jul 2022 06:11:31 -0400 Received: from eggs.gnu.org ([209.51.188.92]:55628) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o7a65-0003BH-T2 for 56297@debbugs.gnu.org; Sat, 02 Jul 2022 06:11:30 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:46700) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o7a60-000803-30; Sat, 02 Jul 2022 06:11:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=DY+vRrpajUeOumjSv2P49H2MYh8pxyrpUcjYcifttAI=; b=r5/YrYMNKhdME8zUnBuU pJreqUctbIFLY6TmTf/patUQouUsdmRk3D8+DDVIMmAPetPd2RysCZOSrem5PKL8f0vko4AkBBSOQ 1Mq05M9S8bGXDnCWsOiEKvwILiHQ7oW5W1CEz/IHSC/ks/9bv8M8KfM5x7w2GOaU4odJQ3E3qsHnI gXVEtaXtNjbsDDH/0/dUrM4coeBpb1KygLUYvb6vDWQgeUc27hwVDxWsqdi+RRbT+QiQmez0YqcMK iN0YsyCG83wzOgRbaW3xEz6L5I1bxcQ18wdI/KUsH0PIDHZFDjNh/Ce4F/GSHr1TyD28ITBrS7jsF TCkG1hs0UvqOxw==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:52066 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o7a5z-0006zX-L4; Sat, 02 Jul 2022 06:11:23 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <9499300db3fe4222f7126240fb2acad3cdf4371b.camel@telenet.be> Date: Sat, 02 Jul 2022 12:11:21 +0200 In-Reply-To: <9499300db3fe4222f7126240fb2acad3cdf4371b.camel@telenet.be> (Maxime Devos's message of "Wed, 29 Jun 2022 11:33:05 +0200") Message-ID: <87sfnj259y.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1656756737; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=DY+vRrpajUeOumjSv2P49H2MYh8pxyrpUcjYcifttAI=; b=AnwT0qOCLMCcGXq1GgG6/N+Yg4hBLg0hkiwuf+cF95bmCH65qaaooLEehte39eAZfixEXd /aJqNCg7jIMEj2ImdS/BPdz3jqipSKifuyzQSamvhWA2RLTortb+o3c6trY/MYOyB9aCxh 63S3K8QcPfsdbu5bPW035VEDZsD0cG9c3GdbSoQMpONxs2yxDcfUJuOYToPeYG2Bh3mXON zSpyoeC+/dyzcIy2j4xwYTmY0PfjEq+lLJL5xyhbcsci+YqADSsV0vcf2VmVNyhSIsqqOR gXtjWGDGx+fq0BA2wV8rQs2dxC2gfLS3PCvVQPXMx+ytz9bvXV+NtrhHJ9BBkQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1656756737; a=rsa-sha256; cv=none; b=ReCEzEDx0iYp+zVdXlV7bGPO6eajn8MDXCQqLkw9d2TQLih3P0fWrAXgsuDUakjVt1CNW/ 6SaTO92Y065uaakAvqb5JD3gbfc5tohYqvUE7VUS24xYHxh5Hl81kCY9XKZKkEXy3w12xY 8W7kQKeAkEtkoW3TZprAnkYBlzPnabsEAff5mmEpx2OdBLlC426QAJUS50LVTEcDq5DJpa p2TTNwaW1i+IaX/sqNeXu9xBl3N+q02GJc6q5gOS5o6u8ww9GJuJY4cDP5vaGN7QJ0kA18 b6RpODBJluXPRcLislMxy0SEFXI+e1PlMP4U/NTEBHAWetFBP4E4z6ucO+APcQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b="r5/YrYMN"; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.35 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b="r5/YrYMN"; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: CDE93E45F X-Spam-Score: -4.35 X-Migadu-Scanner: scn0.migadu.com X-TUID: 34ukHye61PfN Hi, Maxime Devos skribis: > "guix style" occasionally makes some decision that seem a bit > questionable to me. Let=E2=80=99s keep in mind that some are bugs/limitations that can be fixed, while others cannot really be addressed because our tastes vary depending on context and the pretty printer could hardly be made smart enough to distinguish all the subtleties. >> (define-public guile-next >> (let ((version "3.0.7") (revision "0") >> (commit "d70c1dbebf9ac0fd45af4578c23983ec4a7da535")) > > Conventionally 'revision' is put on another line -- for these kind of let= bindings, > (maybe all?), I would recommend to put all of them on separate lines. This one is a bug IMO: =E2=80=98let=E2=80=99 bindings should be treated spe= cially, and currently they=E2=80=99re not. >> (substitute-keyword-arguments (package-arguments guile-3.0) >> ((#:phases phases >> '%standard-phases) `(modify-phases ,phases > > Put %standard-phases on the same line ad #:phases phases and `(modify-pha= ses ,phases > on a new lineg=20 OK. >> (add-before 'check 'skip-failing-tests >> (lambda _ >> (substitute* "test-suite/standalone/= test-out-of-memory" >> (("!#") "!# >> >>(exit 77) >>")) > > I'd prefer the original "!#\n\n(exit 77)\n" here, but I don't know if tha= t's > something 'Guix style' could feasibly do (there might be situations where= a > newline might be appropriate, how could "guix style" which is the case?). Exactly: in synopses/descriptions, we do want to print newlines as-is (see =E2=80=98tests/style.scm=E2=80=99). Perhaps we could come up with heuristics that make different choices depending on context, but that sounds tricky. >> (delete-file >> "test-suite/tests/version.test") #t= )))))) > > (Would be nice if "guix style" could be taught to remove those #t, but th= at seems > more a feature limitation than a bug to me.) That could be the job of a different style rule (the =E2=80=98-S=E2=80=99 o= ption). >> (native-inputs (modify-inputs (package-native-inputs guile-3.0) >> (prepend autoconf >> automake >> libtool >> flex >> gnu-gettext >> texinfo >> gperf))) > > I'd consider it tidier to put (modify-inputs ...) on a new line Dunno it=E2=80=99s a matter of taste. :-) Ludo=E2=80=99.