From: Marius Bakke <marius@gnu.org>
To: zimoun <zimon.toutoune@gmail.com>, 58567@debbugs.gnu.org
Subject: bug#58567: Some grafts use a different input derivation than computed by --no-grafts
Date: Mon, 17 Oct 2022 13:36:21 +0200 [thread overview]
Message-ID: <87sfjmvg0a.fsf@gnu.org> (raw)
In-Reply-To: <878rlen3vt.fsf@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2620 bytes --]
zimoun <zimon.toutoune@gmail.com> skriver:
> Hi Marius,
>
> I reminds me this [1].
>
> 1: <https://yhetil.org/guix/874jy87gcl.fsf@gmail.com>
Not sure if it's the same problem, but it is weird. On 3d8c243efb615c7:
$ guix build mesa
/gnu/store/ccf705wvh0w224d6nyscnwlhqr04agk7-mesa-21.3.8-bin
/gnu/store/vcmxgmmhwr39gwwnz7ljkhcg1bmq2r5z-mesa-21.3.8
$ guix build --no-grafts mesa
/gnu/store/grh2142hg6l5g5xav2di7rr1pwbg9m38-mesa-21.3.8-bin
/gnu/store/sdzfljm6san79pqiy42yp0nzmkr2bafc-mesa-21.3.8
$ guix size icecat | grep mesa
/gnu/store/sdzfljm6san79pqiy42yp0nzmkr2bafc-mesa-21.3.8 411.6 169.6 11.6%
$ guix size $(guix build --no-grafts icecat) | grep mesa
/gnu/store/sdzfljm6san79pqiy42yp0nzmkr2bafc-mesa-21.3.8 411.6 169.6 11.6%
Should not the mesa used by icecat be the same as `guix build mesa`,
just like in the ungrafted case? Their outputs differ, too:
$ guix hash -r $(guix build mesa | tail -n1)
1invy9jcd1fnfx7d4asfyjqs1jn7lngjfqswak6sy9ffjbhhsg6x
$ guix hash -r $(guix size icecat | grep mesa | awk '{ print $1 }')
195zk0c0h5m016hp0c1haqws47rwfj7sbpqpddmwk2iw402p3apv
Diffoscope says it will take 123 days to process these, so don't hold
your breath!
> On dim., 16 oct. 2022 at 19:35, Marius Bakke <marius@gnu.org> wrote:
>
>> It works for 'python-patiencediff', but fails for 'python-patch-ng',
>> both of which have no dependencies other than Python; but one uses
>> url-fetch and the other git-fetch.
>
> I guess that
>
> guix build python-patch-ng -d
>
> uses a grafted git-minimal and propagates it, whereas
>
> guix build python-patch-ng -d --no-grafts
>
> uses a non-grafted git-minimal. Well, something like that. :-)
Indeed.
> Well, it is the same checkout output:
>
> --8<---------------cut here---------------start------------->8---
> $ guix build \
> /gnu/store/7bcypqy80bz8ygi4880dxdj8vzcsvhdf-python-patch-ng-1.17.4-checkout.drv \
> /gnu/store/ivbkmnl6md7lzf275nvqwdh6lc924hal-python-patch-ng-1.17.4-checkout.drv
> /gnu/store/jddbmm7nxhv9sl84j1jlsdy5iiwjpbiy-python-patch-ng-1.17.4-checkout
> /gnu/store/jddbmm7nxhv9sl84j1jlsdy5iiwjpbiy-python-patch-ng-1.17.4-checkout
> --8<---------------cut here---------------end--------------->8---
That's guaranteed since these derivations are "fixed-output" (notice the
r:sha256 property in the beginning of the file). If they had any other
output the daemon would throw a failure.
The bug here is that Guix treats grafted origins as different, even
though their outputs are known in advance.
Probably the grafting machinery should ignore fixed-output derivations
somehow?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]
next prev parent reply other threads:[~2022-10-17 11:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-16 17:06 bug#58567: Some grafts use a different input derivation than computed by --no-grafts Marius Bakke
2022-10-16 17:35 ` Marius Bakke
2022-10-17 10:25 ` zimoun
2022-10-17 11:36 ` Marius Bakke [this message]
2022-10-17 11:48 ` Marius Bakke
2022-10-17 11:54 ` Marius Bakke
2022-10-17 13:26 ` zimoun
2022-10-17 10:48 ` zimoun
2022-10-17 13:42 ` bug#58567: Grafting affects origins Ludovic Courtès
2022-10-18 8:42 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sfjmvg0a.fsf@gnu.org \
--to=marius@gnu.org \
--cc=58567@debbugs.gnu.org \
--cc=zimon.toutoune@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).