From: "Ludovic Courtès" <ludo@gnu.org>
To: Liliana Marie Prikler <liliana.prikler@ist.tugraz.at>
Cc: 58631@debbugs.gnu.org
Subject: bug#58631: [Shepherd] Indefinite heap growth (memory leak)
Date: Sat, 22 Oct 2022 22:21:20 +0200 [thread overview]
Message-ID: <87sfjf4njz.fsf_-_@gnu.org> (raw)
In-Reply-To: <3ba120cf2d9ec36d15bc89bc797eb004dbe91c18.camel@ist.tugraz.at> (Liliana Marie Prikler's message of "Fri, 21 Oct 2022 15:07:11 +0200")
Liliana Marie Prikler <liliana.prikler@ist.tugraz.at> skribis:
> Am Donnerstag, dem 20.10.2022 um 11:29 +0200 schrieb Ludovic Courtès:
>> Logging as performed by ‘%service-file-logger’ is quite GC-intensive
>> (but shouldn’t be leaky!); this bit:
>>
>> (let ((prefix (strftime default-logfile-date-format
>> (localtime (current-time)))))
>> (format output "~a~a~%" prefix line)
>> (loop))
>
> (let ((prefix (strftime default-logfile-date-format
> (localtime (current-time)))))
> (format output "~a~a~%" prefix line)
> (loop))
>
> Would it make a difference if you instead wrote
>
> (let ((prefix (strftime default-logfile-date-format
> (localtime (current-time)))))
> (format output "~a~a~%" prefix line))
> (loop)
>
> ? Semantically, they're equivalent (perhaps with a wrapping begin
> needed), but the compiler might fail to see this.
I’m confident the compiler does the right thing, and it’s a tail call so
‘prefix’ doesn’t outlive one loop iteration.
Ludo’.
next prev parent reply other threads:[~2022-10-24 1:40 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-19 12:17 bug#58631: Shepherd crash on berlin Ludovic Courtès
2022-10-19 16:24 ` Ludovic Courtès
2022-10-20 9:29 ` Ludovic Courtès
2022-10-21 13:07 ` Liliana Marie Prikler
2022-10-22 20:20 ` bug#58631: [Shepherd] Indefinite heap growth (memory leak) Ludovic Courtès
2022-10-22 20:21 ` Ludovic Courtès [this message]
2022-10-22 20:29 ` Ludovic Courtès
2022-10-29 10:01 ` Ludovic Courtès
2022-10-29 14:54 ` Maxime Devos
2022-10-30 9:39 ` Ludovic Courtès
2022-11-06 22:45 ` Ludovic Courtès
2022-11-07 10:43 ` Ludovic Courtès
2022-11-10 8:51 ` Ludovic Courtès
2022-11-11 10:55 ` Ludovic Courtès
2022-10-20 17:49 ` Joshua Branson via Bug reports for GNU Guix
2022-10-20 21:46 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sfjf4njz.fsf_-_@gnu.org \
--to=ludo@gnu.org \
--cc=58631@debbugs.gnu.org \
--cc=liliana.prikler@ist.tugraz.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).