From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Timo Wilken <timo.wilken@cern.ch>
Cc: 61914@debbugs.gnu.org
Subject: bug#61914: IceCat does not start with en_GB.utf8 locale
Date: Fri, 03 Mar 2023 10:44:30 -0500 [thread overview]
Message-ID: <87sfel4z6p.fsf@gmail.com> (raw)
In-Reply-To: <87edq6errc.fsf@gmail.com> (Maxim Cournoyer's message of "Thu, 02 Mar 2023 17:02:31 -0500")
Hi,
Maxim Cournoyer <maxim.cournoyer@gmail.com> writes:
[...]
> Browsing about:config, I see:
>
> extensions.systemAddon.update.enabled false
>
> I wonder if this could make a different to be set to true instead. It's
> set to false by the makeicecat.sh script we run to transform the Firefox
> source into GNU IceCat. I guess we'll have to look at the source for
> more clues as to how language pack updates are handled exactly.
I have the same problem, where the French language pack I used with a
previous version of IceCat (102.7.0) is not updating to the
system-provided one. Setting 'extensions.systemAddon.update.enabled' to
'true' does not help.
I've now reported the issue upstream:
https://bugzilla.mozilla.org/show_bug.cgi?id=1820196.
I've also taken a peek at the source, and it seems the update/cache of
language pack modules would be handled in the
toolkit/mozapps/extensions/internal/XPIDatabase.jsm, e.g. in
processFileChanges and updateExistingAddon. It seems the cache should
be invalidated in our situation, based on the comment and logic:
--8<---------------cut here---------------start------------->8---
/**
* Updates the databse metadata for an existing add-on during database
* reconciliation.
*
* @param {AddonInternal} oldAddon
* The existing database add-on entry.
* @param {XPIState} xpiState
* The XPIStates entry for this add-on.
* @param {AddonInternal?} newAddon
* The new add-on metadata for the add-on, as loaded from a
* staged update in addonStartup.json.
* @param {boolean} aUpdateCompatibility
* true to update add-ons appDisabled property when the application
* version has changed
* @param {boolean} aSchemaChange
* The schema has changed and all add-on manifests should be re-read.
* @returns {AddonInternal?}
* The updated AddonInternal object for the add-on, if one
* could be created.
*/
updateExistingAddon(
oldAddon,
xpiState,
newAddon,
aUpdateCompatibility,
aSchemaChange
) {
XPIDatabase.recordAddonTelemetry(oldAddon);
let installLocation = oldAddon.location;
// Update the add-on's database metadata from on-disk metadata if:
//
// a) The add-on was staged for install in the last session,
// b) The add-on has been modified since the last session, or,
// c) The app has been updated since the last session, and the
// add-on is part of the application bundle (and has therefore
// likely been replaced in the update process).
if (
newAddon ||
oldAddon.updateDate != xpiState.mtime ||
(aUpdateCompatibility && this.isAppBundledLocation(installLocation))
) {
newAddon = this.updateMetadata(
installLocation,
oldAddon,
xpiState,
newAddon
);
} else if (oldAddon.path != xpiState.path) {
newAddon = this.updatePath(installLocation, oldAddon, xpiState);
} else if (aUpdateCompatibility || aSchemaChange) {
newAddon = this.updateCompatibility(
installLocation,
oldAddon,
xpiState,
aSchemaChange
);
} else {
newAddon = oldAddon;
}
if (newAddon) {
newAddon.rootURI = newAddon.rootURI || xpiState.rootURI;
}
return newAddon;
},
--8<---------------cut here---------------end--------------->8---
To be continued...
--
Thanks,
Maxim
next prev parent reply other threads:[~2023-03-03 15:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-02 12:33 bug#61914: IceCat does not start with en_GB.utf8 locale Timo Wilken
2023-03-02 14:54 ` Maxim Cournoyer
2023-03-02 16:37 ` Timo Wilken
2023-03-02 22:02 ` Maxim Cournoyer
2023-03-03 15:44 ` Maxim Cournoyer [this message]
2023-03-06 14:48 ` Maxim Cournoyer
2023-08-28 22:45 ` Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sfel4z6p.fsf@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=61914@debbugs.gnu.org \
--cc=timo.wilken@cern.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).