unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: Ricardo Wurmus <rekado@elephly.net>, 63043@debbugs.gnu.org
Subject: bug#63043: texlive-font-maps.drv build failure when profiles lacks texlive-* packages
Date: Mon, 01 May 2023 08:24:52 -0400	[thread overview]
Message-ID: <87sfcg5je3.fsf@gmail.com> (raw)
In-Reply-To: <87354hqejq.fsf@gnu.org> ("Ludovic Courtès"'s message of "Sun, 30 Apr 2023 22:51:37 +0200")

Hi Ludovic,

Ludovic Courtès <ludo@gnu.org> writes:

> Hi,
>
> Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:
>
>>> There were cases (like GDK pixbuf, GLib schemas, and all that) where the idea
>>> was to take whichever glib/GDK we’d find in the dependency graph, and
>>> pick the command we need from it.  That way, we wouldn’t introduce any
>>> additional dependency.  That was the reasoning.
>>>
>>> Thinking about, this particular case might be easier: we can make things
>>> consistent like so:
>
> [...]
>
>>> +    (if (and texlive-base (pair? texlive-inputs))
>>>          (gexp->derivation "texlive-font-maps" build
>>>                            #:substitutable? #f
>>>                            #:local-build? #t
>>>
>>>
>>> That way, the hook only fire if we have ‘texlive-base’ (somewhere in the
>>> graph) *and* we have texlive-* packages in the manifest.
>>
>> That is equivalent, but it doesn't address the core problem in my
>> opinion.  There's no use to run hooks for things which aren't propagated
>> at the level of the profile, I think.  If texlive-base in is the
>> profile, the person wants to use tex and friends.  But if it's wrapped
>> by some package deep down, we shouldn't care.
>>
>> I see it the same way as when using libraries and compilers in a
>> profile; the compiler (consumer) needs to be present else no search path
>> is created.
>>
>> Does it make sense?
>
> I agree with the reasoning; I think it doesn’t apply to the GLib schemas
> and GDK pixbuf caches though.

It does, for the simple reasons that both GDK pixbufs and GLib schemas
are collected using manifest-inputs, which means only direct inputs from
the profile and the ones they propagate.  So if you look deep in the
profile graph for the 'glib-compile-schemas' command, there is a chance
that it is found while no schemas were collected, and this is the kind
of case that'd lead to an empty derivation output (because there's no
schema to compile).

> For TeX Live font maps, maybe it applies, though I’m not entirely sure
> (I wouldn’t be surprised if things other than ‘texlive-base’ are
> consumers of font maps).  Plus, since the patch I proposed is simple,
> I’m inclined to just do that.
>
> Thoughts?

I still think that my proposition is better, but I don't mind if you
apply your fix now and we revisit this at a later time.  If we get to
it, this change could be reverted as it wouldn't be necessary anymore.

-- 
Thanks,
Maxim




  reply	other threads:[~2023-05-01 12:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-23 23:07 bug#63043: texlive-font-maps.drv build failure when profiles lacks texlive-* packages Ludovic Courtès
2023-04-24  1:20 ` Maxim Cournoyer
2023-04-24 21:15   ` Ludovic Courtès
2023-04-25  1:41     ` Maxim Cournoyer
2023-04-30 20:51       ` Ludovic Courtès
2023-05-01 12:24         ` Maxim Cournoyer [this message]
2023-05-04 11:14           ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sfcg5je3.fsf@gmail.com \
    --to=maxim.cournoyer@gmail.com \
    --cc=63043@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    --cc=rekado@elephly.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).