From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id 0IKNLlmCHmVOfQEAauVa8A:P1 (envelope-from ) for ; Thu, 05 Oct 2023 11:31:05 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id 0IKNLlmCHmVOfQEAauVa8A (envelope-from ) for ; Thu, 05 Oct 2023 11:31:05 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5C537661BA for ; Thu, 5 Oct 2023 11:31:05 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=mooBo+oH; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1696498265; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=m4lAuSzVEh1/xw7ktIRAPk7Aq56T6VK2Boc/LUM1Pnc=; b=sQK8z3LbzfQ2PiflVqTQI5ZycpkoCkbGZ5d7Taclp3d9rk2vHj7nqKbIq1MRW35uA8asnj YSi0+McpQjuQfe/foY3UvNMKg0BY5HeqHPjylhaIMsUFc/zWqRNEQxVT82p/PRTr+xZLdU Wy7AttdqNnUzRJgu8kankTV55M7Ezym+l2KFHfKtZ3Bh1xK4neZqW5R317Y4yByHjkKXth pLz/+Bwj2I1T5zJydEYkYo0IJ/nJOHK9bzopvek5qLl0JQK5ln0e4xXgny+dGypNSZl4pz y9hScB5P/EcK3LCoFgfhfDpqdy3IkR7pcydQy2BMelLNJ5ziXcbdAbc6TvoXRA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1696498265; a=rsa-sha256; cv=none; b=giRJSGrJobcB2WYuXvhl20F9CiJoEYy8Aa+2AVnOjHBOQQofrIFZig9QEqyAWD3wyv0eRU xjwm5UzbSxkNS6uAXFJtXwZ+wioUnIRIaay2QGvc29KGDoqlDZT6nvyxi0fGWwMuWPTYss nlS8nn7BZpZDgjudzK8qEgv4H+6O14DSXgrCJ1f3rrxerz1sFrbX2igPRb46S8h6BtjnWe QFlN4dnJZNWzOZKab+oUuns8Z/TGzXMk2NtVvAnDUlS3VnA4dC4lIjILpw12NCzsFdlOeP qEpiyeNlmXftr7DwKiXwHSMR7i2B8QP989tpJMwFOcQJ3NhsmeleDkB1KVGXdA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=mooBo+oH; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qoKg6-0007xF-M2; Thu, 05 Oct 2023 05:29:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qoKg0-0007wF-2T for bug-guix@gnu.org; Thu, 05 Oct 2023 05:29:48 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qoKfw-0005Pk-Nz for bug-guix@gnu.org; Thu, 05 Oct 2023 05:29:47 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qoKgE-0008Uf-Hx for bug-guix@gnu.org; Thu, 05 Oct 2023 05:30:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#66305: Error with recursive git checkout Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Thu, 05 Oct 2023 09:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66305 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Simon Tournier Cc: Guillaume Le Vaillant , 66305@debbugs.gnu.org Received: via spool by 66305-submit@debbugs.gnu.org id=B66305.169649817132583 (code B ref 66305); Thu, 05 Oct 2023 09:30:02 +0000 Received: (at 66305) by debbugs.gnu.org; 5 Oct 2023 09:29:31 +0000 Received: from localhost ([127.0.0.1]:46018 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qoKfj-0008TR-Ft for submit@debbugs.gnu.org; Thu, 05 Oct 2023 05:29:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:32866) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qoKfh-0008TE-Ep for 66305@debbugs.gnu.org; Thu, 05 Oct 2023 05:29:30 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qoKfJ-0005IY-J1; Thu, 05 Oct 2023 05:29:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=m4lAuSzVEh1/xw7ktIRAPk7Aq56T6VK2Boc/LUM1Pnc=; b=mooBo+oHyl9pigGOLS12 y/IPWsp54WWxcoSehqbhoKxehFscxY9FTOECu7wgVuZt5kd0fk525mPPWdxY5vVXPU+POLrQUn83E AC9msqn25aonnOLAmNYd1BhTE4n7mKDAjCh5XnPVJMst7rcUapsf+xG9rbo8YHxI0hNRRNKylSqf5 g3QRBkzrUg/hzQ+Dd7DVU5v2SAL+61y+TbdDBwfAcJGluIChGhW3XXqjEPq6VWwNq3YdDNF/abViM 35xU/K1J2/TUuH4hQLvL4MHSxwDNRUzbAKU+cjTyZtHlBzqrgNU8z7j3nneAuzg0EIxVcOajhBy9U /CLr5LHzh7sBJg==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= In-Reply-To: <87r0maz21l.fsf@gmail.com> (Simon Tournier's message of "Wed, 04 Oct 2023 20:16:06 +0200") References: <877co34ide.fsf@gmail.com> <87v8bm9wx7.fsf@gnu.org> <87r0maz21l.fsf@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Quartidi 14 =?UTF-8?Q?Vend=C3=A9miaire?= an 232 de la =?UTF-8?Q?R=C3=A9volution,?= jour du =?UTF-8?Q?R=C3=A9s=C3=A9da?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Thu, 05 Oct 2023 11:28:58 +0200 Message-ID: <87sf6p8lk5.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx0.migadu.com X-Migadu-Spam-Score: -6.92 X-Spam-Score: -6.92 X-Migadu-Queue-Id: 5C537661BA X-TUID: hyTyDa4Fx39V Hello, Simon Tournier skribis: > On Wed, 04 Oct 2023 at 18:25, Ludovic Court=C3=A8s wrote: > >> diff --git a/guix/scripts/perform-download.scm b/guix/scripts/perform-do= wnload.scm >> index 045dd84ad6..c869f19502 100644 >> --- a/guix/scripts/perform-download.scm >> +++ b/guix/scripts/perform-download.scm >> @@ -108,6 +108,10 @@ (define* (perform-git-download drv output >> (drv-output (assoc-ref (derivation-outputs drv) "out")) >> (algo (derivation-output-hash-algo drv-output)) >> (hash (derivation-output-hash drv-output))) >> + ;; Commands such as 'git submodule' expect Coreutils and sed (amo= ng >> + ;; others) to be in $PATH. >> + (setenv "PATH" "/run/current-system/profile/bin:/bin:/usr/bin") >> + >> (git-fetch-with-fallback url commit output >> #:recursive? recursive? >> #:git-command %git)))) > > LGTM. > > Well, I would add a comment explicitly mentioning that=E2=80=99s a tempor= ary fix > pointing this issue #66305. It=E2=80=99s not temporary in that it will still be needed for example by t= he Debian package of Guix. But yeah, I=E2=80=99ll clarify that in the comment. > And I have tested with: > > $ guix build ocaml-ansiterminal -S --no-substitutes > $ guix build volk --no-substitutes --check -S Awesome, thanks for checking! Ludo=E2=80=99.