bug#24135: guix system reconfigure fails on successful build

[ludo@gnu.org (Ludovic Courtès)]

Hi again!  :-)

myglc2 <myglc2@gmail.com> skribis:

> root@g1 ~# guix system reconfigure system40.scm
> substitute: updating list of substitutes from 'https://mirror.hydra.gnu.org'... 100.0%
> The following derivation will be built:
>    /gnu/store/g5mj74zvdbq074qvmddfdqikxvz6739w-grub.cfg.drv
> /gnu/store/qfq7kzqg9xcw1j5nvgs6wif2ymydm2n7-system
> /gnu/store/qi3r489mq7hchzi87avp89n08gv4g1yk-grub.cfg
> /gnu/store/zgm8s5z5y9dh0g36jqxh5i30js93irk5-grub-2.02beta3
> activating system...
> setting up setuid programs in '/run/setuid-programs'...
> populating /etc from /gnu/store/3vbg3i84k9z57kj5xwz91h08b59mh9yb-etc...
> usermod: no changes
> usermod: no changes
> usermod: no changes
> making '/gnu/store/qfq7kzqg9xcw1j5nvgs6wif2ymydm2n7-system' the current system...
> guix system: loading new services: device-mapping-/dev/md0 file-system-/mnt/md0...
> shepherd: Evaluating user expression (register-services (primitive-load "/gn...") #).
> Backtrace:
> In ice-9/boot-9.scm:
>  157: 9 [catch #t #<catch-closure 2636ba0> ...]
> In unknown file:
>    ?: 8 [apply-smob/1 #<catch-closure 2636ba0>]
> In ice-9/boot-9.scm:
>   63: 7 [call-with-prompt prompt0 ...]
> In ice-9/eval.scm:
>  432: 6 [eval # #]
> In ice-9/boot-9.scm:
> 2401: 5 [save-module-excursion #<procedure 2653940 at ice-9/boot-9.scm:4045:3 ()>]
> 4050: 4 [#<procedure 2653940 at ice-9/boot-9.scm:4045:3 ()>]
> 1724: 3 [%start-stack load-stack ...]
> 1729: 2 [#<procedure 266aea0 ()>]
> In unknown file:
>    ?: 1 [primitive-load "/gnu/store/5ibkqq9414k3l762yi4ps63i9yjr7vlz-guix-0.10.0-1.97c8/bin/.guix-real"]
> In guix/ui.scm:
> 1209: 0 [run-guix-command system "reconfigure" "system40.scm"]

The backtrace shouldn’t be here.  Fixed by
aa1e73a996ad170fecac848f203528aeb3d2173e.

> guix/ui.scm:1209:6: In procedure run-guix-command:
> guix/ui.scm:1209:6: Throw to key `srfi-34' with args `(#<condition &action-exception-error [service: device-mapping-/dev/md0 action: start key: unbound-variable args: (#f "Unbound variable: ~S" (every) #f)] 8a9b640>)'.

Fixed in 10618627bfe210f4ec84ab3018f12840704a11e0.

For the record, non-top-level forms work with compiled code, but note
with eval’d code, which is what happens here (the Shepherd ’eval’ action
uses ‘eval’, which gives it an (ice-9 eval) procedure):

--8<---------------cut here---------------start------------->8---
scheme@(guile-user)> (define u (make-fresh-user-module))
scheme@(guile-user)> u
$6 = #<module (#{ g7828}#) 4d13c60>
scheme@(guile-user)> (eval '(lambda () (use-modules(srfi srfi-1)) every) u)
$7 = #<procedure 56bc270 at ice-9/eval.scm:416:20 ()>
scheme@(guile-user)> ($7)
ERROR: In procedure memoize-variable-access!:
ERROR: Unbound variable: every

Entering a new prompt.  Type `,bt' for a backtrace or `,q' to continue.
scheme@(guile-user) [1]> ,q
scheme@(guile-user)> (eval '(lambda () (current-module)) u)
$8 = #<procedure 481d060 at ice-9/eval.scm:416:20 ()>
scheme@(guile-user)> ($8)
$9 = #<directory (guile-user) 1f5ebd0>
scheme@(guile-user)> (eval '(lambda () (eval-when (expand load eval) (current-module))) u)
$10 = #<procedure 56b0e40 at ice-9/eval.scm:416:20 ()>
scheme@(guile-user)> ($10)
$11 = #<directory (guile-user) 1f5ebd0>
--8<---------------cut here---------------end--------------->8---

Thank you for finding and reporting all these bugs!

Ludo’.