From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
Subject: bug#30505: marionette/virtio-console issues lead to test failures
Date: Mon, 19 Feb 2018 16:54:44 +0100
Message-ID: <87r2phezzv.fsf@gnu.org>
References: <87vaevi2sk.fsf@gnu.org> <20180218114833.7d5e7848@scratchpost.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33009)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ennmV-0002fh-C1
	for bug-guix@gnu.org; Mon, 19 Feb 2018 10:55:08 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ennmQ-0008Uk-S4
	for bug-guix@gnu.org; Mon, 19 Feb 2018 10:55:07 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:43571)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1ennmQ-0008UZ-Oj
	for bug-guix@gnu.org; Mon, 19 Feb 2018 10:55:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ennmQ-0002kN-Ga
	for bug-guix@gnu.org; Mon, 19 Feb 2018 10:55:02 -0500
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.30505.B30505.151905568910526@debbugs.gnu.org>
In-Reply-To: <20180218114833.7d5e7848@scratchpost.org> (Danny Milosavljevic's
	message of "Sun, 18 Feb 2018 11:48:33 +0100")
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix/>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: "bug-Guix" <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: 30505@debbugs.gnu.org

Heya,

Danny Milosavljevic <dannym@scratchpost.org> skribis:

> On Sun, 18 Feb 2018 01:01:31 +0100
> ludo@gnu.org (Ludovic Court=C3=A8s) wrote:
>
>> The =E2=80=9C\x1b;%G=E2=80=9D sequences correspond to the =E2=80=9Cselec=
t UTF-8=E2=80=9D console code
>> (see console_codes(4)).  We=E2=80=99re receiving this as if we were a co=
nsole,
>> but in fact all we want is to exchange raw bytes between the host and
>> the guest; we don=E2=80=99t want to be a full-fledged console.
>
> A lot of the tests pass console=3D... and thus in fact have a real consol=
e.
>
> It might be that our new automatic console getty interferes.
> I doubt it - I checked agetty sources and it doesn't touch iutf8.
> Might still be worth a try to remove agetty from %base-services.

This isn=E2=80=99t the culprit.

I hadn=E2=80=99t noticed this is now part of =E2=80=98%base-services=E2=80=
=99.  It would be nice
if it were enabled on ARM only.  Thoughts?

>> this happens on =E2=80=98core-updates=E2=80=99 and not =E2=80=98master=
=E2=80=99.
>
> That's a good question.
>
> Anyway, I think these codes are emitted by unicode_start - so
> as a first step, sabotage the kbd package so that it can't
> use unicode_start.  Does it work then?

Commenting out (display "\x1b%G" (fdes->outport fd)) in (gnu services
base) appear to solve the problem.  It seems that it used to affect just
the terminal behind FD and now somehow broadcasts to all existing
terminals?

Anyway, I=E2=80=99m unsure this =E2=80=98display=E2=80=99 call was needed a=
t all.  It seems
redundant with the =E2=80=98tcsetattr=E2=80=99 call below.  So I think we=
=E2=80=99ll just remove
it.

Thoughts?

Ludo=E2=80=99.