From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id OHRACf450V4tcAAA0tVLHw (envelope-from ) for ; Fri, 29 May 2020 16:36:14 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id mHkWBf450V58BgAA1q6Kng (envelope-from ) for ; Fri, 29 May 2020 16:36:14 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B357E94030E for ; Fri, 29 May 2020 16:36:13 +0000 (UTC) Received: from localhost ([::1]:34712 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jehzQ-0006KE-Mu for larch@yhetil.org; Fri, 29 May 2020 12:36:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33006) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jehzH-0006In-GN for bug-guix@gnu.org; Fri, 29 May 2020 12:36:05 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:44397) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jehzF-0004Pl-Uk for bug-guix@gnu.org; Fri, 29 May 2020 12:36:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jehzF-0004HF-SR for bug-guix@gnu.org; Fri, 29 May 2020 12:36:01 -0400 Subject: bug#41546: Shepherd network activation failures on armhf Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-To: bug-guix@gnu.org Resent-Date: Fri, 29 May 2020 16:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 41546 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Jesse Dowell Mail-Followup-To: 41546@debbugs.gnu.org, ludo@gnu.org, jesse.dowell@gmail.com Received: via spool by 41546-done@debbugs.gnu.org id=D41546.159077014316402 (code D ref 41546); Fri, 29 May 2020 16:36:01 +0000 Received: (at 41546-done) by debbugs.gnu.org; 29 May 2020 16:35:43 +0000 Received: from localhost ([127.0.0.1]:55942 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jehyx-0004GT-CP for submit@debbugs.gnu.org; Fri, 29 May 2020 12:35:43 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53730) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jehys-0004GE-1w for 41546-done@debbugs.gnu.org; Fri, 29 May 2020 12:35:41 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:42908) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jehym-00044q-Hz; Fri, 29 May 2020 12:35:32 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=44828 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jehym-00018o-2j; Fri, 29 May 2020 12:35:32 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: Date: Fri, 29 May 2020 18:35:29 +0200 In-Reply-To: (Jesse Dowell's message of "Tue, 26 May 2020 16:02:10 -0400") Message-ID: <87r1v2zoku.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 41546-done@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: pr4kHUUGfM/e Hi Jesse, Jesse Dowell skribis: > I was able to track my issue down to recently introduced code in > guix/build/syscalls.scm related to the GNU Hurd. > > The following patch fixes the problem for me. The core of the issue is th= at > the new Hurd related checks use string-suffix? rather than string-contai= ns > like the code elsewhere in the module. > > Whan string-suffix? is used it doesn't match my system %host-type which is > "arm-unknown-linux-gnueabihf" and the xxxx-socket-address!/hurd branch is > taken rather than xxxx-socket-address!/linux. Indeed, great investigation work! > I don't know if this is only a problem on my unsupported device. I'm > running guix system on a Raspberry Pi 4b. > > Here's the patch that fixes the issue for me. > ------------------------- > diff --git a/guix/build/syscalls.scm b/guix/build/syscalls.scm > index 8070c5546f..6be322d68f 100644 > --- a/guix/build/syscalls.scm > +++ b/guix/build/syscalls.scm > @@ -1404,7 +1404,7 @@ bytevector BV at INDEX." > (error "unsupported socket address" sockaddr))))) > > (define write-socket-address! > - (if (string-suffix? "linux-gnu" %host-type) > + (if (string-contains %host-type "linux-gnu") > write-socket-address!/linux > write-socket-address!/hurd)) > > @@ -1436,7 +1436,7 @@ bytevector BV at INDEX." > (vector family))))) > > (define read-socket-address > - (if (string-suffix? "linux-gnu" %host-type) > + (if (string-contains %host-type "linux-gnu") > read-socket-address/linux > read-socket-address/hurd)) I pushed it as b56cbe8974c328a6c7bc28906478ef1b191ada4c on your behalf. Thank you! Ludo=E2=80=99.