From: "Ludovic Courtès" <ludo@gnu.org>
To: "Jan \(janneke\) Nieuwenhuizen" <janneke@gnu.org>
Cc: 42151@debbugs.gnu.org
Subject: bug#42151: [PATCH v3 2/2] image: Do not set journal_model=WAL for the Hurd.
Date: Sat, 11 Jul 2020 16:22:18 +0200 [thread overview]
Message-ID: <87r1tiw2qt.fsf@gnu.org> (raw)
In-Reply-To: <20200710183551.12807-2-janneke@gnu.org> (Jan Nieuwenhuizen's message of "Fri, 10 Jul 2020 20:35:51 +0200")
"Jan (janneke) Nieuwenhuizen" <janneke@gnu.org> skribis:
> This fixes <https://bugs.gnu.org/42151>.
>
> * gnu/system/images/hurd.scm (hurd-initialize-root-partition): Use #:wal-mode #f
> in call to ...
> * gnu/build/image.scm (initialize-root-partition): ... this, add #:wal-mode?
> parameter, pass it to ...
> (register-closure): ... this, add #:wal-mode? parameter, pass it to ...
> * guix/store/database.scm (with-database): ... this, add #:wal-mode?
> parameter, pass it to ...
> (call-with-database): ... this, add #:wal-mode? parameter; when
> set to #f, do not set journal_model=WAL.
[...]
> +++ b/gnu/system/images/hurd.scm
> @@ -61,8 +61,8 @@
> #~(lambda* (#:rest args)
> (apply initialize-root-partition
> (append args
> - (list #:make-device-nodes
> - make-hurd-device-nodes)))))
> + (list #:make-device-nodes make-hurd-device-nodes
> + #:wal-mode? #f)))))
IWBN to have an XXX comment here stating why we disable WAL mode on
GNU/Hurd, possibly referencing this issue. That way, we can eventually
revisit the issue and hopefully get rid of this workaround.
Apart from that the patch LGTM, thanks!
Ludo’.
next prev parent reply other threads:[~2020-07-11 14:23 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-01 14:29 bug#42151: [PATCH 0/3] offload to Childhurd fails: setting synchronous mode: locking protocol Jan (janneke) Nieuwenhuizen
2020-07-01 14:31 ` bug#42151: [PATCH 1/3] gnu: Add sqlite/hurd with locking fix Jan (janneke) Nieuwenhuizen
2020-07-01 14:31 ` bug#42151: [PATCH 2/3] gnu: guile-sqlite3: Use sqlite/hurd for locking on the Hurd Jan (janneke) Nieuwenhuizen
2020-07-10 12:06 ` Ludovic Courtès
2020-07-10 18:34 ` Jan Nieuwenhuizen
2020-07-01 14:31 ` bug#42151: [PATCH 3/3] gnu: guix: " Jan (janneke) Nieuwenhuizen
2020-07-10 12:07 ` Ludovic Courtès
2020-07-10 16:25 ` Jan Nieuwenhuizen
2020-07-10 12:05 ` bug#42151: [PATCH 1/3] gnu: Add sqlite/hurd with locking fix Ludovic Courtès
2020-07-10 18:34 ` Jan Nieuwenhuizen
2020-07-01 17:01 ` bug#42151: [PATCH 0/3] offload to Childhurd fails: setting synchronous mode: locking protocol Jan Nieuwenhuizen
2020-07-02 12:49 ` Ludovic Courtès
2020-07-03 10:03 ` Jan Nieuwenhuizen
2020-07-03 13:51 ` Ludovic Courtès
2020-07-03 15:27 ` Jan Nieuwenhuizen
2020-07-04 8:12 ` bug#42151: [PATCH 4/3] database: Do not use journal_model=WAL for the Hurd Jan Nieuwenhuizen
2020-07-07 5:04 ` Jan Nieuwenhuizen
2020-07-10 12:03 ` Ludovic Courtès
2020-07-10 15:40 ` Jan Nieuwenhuizen
2020-07-10 12:34 ` bug#42151: [PATCH 0/3] offload to Childhurd fails: setting synchronous mode: locking protocol Ludovic Courtès
2020-07-10 15:42 ` bug#42151: [PATCH v2 1/4] gnu: Add sqlite/hurd with locking fix Jan (janneke) Nieuwenhuizen
2020-07-10 15:42 ` bug#42151: [PATCH v2 2/4] gnu: guile-sqlite3: Use sqlite/hurd for locking on the Hurd Jan (janneke) Nieuwenhuizen
2020-07-10 15:42 ` bug#42151: [PATCH v2 3/4] gnu: guix: " Jan (janneke) Nieuwenhuizen
2020-07-10 15:42 ` bug#42151: [PATCH v2 4/4] image: Do not set journal_model=WAL for " Jan (janneke) Nieuwenhuizen
2020-07-10 18:35 ` bug#42151: [PATCH v3 1/2] gnu: sqlite: Add locking-mode fix " Jan (janneke) Nieuwenhuizen
2020-07-10 18:35 ` bug#42151: [PATCH v3 2/2] image: Do not set journal_model=WAL " Jan (janneke) Nieuwenhuizen
2020-07-11 14:22 ` Ludovic Courtès [this message]
2020-07-11 14:36 ` Jan Nieuwenhuizen
2020-07-11 14:18 ` bug#42151: [PATCH v3 1/2] gnu: sqlite: Add locking-mode fix " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r1tiw2qt.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=42151@debbugs.gnu.org \
--cc=janneke@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).