From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id sCbuOqrdIl+2AwAA0tVLHw (envelope-from ) for ; Thu, 30 Jul 2020 14:48:10 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id CA7lNqrdIl8bMQAAB5/wlQ (envelope-from ) for ; Thu, 30 Jul 2020 14:48:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 179069400BF for ; Thu, 30 Jul 2020 14:48:10 +0000 (UTC) Received: from localhost ([::1]:34214 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k19qr-0007CN-4U for larch@yhetil.org; Thu, 30 Jul 2020 10:48:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34422) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k19qk-0007CD-9D for bug-guix@gnu.org; Thu, 30 Jul 2020 10:48:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:53172) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k19qj-0000zc-VQ for bug-guix@gnu.org; Thu, 30 Jul 2020 10:48:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k19qj-00055b-Qn for bug-guix@gnu.org; Thu, 30 Jul 2020 10:48:01 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#42548: Cuirass 504 errors Resent-From: Mathieu Othacehe Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Thu, 30 Jul 2020 14:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42548 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 42548@debbugs.gnu.org Received: via spool by 42548-submit@debbugs.gnu.org id=B42548.159612044319517 (code B ref 42548); Thu, 30 Jul 2020 14:48:01 +0000 Received: (at 42548) by debbugs.gnu.org; 30 Jul 2020 14:47:23 +0000 Received: from localhost ([127.0.0.1]:36485 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k19q7-00054i-3t for submit@debbugs.gnu.org; Thu, 30 Jul 2020 10:47:23 -0400 Received: from eggs.gnu.org ([209.51.188.92]:52456) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k19q5-00054W-Ip for 42548@debbugs.gnu.org; Thu, 30 Jul 2020 10:47:22 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:39094) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k19q0-0000sv-9g for 42548@debbugs.gnu.org; Thu, 30 Jul 2020 10:47:16 -0400 Received: from [2a01:cb18:832e:5f00:e0a7:8073:f3be:5cd4] (port=50264 helo=cervin) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1k19pz-0002jK-Cj for 42548@debbugs.gnu.org; Thu, 30 Jul 2020 10:47:15 -0400 From: Mathieu Othacehe References: <87eeoy9rzk.fsf@gnu.org> Date: Thu, 30 Jul 2020 16:47:12 +0200 In-Reply-To: <87eeoy9rzk.fsf@gnu.org> (Mathieu Othacehe's message of "Sun, 26 Jul 2020 18:10:55 +0200") Message-ID: <87r1st83gv.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: HXTpB+MV0v5y Hey, > A second issue is caused when a build product download is started, then > aborted. In that case, sendfile throws an exception or enters an endless > loop. Ok, so I found a couple of errors here. First, I noticed that it was not possible to download simultaneously two build products, because the first download was blocking the whole process. This is solved by: 6ad9c602697ffe33c8fbb09ccd796b74bf600223. In short, current-fiber was set to #f, both in the context of the caller and the spawned thread. So I think the get-message operating was blocking the whole thread instead of suspending the current fiber. But if someone else could take a look it would be nice :). Second issue, sendfile may throw EPIPE or ECONNRESET if the client disconnects before the end of the transfer. I think, besides the dirty backtrace, it was not harmful. But anyway, its better to catch this as we are doing in "guix publish", see: 0955a11abd9e27c96a1375cca6a1c97869b5780a. I fear it won't be enough to fix the 504 errors, but at least it's a start. Thanks, Mathieu