From: zimoun <zimon.toutoune@gmail.com>
To: Lulu <me@erkin.party>
Cc: "44030@debbugs.gnu.org" <44030@debbugs.gnu.org>
Subject: bug#44030: guix import pypi foo@1.2.3 breaks
Date: Mon, 02 Nov 2020 13:15:50 +0100 [thread overview]
Message-ID: <87r1pc54zt.fsf@gmail.com> (raw)
In-Reply-To: <1958052003.4017.1604009380285@office.mailbox.org> (Lulu's message of "Fri, 30 Oct 2020 01:09:40 +0300 (TRT)")
Hi,
On Fri, 30 Oct 2020 at 01:09, Lulu <me@erkin.party> wrote:
> Okay, I tested this a bit and it seems to work fine. I'm going to write formal
> tests for it (and other importers, if possible) later.
Usually, we try to use the option ’--reroll-count’ of git-format-patch
for the second (or third or more) version. It helps the review to know
– from the subject – which is the email to read, etc. Well, next
time. :-)
What do you mean by write “formal tests”?
All the best,
simon
next prev parent reply other threads:[~2020-11-02 12:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-16 13:48 bug#44030: guix import pypi foo@1.2.3 breaks zimoun
2020-10-25 19:09 ` bug#44030: [PATCH] guix: import: Add versioning syntax to pypi importer Lulu
2020-10-25 20:04 ` Lulu
2020-10-26 15:49 ` zimoun
2020-10-25 20:50 ` bug#44030: guix import pypi foo@1.2.3 breaks Lulu
2020-10-26 15:58 ` zimoun
2020-10-28 19:32 ` bug#44030: [PATCH] import: pypi: Add '@' syntax for specifying the package version Lulu
2020-10-29 22:09 ` bug#44030: guix import pypi foo@1.2.3 breaks Lulu
2020-11-02 12:15 ` zimoun [this message]
2021-11-21 6:14 ` Maxim Cournoyer
2021-11-22 9:07 ` zimoun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r1pc54zt.fsf@gmail.com \
--to=zimon.toutoune@gmail.com \
--cc=44030@debbugs.gnu.org \
--cc=me@erkin.party \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).