From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id mOQHCENsrV8tUAAA0tVLHw (envelope-from ) for ; Thu, 12 Nov 2020 17:09:23 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id 6KXNA0NsrV9caAAAB5/wlQ (envelope-from ) for ; Thu, 12 Nov 2020 17:09:23 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B460A94053D for ; Thu, 12 Nov 2020 17:09:22 +0000 (UTC) Received: from localhost ([::1]:56904 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kdG64-0003F3-KS for larch@yhetil.org; Thu, 12 Nov 2020 12:09:20 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:51812) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kdG3q-0000lj-SS for bug-guix@gnu.org; Thu, 12 Nov 2020 12:07:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:33948) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kdG3q-0007NT-HW for bug-guix@gnu.org; Thu, 12 Nov 2020 12:07:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kdG3q-00009X-BQ for bug-guix@gnu.org; Thu, 12 Nov 2020 12:07:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#44353: [PATCH version-1.2.0 v2] guix: system: Add a new '--non-volatile' option for disk-image. Resent-From: Mathieu Othacehe Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Thu, 12 Nov 2020 17:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44353 X-GNU-PR-Package: guix X-GNU-PR-Keywords: patch To: Maxim Cournoyer Received: via spool by 44353-submit@debbugs.gnu.org id=B44353.1605200815573 (code B ref 44353); Thu, 12 Nov 2020 17:07:02 +0000 Received: (at 44353) by debbugs.gnu.org; 12 Nov 2020 17:06:55 +0000 Received: from localhost ([127.0.0.1]:45494 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kdG3i-00009B-Qm for submit@debbugs.gnu.org; Thu, 12 Nov 2020 12:06:54 -0500 Received: from eggs.gnu.org ([209.51.188.92]:51678) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kdG3e-00008v-VT for 44353@debbugs.gnu.org; Thu, 12 Nov 2020 12:06:54 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:56216) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kdG3Z-0007IW-NT; Thu, 12 Nov 2020 12:06:45 -0500 Received: from [2a01:e0a:19b:d9a0:a5e0:155b:c52:63c1] (port=40702 helo=cervin) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kdG3R-0006VB-2T; Thu, 12 Nov 2020 12:06:39 -0500 From: Mathieu Othacehe References: <87h7q0cdns.fsf@gnu.org> <20201112070917.11794-1-maxim.cournoyer@gmail.com> <877dqrvums.fsf@gnu.org> <87h7pufwop.fsf@gmail.com> Date: Thu, 12 Nov 2020 18:06:34 +0100 In-Reply-To: <87h7pufwop.fsf@gmail.com> (Maxim Cournoyer's message of "Thu, 12 Nov 2020 09:59:18 -0500") Message-ID: <87r1oyjyhx.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 44353@debbugs.gnu.org, Jesse Gibbons Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Scanner: ns3122888.ip-94-23-21.eu Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Spam-Score: -1.51 X-TUID: lDFpsnHTouvw Hello Maxim, > One thing I wasn't sure was if it'd be better to implicitly derive > volatile-root? #f when image-type was specified (not (eq? 'guess)). The > rationale being that users specifying the image-size themselves probably > want to make use of extra space (assumption) but can't unless > volatile-root? is #t on the image. > > If we choose the above it'd lead to less code and one less switch; on > the other hand it is not as explicit. > > What do you think? When developing the image API, I hesitated keeping the default of using volatile root file systems by default. In most cases, I think that the user may prefer to have non volatile images. They already have to copy the image from the store and make it writable so that QEMU can use it with "-hda" argument. Switching the default to non volatile could be an option I think. Doing what you are proposing: setting volatile to false when image-size is passed could also be a first step. Thanks, Mathieu