From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id uMfBJ7Xes185UgAA0tVLHw (envelope-from ) for ; Tue, 17 Nov 2020 14:31:17 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id kAagI7Xes19sWAAA1q6Kng (envelope-from ) for ; Tue, 17 Nov 2020 14:31:17 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 303529403E7 for ; Tue, 17 Nov 2020 14:31:17 +0000 (UTC) Received: from localhost ([::1]:59942 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kf20q-00045F-5T for larch@yhetil.org; Tue, 17 Nov 2020 09:31:16 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:36002) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kf20c-00043C-Uo for bug-guix@gnu.org; Tue, 17 Nov 2020 09:31:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:47216) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kf20c-0008Tn-Br for bug-guix@gnu.org; Tue, 17 Nov 2020 09:31:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kf20c-0006fC-93 for bug-guix@gnu.org; Tue, 17 Nov 2020 09:31:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#44626: tests/build-utils, tests/guix-system: fail when build path contains "~" Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Tue, 17 Nov 2020 14:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44626 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Vagrant Cascadian Received: via spool by 44626-done@debbugs.gnu.org id=D44626.160562341025537 (code D ref 44626); Tue, 17 Nov 2020 14:31:02 +0000 Received: (at 44626-done) by debbugs.gnu.org; 17 Nov 2020 14:30:10 +0000 Received: from localhost ([127.0.0.1]:58762 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kf1zl-0006do-Kv for submit@debbugs.gnu.org; Tue, 17 Nov 2020 09:30:10 -0500 Received: from eggs.gnu.org ([209.51.188.92]:35702) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kf1zi-0006cC-Ql for 44626-done@debbugs.gnu.org; Tue, 17 Nov 2020 09:30:07 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:54949) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kf1zd-000833-56; Tue, 17 Nov 2020 09:30:01 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=49276 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kf1zZ-0005qq-7b; Tue, 17 Nov 2020 09:29:57 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <87zh3ksnqh.fsf@yucca> <87pn4dy0od.fsf@gnu.org> <87zh3gr7cy.fsf@yucca> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 27 Brumaire an 229 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Tue, 17 Nov 2020 15:29:55 +0100 In-Reply-To: <87zh3gr7cy.fsf@yucca> (Vagrant Cascadian's message of "Mon, 16 Nov 2020 19:26:53 -0800") Message-ID: <87r1osqcnw.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 44626-done@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Scanner: ns3122888.ip-94-23-21.eu Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Spam-Score: -1.51 X-TUID: XwJh7QTedlpG Hi Vagrant, Vagrant Cascadian skribis: > Though may introduce a different issue in tests/build-utils.log: > > ... > test-name: wrap-script, simple case > location: /build/guix-41NMGX/guix-1.2.0~rc1/tests/build-utils.scm:152 > source: > + (test-equal > + "wrap-script, simple case" > + (string-append > + (format > + #f > + "#!~a --no-auto-compile\n#!#; Guix wrapper\n#\\-~s\n#\\-~s\n" > + (which "guile") > + '(begin > + (let ((current (getenv "GUIX_FOO"))) > + (setenv > + "GUIX_FOO" > + (if current > + (string-append > + "/some/path:/some/other/path" > + ":" > + current) > + "/some/path:/some/other/path")))) > + '(let ((cl (command-line))) > + (apply execl > + "/anything/cabbage-bash-1.2.3/bin/sh" > + (car cl) > + (cons (car cl) (append '("") cl))))) > + script-contents) > + (call-with-temporary-directory > + (lambda (directory) > + (let ((script-file-name > + (string-append directory "/foo"))) > + (call-with-output-file > + script-file-name > + (lambda (port) (display script-contents port))) > + (chmod script-file-name 511) > + (wrap-script > + script-file-name > + `("GUIX_FOO" > + prefix > + ("/some/path" "/some/other/path"))) > + (let ((str (call-with-input-file > + script-file-name > + get-string-all))) > + (with-directory-excursion > + directory > + (delete-file "foo")) > + str))))) > FORMAT: INTERNAL ERROR IN FORMAT-ERROR! > destination: # /tmp/guix-directory.YrSRbV/foo.3efcPU 8> > format string: "#!/build/guix-41NMGX/guix-1.2.0~rc1/guile > --no-auto-compile\n#!#; Guix wrapper\n#\\-(begin (let ((current > (getenv \"GUIX_FOO\"))) (setenv \"GUIX_FOO\" (if current > (string-append \"/some/path:/some/other/path\" \":\" current) > \"/some/path:/some/other/path\"))))\n#\\-(let ((cl > (command-line))) (apply execl > \"/anything/cabbage-bash-1.2.3/bin/sh\" (car cl) (cons (car cl) > (append (quote (\"\")) cl))))\n" > format args: () > error args: (#f "error in format" () #f) > FORMAT: INTERNAL ERROR IN FORMAT-ERROR! > destination: # /tmp/guix-directory.YrSRbV/foo.3efcPU 8> > format string: "#!/build/guix-41NMGX/guix-1.2.0~rc1/guile > --no-auto-compile\n#!#; Guix wrapper\n#\\-(begin (let ((current > (getenv \"GUIX_FOO\"))) (setenv \"GUIX_FOO\" (if current > (string-append \"/some/path:/some/other/path\" \":\" current) > \"/some/path:/some/other/path\"))))\n#\\-(let ((cl > (command-line))) (apply execl > \"/anything/cabbage-bash-1.2.3/bin/sh\" (car cl) (cons (car cl) > (append (quote (\"\")) cl))))\n" > format args: () > error args: (#<&wrap-error program: > "/tmp/guix-directory.YrSRbV/foo" type: misc-error>) > expected-value: "#!/build/guix-41NMGX/guix-1.2.0~rc1/guile > --no-auto-compile\n#!#; Guix wrapper\n#\\-(begin (let ((current (getenv > \"GUIX_FOO\"))) (setenv \"GUIX_FOO\" (if current (string-append > \"/some/path:/some/other/path\" \":\" current) > \"/some/path:/some/other/path\"))))\n#\\-(let ((cl (command-line))) > (apply execl \"/anything/cabbage-bash-1.2.3/bin/sh\" (car cl) (cons (car > cl) (append (quote (\"\")) > cl))))\n#!/anything/cabbage-bash-1.2.3/bin/sh\n\necho hello world" > actual-value: #f > actual-error: > + (%exception > + #<&wrap-error program: "/tmp/guix-directory.YrSRbV/foo" type: > misc-error>) > result: FAIL Turns out =E2=80=98wrap-script=E2=80=99 itself passes a non-literal string = to =E2=80=98format=E2=80=99, hence this error. I=E2=80=99m fixing this in =E2=80=98core-updates=E2=80= =99 since it=E2=80=99s a full-rebuild change: commit 55fb5e5d2113a732a03e255371f0172800483023. Thanks, Ludo=E2=80=99.