unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: zimoun <zimon.toutoune@gmail.com>
Cc: Jesse Gibbons <jgibbons2357@gmail.com>, 44893@debbugs.gnu.org
Subject: bug#44893: `guix deploy` doesn't recognize option --dry-run
Date: Sat, 05 Dec 2020 15:24:19 +0100	[thread overview]
Message-ID: <87r1o472lo.fsf@gnu.org> (raw)
In-Reply-To: <867dq5rc37.fsf@gmail.com> (zimoun's message of "Sat, 28 Nov 2020 11:48:44 +0100")

[-- Attachment #1: Type: text/plain, Size: 31 bytes --]

Hi,

We can make this change:


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 889 bytes --]

diff --git a/guix/scripts/deploy.scm b/guix/scripts/deploy.scm
index 0725fba54b..d9371b3d4a 100644
--- a/guix/scripts/deploy.scm
+++ b/guix/scripts/deploy.scm
@@ -165,7 +165,9 @@ Perform the deployment specified by FILE.\n"))
           (with-build-handler (build-notifier #:use-substitutes?
                                               (assoc-ref opts 'substitutes?)
                                               #:verbosity
-                                              (assoc-ref opts 'verbosity))
+                                              (assoc-ref opts 'verbosity)
+                                              #:dry-run?
+                                              (assoc-ref opts 'dry-run?))
             (parameterize ((%graft? (assq-ref opts 'graft?)))
               (map/accumulate-builds store
                                      (cut deploy-machine* store <>)

[-- Attachment #3: Type: text/plain, Size: 179 bytes --]


It may not be the kind of “dry run” that users have in mind for ‘guix
deploy’, as you note zimoun, but that’s probably better than nothing.

Thoughts?

Ludo’.

  reply	other threads:[~2020-12-05 14:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-26 20:11 bug#44893: `guix deploy` doesn't recognize option --dry-run Jesse Gibbons
2020-11-28 10:48 ` zimoun
2020-12-05 14:24   ` Ludovic Courtès [this message]
2022-07-25 12:31     ` Maxim Cournoyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r1o472lo.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=44893@debbugs.gnu.org \
    --cc=jgibbons2357@gmail.com \
    --cc=zimon.toutoune@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).