From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id IHKOEUzWVWCgcAAA0tVLHw (envelope-from ) for ; Sat, 20 Mar 2021 11:02:36 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id 8K1KDUzWVWBIJwAAbx9fmQ (envelope-from ) for ; Sat, 20 Mar 2021 11:02:36 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 924B6BA81 for ; Sat, 20 Mar 2021 12:02:35 +0100 (CET) Received: from localhost ([::1]:58624 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lNZNK-0000fr-KS for larch@yhetil.org; Sat, 20 Mar 2021 07:02:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37376) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lNZMo-0000fZ-UM for bug-guix@gnu.org; Sat, 20 Mar 2021 07:02:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:40069) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lNZMn-0006fb-SU for bug-guix@gnu.org; Sat, 20 Mar 2021 07:02:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lNZMn-0000E3-P9 for bug-guix@gnu.org; Sat, 20 Mar 2021 07:02:01 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#47115: Redundant library grafts leads to breakage Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sat, 20 Mar 2021 11:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47115 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Mark H Weaver Received: via spool by 47115-submit@debbugs.gnu.org id=B47115.1616238112402 (code B ref 47115); Sat, 20 Mar 2021 11:02:01 +0000 Received: (at 47115) by debbugs.gnu.org; 20 Mar 2021 11:01:52 +0000 Received: from localhost ([127.0.0.1]:51615 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lNZMd-000069-L3 for submit@debbugs.gnu.org; Sat, 20 Mar 2021 07:01:51 -0400 Received: from eggs.gnu.org ([209.51.188.92]:44366) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lNZMb-0008S9-Nc for 47115@debbugs.gnu.org; Sat, 20 Mar 2021 07:01:50 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:52373) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lNZMS-0006UR-QH; Sat, 20 Mar 2021 07:01:42 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=33242 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lNZMD-00016k-UH; Sat, 20 Mar 2021 07:01:37 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <87a6r7294k.fsf@netris.org> <877dmb1owa.fsf@netris.org> <874khds84o.fsf@netris.org> <87y2epqnq8.fsf@netris.org> <875z1rjyfn.fsf@netris.org> <8735wvjw25.fsf@netris.org> Date: Sat, 20 Mar 2021 12:01:24 +0100 In-Reply-To: <8735wvjw25.fsf@netris.org> (Mark H. Weaver's message of "Tue, 16 Mar 2021 05:18:15 -0400") Message-ID: <87r1ka9ji3.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 47115@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1616238155; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=UcYspCVZPWJlJr74f2V6A9wWLr1xd3qVh8RWXqviq7c=; b=dxUfUCm28Obri3ZBCnjh9RF3PUWYtyu0eGduMbq2dCqJbQb/7/B9Hn1sDVXhOt/aR1a87l Wxv49Qznkzp/RWcJZztyPZybaFmz4G6E4VCA4Da0S3id5OMLAiAYJoHR1hDDAbne+ue1ZU qEEJ8YgqLCO0opcp0ksuR2w7XymN3jO6D5swbMw97iV9RnFaw4MWlH1B053bnof2u9crTk RCLXWqPnmB+Kd5NziEQVSnWiA7ClH2RNsytrKM6oqJBhVq+oprVRf8JfUE4rrHWS1i+jEb dZk4CVIEZsIPhYf0FKikU784N623An2tIlBqa9KqQ13tSgxu5MUvofQafJguww== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1616238155; a=rsa-sha256; cv=none; b=rvYmUNZ6NexNy+Xi40iN5y8NEuKgWNGykeH6lN237fpFTXkc/bjT86ePAKA2ulOfBZpfVn 12KAY9LvoVMQxqINSYnJ1EnuDAzW1NXl+4+4na6UK7AzBqocvLkk5Ub5HFI4Tqx5bjLjyR hEjoEFMArLJ+f2DI1ZOEUfpNfUrNQrB1nS1GDukOjaN1CbTVaFXgm2P2tH++Fv9QDvJ105 Bpk10//nJockByUkFClMAGKKdPj4QNKgFnUjDuYXIpq2/TmoSvqC5NWIa8RF3JmG4/+Nl8 ZzqsvMWaxYdYj3PH2A4aAUdWcD3IeJkDV6OeJyuCU7k2/j3DNQnDVzeeGDxKCQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Spam-Score: -2.91 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Queue-Id: 924B6BA81 X-Spam-Score: -2.91 X-Migadu-Scanner: scn0.migadu.com X-TUID: 6o5EhFz35tRM Hi Mark, Mark H Weaver skribis: > I think that my last hypothesis was on the right track, but not quite > right: > > * Instead of 'libcairo' being loaded twice, I now suspect that > "libguile-cairo.so" is being loaded twice. > > * Instead of the original and replacement libraries being loaded, I now > suspect that two different variants of the replacement "guile-cairo" > are being loaded. > > * Instead of libcairo type tags being duplicated, I now suspect that > duplicated smob tags are being allocated. > > However, *if* deduplication is enabled, two redundant replacements > created by grafting _should_ occupy the same inodes, assuming that the > replacement mappings are the same (modulo ordering), and assuming that > /gnu/store/.links doesn't hit a directory size limit (which can happen > on ext3/4, leading to missed deduplication opportunities). Woow, thanks for the investigation! You wouldn=E2=80=99t think that deduplication can have an effect on this kind of bug. > I've known about these redundant replacements in Guix for many years, > but was not aware of any significant practical problems arising from > them until now. Do you know why the two guile-cairo grafts differ in this case? I=E2=80=99m aware of one case that can lead to that: the grafting code can create grafts for just one output of the original derivation, or for all of them (commit 482fda2729c3e76999892cb8f9a0391a7bd37119). Maybe that=E2= =80=99s what=E2=80=99s happening here? Thank you! Ludo=E2=80=99.