From: Mark H Weaver <mhw@netris.org>
To: 47812@debbugs.gnu.org
Subject: bug#47812: Incorrect code in the Guix manual, but only on the website
Date: Thu, 15 Apr 2021 19:50:49 -0400 [thread overview]
Message-ID: <87r1jbgl8r.fsf@netris.org> (raw)
In the Guix manual, as it appears on our website,
https://guix.gnu.org/manual/devel/en/html_node/X-Window.html
the manual entry for 'slim-service-type' suggests the following code to
remove the 'gdm' service from %desktop-services.
--8<---------------cut here---------------start------------->8---
(modify-services %desktop-services
(delete gdm-service-type))
--8<---------------cut here---------------end--------------->8---
This code is incorrect. 'modify-services' does not support deleting
services.
The puzzling thing is that I can't find where this suggested code exists
in our git repository. The manual in our git repository is correct.
Instead of the code above, it suggests:
--8<---------------cut here---------------start------------->8---
(remove (lambda (service)
(eq? (service-kind service) gdm-service-type))
%desktop-services)
--8<---------------cut here---------------end--------------->8---
This is the case on our 'master', 'core-updates', and 'version-1.2.0'
branches. See:
https://git.sv.gnu.org/cgit/guix.git/tree/doc/guix.texi?id=ebd021f73292bf47b26a799665d6204574bae239#n17891
https://git.sv.gnu.org/cgit/guix.git/tree/doc/guix.texi?h=core-updates&id=76fc36d0a7215979bb74c05840f5a4de4ab5ea93#n17756
https://git.sv.gnu.org/cgit/guix.git/tree/doc/guix.texi?h=version-1.2.0&id=8603bcd5822a1a8364a7a74a698059d3d147568b#n17076
The correct text was added about 2 years ago, in the following commit:
https://git.sv.gnu.org/cgit/guix.git/commit/?id=dbef9015db107dd148133420b89af552ef08f8ee
I see no evidence of it being changed since then.
Any idea where the incorrect code on the website manual is coming from?
Thanks,
Mark
next reply other threads:[~2021-04-15 23:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-15 23:50 Mark H Weaver [this message]
2021-04-16 0:12 ` bug#47812: Incorrect code in the Guix manual, but only on the website Mark H Weaver
2021-04-16 1:13 ` Leo Famulari
2021-04-16 1:32 ` Leo Famulari
2021-04-16 3:38 ` Mark H Weaver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r1jbgl8r.fsf@netris.org \
--to=mhw@netris.org \
--cc=47812@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).