unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: "Dr. Arne Babenhauserheide" <arne_bab@web.de>
To: Julien Lepiller <julien@lepiller.eu>
Cc: 51693@debbugs.gnu.org
Subject: bug#51693: [patch] Add Java 17
Date: Mon, 15 Nov 2021 15:00:59 +0100	[thread overview]
Message-ID: <87r1bh1pgb.fsf@web.de> (raw)
In-Reply-To: <20211115135912.708ef981@tachikoma.lepiller.eu>

[-- Attachment #1: Type: text/plain, Size: 708 bytes --]

Hi,

Julien Lepiller <julien@lepiller.eu> writes:

> Hi, I think you fixed openjdk16 instead of openjdk17, this makes the
> patch a bit confusing to read.

I didn’t fix openjdk16, it’s just the change detection in git that makes
it look like that because there are unchanged lines in-between.

I wish I could make that better, but git just doesn’t understand the
semantics of the code, so it does not recognize the unchanged end of the
openjdk16 block and instead things that my insertion of openjdk17 is a
modification of the end of openjdk16 plus insertion of the start of
openjdk17.

Best wishes,
Arne
-- 
Unpolitisch sein
heißt politisch sein,
ohne es zu merken.
draketo.de

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 1125 bytes --]

  reply	other threads:[~2021-11-15 14:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-08 20:32 bug#51693: [patch] Add Java 17 Dr. Arne Babenhauserheide
2021-11-14 15:54 ` Julien Lepiller
2021-11-14 20:59   ` Dr. Arne Babenhauserheide
2021-11-15 12:59     ` Julien Lepiller
2021-11-15 14:00       ` Dr. Arne Babenhauserheide [this message]
2021-12-02 22:58 ` Ricardo Wurmus
2021-12-03  7:49   ` Dr. Arne Babenhauserheide

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r1bh1pgb.fsf@web.de \
    --to=arne_bab@web.de \
    --cc=51693@debbugs.gnu.org \
    --cc=julien@lepiller.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).