bug#39366: guix offload sometimes can use ~/.ssh/config, sometimes not

["Ludovic Courtès" <ludo@gnu.org>]

[-- Attachment #1: Type: text/plain, Size: 708 bytes --]

Hi,

zimoun <zimon.toutoune@gmail.com> skribis:

> On Wed, 05 Feb 2020 at 12:11, Ludovic Courtès <ludo@gnu.org> wrote:

[...]

>> That is confusing indeed.  It comes from the fact that ‘guix offload’ in
>> the last case is running as root; thus, it sees a different
>> ~/.ssh/config.
>
> Therefore, see 52517. :-)  And the manual is also confusing, IMHO.
>
> <http://issues.guix.gnu.org/issue/52517>
>
>
>> We could instruct ‘guix offload’ to always ignore ~/.ssh/config, but
>> that wouldn’t be great because using it can be useful.
>
> Well, I am in favor of POLA.

Yeah, actually that would be in line with
bd8345777f5a48ee61656248655ebac71a09e926.

How about this:


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 656 bytes --]

diff --git a/guix/scripts/offload.scm b/guix/scripts/offload.scm
index 9ddf458c13..925325ef5f 100644
--- a/guix/scripts/offload.scm
+++ b/guix/scripts/offload.scm
@@ -231,6 +231,9 @@ (define* (open-ssh-session machine #:optional max-silent-time)
                                ;; stateless instead.
                                #:knownhosts "/dev/null"
 
+                               ;; Likewise for ~/.ssh/config.
+                               #:config "/dev/null"
+
                                ;; We need lightweight compression when
                                ;; exchanging full archives.
                                #:compression

[-- Attachment #3: Type: text/plain, Size: 17 bytes --]


?

Ludo’.