From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id EOxLMJEATGJ9MgAAgWs5BA (envelope-from ) for ; Tue, 05 Apr 2022 10:40:49 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id sAkyLZEATGLzmAAAauVa8A (envelope-from ) for ; Tue, 05 Apr 2022 10:40:49 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 70B7D1DF3D for ; Tue, 5 Apr 2022 10:40:49 +0200 (CEST) Received: from localhost ([::1]:42344 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nbdsj-0007gU-21 for larch@yhetil.org; Tue, 05 Apr 2022 03:45:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43390) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nbds7-0007gJ-0d for bug-guix@gnu.org; Tue, 05 Apr 2022 03:45:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:59780) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nbds6-0008Dr-MQ for bug-guix@gnu.org; Tue, 05 Apr 2022 03:45:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nbds6-0000dz-IS for bug-guix@gnu.org; Tue, 05 Apr 2022 03:45:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#54666: Installation without non-root user accounts Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Tue, 05 Apr 2022 07:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54666 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Mathieu Othacehe Received: via spool by 54666-submit@debbugs.gnu.org id=B54666.16491446812418 (code B ref 54666); Tue, 05 Apr 2022 07:45:02 +0000 Received: (at 54666) by debbugs.gnu.org; 5 Apr 2022 07:44:41 +0000 Received: from localhost ([127.0.0.1]:53677 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nbdrl-0000cv-Jv for submit@debbugs.gnu.org; Tue, 05 Apr 2022 03:44:41 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:62822) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nbdrj-0000ca-7N for 54666@debbugs.gnu.org; Tue, 05 Apr 2022 03:44:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inria.fr; s=dc; h=from:to:cc:subject:references:date:in-reply-to: message-id:mime-version:content-transfer-encoding; bh=6bHMhHJ6fQwBKEg/ieCr7wyjlQsR9g8rjHu5JIeCU98=; b=E4q8O6rpnPzt4W+mL9YJlRgI7ynSDUT9MxC+aSpw2H7LJtdkZBuTUFmW KrPO8LesAntrFHAIu/x1LCQMiiZlbXm7BaEKExSid/WFoYe1EFcoeWMMO wUGe1n0DWkrUWPeatIbS40CZ/TcZOAOk1eF67zU2lcwPyG6jBGqXTku1x A=; X-IronPort-AV: E=Sophos;i="5.90,236,1643670000"; d="scan'208";a="10585790" Received: from unknown (HELO ribbon) ([193.50.110.173]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Apr 2022 09:44:34 +0200 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <875yntnlh5.fsf@inria.fr> <87k0c4swq5.fsf@gnu.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 16 Germinal an 230 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Tue, 05 Apr 2022 09:44:32 +0200 In-Reply-To: <87k0c4swq5.fsf@gnu.org> (Mathieu Othacehe's message of "Mon, 04 Apr 2022 17:18:42 +0200") Message-ID: <87r16cq8in.fsf@inria.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 54666@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1649148049; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=6bHMhHJ6fQwBKEg/ieCr7wyjlQsR9g8rjHu5JIeCU98=; b=G9UEVam2zj+OSd0EQjKYzdBGoqMu7pOnyjtFwxfxlB2SK0tr1DJUnlum0Y9xC5D7telW1w YxslAEAgdUmJG+folHdlM5j4jdaHSPArZR2HzA6dX9dBsEa+pgy3Kz3gl/HNtauuybZ97p dOgh1MFE1xs9FoAbvv587Q6AFUc5HBFeOo3YPqtydQyuC9OQ/0mZbl4EwnTtvQQU60qldJ JaSLwc6wR6sIx2UKu4LNFxh4S+mMyKr6XkYOpy+kV+5IIrWBiRDGEfUqPzTJd5QK4CiCj9 DlZqWQod5TFDNVCl5qv75/Bz74yNXxc/rghRWOKkFUqvyOVe+DfNOkrvn6kRXg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1649148049; a=rsa-sha256; cv=none; b=YDYGVNlKmNG6bxzfvxdBXSTasB9S2SH7qYrdKzwS2+OyciqIj2E5DSTErPU5N6Aj+59RCE HQdL0ytznua5dkVR0vJvgPhHsgTKn2tSUpSN1QZQmg3K9i5LIQDhwHwQ0nflbFzWzoapFK hyaNmUvi2QuuoKSONKEqANlHuiv9cjHKkyKqwF7++pBnefJt6WbumQsLpEfCPLHJ4vPxcz 9VLYCYySq5SsBm05S3krMxbUt1ypyO5yTkShLq9jpzUDW6iL6NMvumGlckHssvbzCjUygK S+HWxOMXEvyygehy3CZTp/v9VY4OKXpf9A1QGk4GEdWncb15z3IQpGXUYaA+cQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=inria.fr header.s=dc header.b=E4q8O6rp; dmarc=fail reason="SPF not aligned (relaxed)" header.from=inria.fr (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 5.73 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=inria.fr header.s=dc header.b=E4q8O6rp; dmarc=fail reason="SPF not aligned (relaxed)" header.from=inria.fr (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 70B7D1DF3D X-Spam-Score: 5.73 X-Migadu-Scanner: scn0.migadu.com X-TUID: oBuQ+QP5TwmX Hello! Mathieu Othacehe skribis: > From 829c3c2543ffd7f9b22a5e1fb40f7627b2c76414 Mon Sep 17 00:00:00 2001 > From: Mathieu Othacehe > Date: Mon, 4 Apr 2022 16:36:07 +0200 > Subject: [PATCH 1/2] installer: user: Forbid root user creation. > > Forbid root user creation as it could lead to a system without any > non-priviledged user accouts. > > Fixes: . > > * gnu/installer/newt/user.scm (run-user-add-page): Forbid it. [...] > + (cond > + ;; Empty field. > + ((or (string=3D? name "") > + (string=3D? home-directory "")) > + (begin > + (error-empty-field-page) > + (run-user-add-page))) > + ;; Reject root account. > + ((root-account? name) > + (begin > + (error-root-page) > + (run-user-add-page))) Nitpick: you can omit =E2=80=98begin=E2=80=99 here. > From cc32729700caa4b76d112b561a09dd0ff3ada768 Mon Sep 17 00:00:00 2001 > From: Mathieu Othacehe > Date: Mon, 4 Apr 2022 16:38:09 +0200 > Subject: [PATCH 2/2] installer: user: Remove useless filtering. > > * gnu/installer/user.scm (users->configuration): Remove root account filt= ering > that is now performed in the "run-user-add-page" procedure. LGTM, thanks for the quick fix! Ludo=E2=80=99.