From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id YEAnGvMAWmODtgAAbAwnHQ (envelope-from ) for ; Thu, 27 Oct 2022 05:54:27 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id wJcBGvMAWmNrpQAA9RJhRA (envelope-from ) for ; Thu, 27 Oct 2022 05:54:27 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 25B561FF77 for ; Thu, 27 Oct 2022 05:54:27 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ontvC-0007XD-L0; Wed, 26 Oct 2022 23:51:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ontv4-0007Vg-Dm for bug-guix@gnu.org; Wed, 26 Oct 2022 23:51:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ontv4-0001Iv-1e for bug-guix@gnu.org; Wed, 26 Oct 2022 23:51:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ontv3-00026k-PJ for bug-guix@gnu.org; Wed, 26 Oct 2022 23:51:01 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#58813: can't substitute etc/teams.scm command as doc suggests Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Thu, 27 Oct 2022 03:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 58813 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 58813@debbugs.gnu.org X-Debbugs-Original-To: bug-guix Received: via spool by submit@debbugs.gnu.org id=B.16668426268057 (code B ref -1); Thu, 27 Oct 2022 03:51:01 +0000 Received: (at submit) by debbugs.gnu.org; 27 Oct 2022 03:50:26 +0000 Received: from localhost ([127.0.0.1]:55694 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ontuU-00025t-AO for submit@debbugs.gnu.org; Wed, 26 Oct 2022 23:50:26 -0400 Received: from lists.gnu.org ([209.51.188.17]:40580) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ontuQ-00025j-N9 for submit@debbugs.gnu.org; Wed, 26 Oct 2022 23:50:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ontuQ-0005Ex-6l for bug-guix@gnu.org; Wed, 26 Oct 2022 23:50:22 -0400 Received: from mail-qt1-x833.google.com ([2607:f8b0:4864:20::833]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ontuL-00012K-BO for bug-guix@gnu.org; Wed, 26 Oct 2022 23:50:21 -0400 Received: by mail-qt1-x833.google.com with SMTP id g16so328185qtu.2 for ; Wed, 26 Oct 2022 20:50:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:message-id:date:subject:to:from:from:to:cc:subject :date:message-id:reply-to; bh=MI1jcVwa/65L2vYinNuzPk6PGGqSQ0ViVLsCN7hSUSk=; b=llmPhZB4G/H7mlxG3ftnE8wI08KauOhyRK1XL6Wh9hXiiUmiXGM+UUKLvSrL5/uDAo TJt3zUzBg1/XlRiEgoTGiczRV64M3M2kJXlALEmG91Ut6a8w34AGTlbf2URxpOdAXMrv puCodbCbvLxMNnI7SPRnXArYnrC1zXDWDZ+lGfr7LdGMdGWEiB1K3sGSJZmJxx6lWlEy tXec8GFItXhWMPc4g4W9FJ4kDVnGiRZTZE2u68vLki5MnndK8kZKgTF7t0orZWzNaoL5 AyG8m53QnLJJXHMV4ultjkrGtzuEPMh815kM0+Cpn6G/qfl39f/V0TURM58KCzFcQiMZ mQNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:subject:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=MI1jcVwa/65L2vYinNuzPk6PGGqSQ0ViVLsCN7hSUSk=; b=tttD68rNKDYvkqXzNDyWDZ/pviW5aAlt2kxub8b7Ni7tNW9WNP8JIk4sdcocqmrFn/ bJiX2mCCQ5afF3Oqd+rd4yhmmayUYxPx6hh5utuszRgcPfKfaxYaVeDtixBseqdf+LUq uiQTJaIQndEdyKEtlw6jLS2uLk0cSQHaJ8Lp6aAJ/XI4XnTk5j7mD2xCJCjtSo/HtlUJ o2YMjptGvVnN21k2/SeXZ7xs29tswuwJPM/KWvOqskXWg9izr6S6bZuVsklATNugGXX6 pbQwbL7eBVbT4VVxSTqmB/b1c2mTdvTdfWIEH1ARou3WslUPN6KEo/DhUmBMhVjRbwKI /NAQ== X-Gm-Message-State: ACrzQf36DUKtH7rol6EekotpjSAcCfsBWKwOcteFKYx4i2Mw11E3VAFh Kyb42ZgJNWn4W+PFW22RsPNgNN4hu7A= X-Google-Smtp-Source: AMsMyM5eh4V/GpHKZIA/+1dzDwqO2Wt5gF6N3Ptehgpm8Du5K/J056SzH9Vs1a8Zh5dDqCw9mUAd7Q== X-Received: by 2002:a05:622a:1911:b0:3a4:f16c:6969 with SMTP id w17-20020a05622a191100b003a4f16c6969mr4639420qtc.449.1666842615629; Wed, 26 Oct 2022 20:50:15 -0700 (PDT) Received: from hurd (dsl-152-21.b2b2c.ca. [66.158.152.21]) by smtp.gmail.com with ESMTPSA id bs10-20020ac86f0a000000b0035ce8965045sm281054qtb.42.2022.10.26.20.50.14 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Oct 2022 20:50:15 -0700 (PDT) From: Maxim Cournoyer Date: Wed, 26 Oct 2022 23:50:14 -0400 Message-ID: <87r0yuq615.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::833; envelope-from=maxim.cournoyer@gmail.com; helo=mail-qt1-x833.google.com X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, FREEMAIL_REPLY=1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "bug-Guix" Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1666842867; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:list-id:list-help:list-unsubscribe:list-subscribe: list-post:dkim-signature; bh=MI1jcVwa/65L2vYinNuzPk6PGGqSQ0ViVLsCN7hSUSk=; b=DGcSecotZDA4Uz5KsVltKBZGNEM+drZjWbxUc1rhWhd4gmvgE9mPbFQzT7lLKrUYm+Jg/g meuuqIzlzzEiGDcl5iXRUrWP7Ic8pk1sbaf/HnE/a4X2+Q8AZr8etAh538M2T07jACmAVs 1X9f2lfhMyWOi3ogiudRA+EEqp6RbaFTGu3TvDbUrYgbzj2L9KQbjA70HO9bNn4a/X6o+6 +h431hptoRO/NYNzDCRL8oUOwjPyJsT+rAsRIm2v6+mRwaVD5SjvEM2SqlLQ+Qzqo4CDC2 /RhJXbJMmgo9TAe3HUldWK+TTgxSxSW88DjTeEZObZFR4Nolhhb62YXxf9eH7w== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1666842867; a=rsa-sha256; cv=none; b=EgyKS6qoYbrUMwNQMMADKY9djLoU3Vj+Y/SbItI911qIRxamGPg2kieJn62h8wL1EkwJqU 0HQhL6RTj9iVvFBQInlDhsWfuaqQnV8QED2v9J0mejx4Gi/xXWQb87jw0c5G9sfF51FoP5 wsYfNZ+ceIZYXOKUyWBsGkPtxz6tuHFsL5BbT3dULn6AAIF4U6wqcGAtUYTacQCKE3vE0m uc2bwQ30MUwVhZfPatLaj0IMdGNipKPoV+URek1+zmMId9JIoGiDayqZpT273U2dAejipx cJCdBeBH4lWOU3eG0+wZGq0Pv97KT4WSWVV7WBr8c/akBR76Z6uPJS9oYzBt4w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=llmPhZB4; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 6.08 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=llmPhZB4; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 25B561FF77 X-Spam-Score: 6.08 X-Migadu-Scanner: scn0.migadu.com X-TUID: OI10SrIdQXT2 Hi, Today, I tried; --8<---------------cut here---------------start------------->8--- $ git send-email --to=guix-patches@gnu.org \ $(./etc/teams.scm cc-members origin/master HEAD) 0000-cover-letter.patch fatal: ambiguous argument 'some.email@redacted.com"': unknown revision or path not in the working tree. Use '--' to separate paths from revisions, like this: 'git [...] -- [...]' format-patch -o /tmp/pFSRbRNNoU --add-header="X-Debbugs-Cc: redacted@gmail.com" --add-header="X-Debbugs-Cc: redacted@email" [...]: command returned error: 128 $ ./etc/teams.scm cc-members origin/master HEAD --add-header="X-Debbugs-Cc: redacted@email" --add-header="X-Debbugs-Cc: redacted@email" ... --8<---------------cut here---------------end--------------->8--- You can see the command fails; this is because when using Bash command substitution $(), the quotes in the result are not interpreted and are thus part of the value (literals), which then gets split on white space. As a quick hacky fix, I tried removing the space and double quotes like: modified etc/teams.scm.in @@ -514,7 +514,7 @@ (define (cc . teams) "Return arguments for `git send-email' to notify the members of the given TEAMS when a patch is received by Debbugs." (format #true - "~{--add-header=\"X-Debbugs-Cc: ~a\"~^ ~}" + "~{--add-header=X-Debbugs-Cc:~a~^ ~}" (map person-email (delete-duplicates (append-map team-members teams) equal?)))) and sent a patch with that command: git send-email --to=guix-patches@gnu.org \ $(./etc/teams.scm cc-members origin/master HEAD 0000-cover-letter.patch It created https://issues.guix.gnu.org/58812 with it, but I don't see any of the X-Debbugs-Cc headers. Mmmh. -- Thanks, Maxim