From: "Ludovic Courtès" <ludo@gnu.org>
To: "Artyom V. Poptsov" <poptsov.artyom@gmail.com>
Cc: 58290@debbugs.gnu.org, Andrew Tropin <andrew@trop.in>,
Marius Bakke <marius@gnu.org>
Subject: bug#58290: guile ssh error on guix deploy
Date: Mon, 23 Jan 2023 22:50:48 +0100 [thread overview]
Message-ID: <87r0vkzzrb.fsf@gnu.org> (raw)
In-Reply-To: <87cz752el1.fsf@gmail.com> (Artyom V. Poptsov's message of "Mon, 23 Jan 2023 23:14:34 +0300")
Hi Artyom,
"Artyom V. Poptsov" <poptsov.artyom@gmail.com> skribis:
> I figured out how to fix Guile-SSH channel "leak", so to say, that lead
> to the OpenSSH "no more sessions" problem.
>
> Please run your tests with this branch and let me know if it works for
> you (including all the edge cases):
> https://github.com/artyom-poptsov/guile-ssh/tree/wip-fix-channel-leak
It works! Specifically, I ran:
guix shell guile guile-ssh \
--with-branch=guile-ssh=wip-fix-channel-leak -- \
guile ssh-channels.scm
and the script (same one as before) ran several hundreds of iterations
just fine.
I had looked at ‘ptob_close’ and related code but didn’t see this issue;
good catch!
If you plan to push a new release, we’ll just upgrade in Guix; otherwise
we can apply the patch locally.
Thank you!
Ludo’.
next prev parent reply other threads:[~2023-01-23 21:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-04 11:09 bug#58290: guile ssh error on guix deploy Andrew Tropin
2022-10-08 12:39 ` Ludovic Courtès
2022-10-14 6:45 ` Andrew Tropin
2022-10-17 14:39 ` Ludovic Courtès
2022-10-17 17:27 ` Marius Bakke
2022-10-18 15:31 ` Ludovic Courtès
2022-11-03 23:47 ` Marius Bakke
2022-11-10 10:06 ` Andrew Tropin
2023-01-12 12:11 ` Ludovic Courtès
2023-01-12 12:44 ` Ludovic Courtès
2023-01-22 20:00 ` Artyom V. Poptsov
2023-01-23 20:14 ` Artyom V. Poptsov
2023-01-23 21:50 ` Ludovic Courtès [this message]
2023-01-24 15:53 ` Andrew Tropin
2023-01-30 22:53 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r0vkzzrb.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=58290@debbugs.gnu.org \
--cc=andrew@trop.in \
--cc=marius@gnu.org \
--cc=poptsov.artyom@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).