From: "Ludovic Courtès" <ludo@gnu.org>
To: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Cc: 61676@debbugs.gnu.org
Subject: bug#61676: package transformations not honored working from a manifest
Date: Tue, 21 Feb 2023 23:49:35 +0100 [thread overview]
Message-ID: <87r0uid474.fsf@gnu.org> (raw)
In-Reply-To: <87mt57jgns.fsf@gmail.com> (Maxim Cournoyer's message of "Tue, 21 Feb 2023 08:23:51 -0500")
Hi,
Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:
> I was trying to simplify the Jami packaging tooling using the latest
> recursive '--with-source' transformation, like so (in a Makefile):
>
> define guix-pack-command
> guix pack -C xz -f deb -f extras/packaging/gnu-linux/guix/guix-pack-manifest.scm -v3 \
> --with-source=libjami@$(RELEASE_VERSION)=$(RELEASE_TARBALL_FILENAME) \
> --with-patch=libjami=extras/packaging/gnu-linux/guix/patches/jami-disable-integration-tests.patch \
> --with-source=jami@$(RELEASE_VERSION)=$(RELEASE_TARBALL_FILENAME) \
> -S /usr/bin/jami=bin/jami \
> -S /usr/share/applications/jami.desktop=share/applications/jami.desktop \
> -S /usr/share/icons/hicolor/scalable/apps/jami.svg=share/icons/hicolor/scalable/apps/jami.svg \
> -S /usr/share/icons/hicolor/48x48/apps/jami.png=share/icons/hicolor/48x48/apps/jami.png \
> -S /usr/share/metainfo/jami.appdata.xml=share/metainfo/jami.appdata.xml \
> --postinst-file=extras/packaging/gnu-linux/guix/guix-pack-deb.postinst
> endef
Interesting! :-)
> But noticed that --with-source and --with-patch were not effective for
> the jami-with-certs customized package provided by the
> guix-pack-manifest.scm manifest.
Indeed, that’s expected.
> It seems to me that the rewriting options should be honored on any
> packages being manipulated, whether they come from the Guix collection,
> a file, a manifest or another means.
I’m not convinced; I think manifests should be interpreted literally.
Incidentally, changing that would likely break existing workflows…
Ludo’.
next prev parent reply other threads:[~2023-02-21 22:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-21 13:23 bug#61676: package transformations not honored working from a manifest Maxim Cournoyer
2023-02-21 22:49 ` Ludovic Courtès [this message]
2023-02-22 1:20 ` Maxim Cournoyer
2023-02-22 9:23 ` Ludovic Courtès
2023-02-22 13:53 ` Simon Tournier
2023-02-22 18:36 ` Maxim Cournoyer
2023-03-01 15:53 ` Ludovic Courtès
2023-03-01 17:01 ` Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r0uid474.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=61676@debbugs.gnu.org \
--cc=maxim.cournoyer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).