From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id QKycK4RYJGUqigAAauVa8A:P1 (envelope-from ) for ; Mon, 09 Oct 2023 21:46:12 +0200 Received: from aspmx1.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id QKycK4RYJGUqigAAauVa8A (envelope-from ) for ; Mon, 09 Oct 2023 21:46:12 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 961125F76C for ; Mon, 9 Oct 2023 21:46:12 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=VcXxup2k; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1696880772; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-to: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=aijstTHI0QQQ07B/iH7syQJHw//90aJf+mKCqOkart8=; b=Nxo7n4bu2nRmU/ueIMQteMK4ea0TsL1PjFoJlEaNALT8vg5qm8JDaO23R9pgA/adKTm7nh hvHxZWj66dAOIymUvS/mqIPhm0/ot/rX27as0/lIrs976dqlmEJqhauibdqepdfxTK1/ar lcWiuq/iWlOqTx/nidFKzRv1qsmMDkC6VUvyXeU1inqWMsjFXVQlYTAKKCKVdqBPdL8FAW q5GYmD/ASHhW5hwCZMrJMaNEfq46M4xmKixROj9kkfp1ry9MMzv/5lC50nonuoryS6Dw1p JbDN5i1O2prBy5grJG0yEwSiA6csplh8mh2/P4grimCUuMqwITyexnx9LkBRhA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=VcXxup2k; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1696880772; a=rsa-sha256; cv=none; b=ul/DQruaEbrog00SgACKGWlOuUrVzmQZ+tngheKPNan/KNMeRhLYXLNESv+S3tgqKzm+lr ccFrFh7rZ+0YSpBktbbFlctpTPGv2YQdjZxuZeY5aBTxaRBZD9BrnUHBSe3jvk2tw8qvwa BAHHhhshcn76WnAn80tA7JGp7uXPVAYoA/23396CcieJu1kkoKqefBg+3Gw2euUuy+y5FB 6v5v+h9vz1D/LXvvJ5IHXX7dC1ejRLQZi3cxrJaRDaUahOoZeI6iRguVyJfXd1c6u0dM5H HrqhDKiMfkqKNJdtj/aWetEzcSdsBnyBpsY+z06FkE57ptFotGQYiW3zG7emIA== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qpwCM-0008NB-B7; Mon, 09 Oct 2023 15:45:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qpwCE-0008M6-Da for bug-guix@gnu.org; Mon, 09 Oct 2023 15:45:43 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qpwCD-0003fK-Kr for bug-guix@gnu.org; Mon, 09 Oct 2023 15:45:41 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qpwCY-0001Y8-4H for bug-guix@gnu.org; Mon, 09 Oct 2023 15:46:02 -0400 Subject: bug#65924: git searches coreutils and util-linux commands in PATH Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-To: bug-guix@gnu.org Resent-Date: Mon, 09 Oct 2023 19:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 65924 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Liliana Marie Prikler Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= , 65924-done@debbugs.gnu.org Mail-Followup-To: 65924@debbugs.gnu.org, maxim.cournoyer@gmail.com, maxim.cournoyer@gmail.com Received: via spool by 65924-done@debbugs.gnu.org id=D65924.16968807045851 (code D ref 65924); Mon, 09 Oct 2023 19:46:01 +0000 Received: (at 65924-done) by debbugs.gnu.org; 9 Oct 2023 19:45:04 +0000 Received: from localhost ([127.0.0.1]:33224 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qpwBc-0001WJ-21 for submit@debbugs.gnu.org; Mon, 09 Oct 2023 15:45:04 -0400 Received: from mail-qk1-x72c.google.com ([2607:f8b0:4864:20::72c]:51470) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qpwBX-0001VO-Fu for 65924-done@debbugs.gnu.org; Mon, 09 Oct 2023 15:45:02 -0400 Received: by mail-qk1-x72c.google.com with SMTP id af79cd13be357-77574c6cab0so354256885a.3 for <65924-done@debbugs.gnu.org>; Mon, 09 Oct 2023 12:44:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696880673; x=1697485473; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=aijstTHI0QQQ07B/iH7syQJHw//90aJf+mKCqOkart8=; b=VcXxup2kjU5xWw5K4MtpnvJjYLBA8c7TiCTEF5/fF7zX8uP0GzEqVQK2YKkG1128QA 3GMoaNpdlRvqurV8juzPNSjxWGfE+zfrxuxOz1MABA1WtS9FZdSqN++7I8eFbAuPZaND CPdIEy6L24mr7NG1oRJOMGxxb6layRuREJ79Z7gWoFPxPR9oKOWKpwpeEdXKSpEQ5meR /zifsZt5CDIPRASsQMdEzSXXSP8UuVh6TaEeGdIdVWr0h5qikuup5yR+dBGHOWV9wBB6 jhLOKT4LSt9ZoX9rE5+hvZlvthAz2mjzFtWwEIQCZgGVhYscTw8SXWgIlFdDozGIjAXo suCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696880673; x=1697485473; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=aijstTHI0QQQ07B/iH7syQJHw//90aJf+mKCqOkart8=; b=ZNAbAa1OcXohkQP4yAtS+r3Aqa1sYD3E9dCzGsxsqqZDb226wEnQ4U58M7zX5Nb77j ZfdNT24LK+n4UuhUP8MFhdfj8vPLgvMF/ubpNmEKVwVFuD3JybD2gHFjsXy+V0qPrKIM K5nugjoTiSmhzTyRo6L8TpRAlLclo5552r4c86+r1T1hMCSfq3cWIftt88N3K2+1q9Sy SQakJtQnwIA4K4GNEVgoj/lkHUN/OI2erz3KgKo9jMZyDro6oFZe2vfIBob0ei29qzca yuGEQXSCD2PaknafD5r75AfGCJGgn+1Nwj8qVW9zlKpFHx3r4iY3PX0Ewpq9ftUvZcwF 1p3A== X-Gm-Message-State: AOJu0Yymcrk3cAUa5f6iC4n0JrrqNmOQsd4apsfEY9yPcmnffNM8B1cM U3JnzsNkvavHx9JHEqxYFLQ= X-Google-Smtp-Source: AGHT+IHpsFOT2IrSul3u83GEx1OnMHt6jDVYa+fuB3bE4s86aVF7AClGdrn1h5jtIK5HvdVgffXJaw== X-Received: by 2002:a05:620a:24cf:b0:775:a3fc:a9d1 with SMTP id m15-20020a05620a24cf00b00775a3fca9d1mr21617401qkn.23.1696880672956; Mon, 09 Oct 2023 12:44:32 -0700 (PDT) Received: from hurd (dsl-10-149-16.b2b2c.ca. [72.10.149.16]) by smtp.gmail.com with ESMTPSA id pi2-20020a05620a378200b007677347e20asm3722255qkn.129.2023.10.09.12.44.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Oct 2023 12:44:32 -0700 (PDT) From: Maxim Cournoyer In-Reply-To: <6ab66bf2dda6a5a0c8db6192a367452c2782e1ee.camel@gmail.com> (Liliana Marie Prikler's message of "Mon, 09 Oct 2023 21:28:24 +0200") References: <9f9ecf37a04d6a3d788d247d8fb46f7bd6fabad5.1696734901.git.maxim.cournoyer@gmail.com> <442bb34f6ba81b7134c6cbf06d0045debc42bf68.camel@gmail.com> <87il7fdggi.fsf_-_@gmail.com> <1a219a891192b526d3e28fea8ce350c0fd5e3b53.camel@gmail.com> <87pm1nac8d.fsf@gmail.com> <8734yja98e.fsf@gmail.com> <6ab66bf2dda6a5a0c8db6192a367452c2782e1ee.camel@gmail.com> Date: Mon, 09 Oct 2023 15:44:31 -0400 Message-ID: <87r0m38tsw.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: 2.84 X-Spam-Score: 2.84 X-Migadu-Queue-Id: 961125F76C X-Migadu-Scanner: mx2.migadu.com X-TUID: 5Gzy0bESdQ8t Hello, Liliana Marie Prikler writes: > Am Montag, dem 09.10.2023 um 15:25 -0400 schrieb Maxim Cournoyer: >> Hi Liliana, >>=20 >> Liliana Marie Prikler writes: >>=20 >> > Am Montag, dem 09.10.2023 um 14:21 -0400 schrieb Maxim Cournoyer: >> > > Hello, >> > >=20 >> > > Liliana Marie Prikler writes: >> > >=20 >> > > > [...] >> > > > If you need me to reduce it to four letters, yes, LGTM. >> > >=20 >> > > Explicit is better than implicit.=C2=A0 I've been thinking to docume= nt >> > > this in our contributing section; e.g. a reviewed commit must >> > > have the 'LGTM' from the reviewer.=C2=A0 If a series is LGTM, it nee= ds >> > > to be implicitly mentioned with 'this series LGTM'.=C2=A0 That may >> > > sound silly, but I think it'd simplify reviewer/submitters >> > > interactions. >> > s/implicitly/explicitly/? >>=20 >> Explicit, indeed. >>=20 >> > I don't necessarily agree, but it's not a hard disagree either.=C2=A0 >> > I'll try to keep that in mind at least when reviewing your patches >> > to not cause confusion. >>=20 >> OK.=C2=A0 One place where this becomes more important is when the send- >> email cc hook includes people partially to a series. A LGTM on a >> single message in this case could be misinterpreted for the whole >> series.=C2=A0 It's best to document the expectations and codify these >> often used signals, in my opinion. > I personally prefer to comment to all individual patches or use the > series starter for "this series LGTM", but to recap; 1 and 2 L'd GTM > (with a small caveat for 1) already and we discussed 3 in IRC, so LGTM > for the series. That's a good idea. Thanks for the heads-up! I've now installed this series to core-updates. Closing! --=20 Thanks, Maxim