* bug#70926: Having default nss-certs plus nss-certs in operating-system packages causes problems
@ 2024-05-13 21:38 Christopher Baines
2024-05-14 5:44 ` Liliana Marie Prikler
0 siblings, 1 reply; 4+ messages in thread
From: Christopher Baines @ 2024-05-13 21:38 UTC (permalink / raw)
To: 70926
[-- Attachment #1: Type: text/plain, Size: 467 bytes --]
I've seen this when updating systems, but it seems like something is
wrong with the handling of nss-certs.
I'm on a guix revision with nss-certs by default, and when I add
nss-certs to my system packages (to simulate not removing it when
upgrading), it breaks certificates (e.g. wget https://guix.gnu.org/
doesn't work).
My reading of the operating-system-packages code suggests that adding
nss-certs shouldn't have any effect, but this doesn't seem to be
working.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#70926: Having default nss-certs plus nss-certs in operating-system packages causes problems
2024-05-13 21:38 bug#70926: Having default nss-certs plus nss-certs in operating-system packages causes problems Christopher Baines
@ 2024-05-14 5:44 ` Liliana Marie Prikler
2024-05-16 3:02 ` Maxim Cournoyer
0 siblings, 1 reply; 4+ messages in thread
From: Liliana Marie Prikler @ 2024-05-14 5:44 UTC (permalink / raw)
To: Christopher Baines, 70926
Am Montag, dem 13.05.2024 um 22:38 +0100 schrieb Christopher Baines:
> I've seen this when updating systems, but it seems like something is
> wrong with the handling of nss-certs.
>
> I'm on a guix revision with nss-certs by default, and when I add
> nss-certs to my system packages (to simulate not removing it when
> upgrading), it breaks certificates (e.g. wget https://guix.gnu.org/
> doesn't work).
I can confirm this on three machines (two of my own, one from a
relative): Having nss-certs in the packages field unexpectedly breaks
all known certificates.
> My reading of the operating-system-packages code suggests that adding
> nss-certs shouldn't have any effect, but this doesn't seem to be
> working.
It would be really nice to detect the mismatching versions if it's
based on that. IIUC we graft nss-certs now, so that we can hot-swap
stuff like pythons certifi package. Is this use case broken by any
chance?
Cheers
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#70926: Having default nss-certs plus nss-certs in operating-system packages causes problems
2024-05-14 5:44 ` Liliana Marie Prikler
@ 2024-05-16 3:02 ` Maxim Cournoyer
2024-05-20 9:39 ` Christopher Baines
0 siblings, 1 reply; 4+ messages in thread
From: Maxim Cournoyer @ 2024-05-16 3:02 UTC (permalink / raw)
To: Liliana Marie Prikler; +Cc: 70926-done, Christopher Baines
Hello,
Liliana Marie Prikler <liliana.prikler@gmail.com> writes:
> Am Montag, dem 13.05.2024 um 22:38 +0100 schrieb Christopher Baines:
>> I've seen this when updating systems, but it seems like something is
>> wrong with the handling of nss-certs.
>>
>> I'm on a guix revision with nss-certs by default, and when I add
>> nss-certs to my system packages (to simulate not removing it when
>> upgrading), it breaks certificates (e.g. wget https://guix.gnu.org/
>> doesn't work).
> I can confirm this on three machines (two of my own, one from a
> relative): Having nss-certs in the packages field unexpectedly breaks
> all known certificates.
>
>> My reading of the operating-system-packages code suggests that adding
>> nss-certs shouldn't have any effect, but this doesn't seem to be
>> working.
> It would be really nice to detect the mismatching versions if it's
> based on that. IIUC we graft nss-certs now, so that we can hot-swap
> stuff like pythons certifi package. Is this use case broken by any
> chance?
Apparently having multiple nss-certs of the same version is no problem
(they get deduped later). The original problem would thus only exist
when there are multiple versions of nss-certs listed in packages, as
could happen for installer-generated configs that use
'(specification->package "nss-certs"), which would pick the latest
version and clash with the one in %base-packages.
My code could call delete even in the first case, which would clear
*all* nss-certs because they were the same object. That's now guarded
against in 35ae95061e1b843e1df069693177519f22f9a16d ("system: Do not
delete all nss-certs packages when they are the same object."), which
I've just pushed.
Closing.
--
Thanks,
Maxim
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#70926: Having default nss-certs plus nss-certs in operating-system packages causes problems
2024-05-16 3:02 ` Maxim Cournoyer
@ 2024-05-20 9:39 ` Christopher Baines
0 siblings, 0 replies; 4+ messages in thread
From: Christopher Baines @ 2024-05-20 9:39 UTC (permalink / raw)
To: Maxim Cournoyer; +Cc: 70926-done, Liliana Marie Prikler
[-- Attachment #1: Type: text/plain, Size: 1888 bytes --]
Maxim Cournoyer <maxim.cournoyer@gmail.com> writes:
> Hello,
>
> Liliana Marie Prikler <liliana.prikler@gmail.com> writes:
>
>> Am Montag, dem 13.05.2024 um 22:38 +0100 schrieb Christopher Baines:
>>> I've seen this when updating systems, but it seems like something is
>>> wrong with the handling of nss-certs.
>>>
>>> I'm on a guix revision with nss-certs by default, and when I add
>>> nss-certs to my system packages (to simulate not removing it when
>>> upgrading), it breaks certificates (e.g. wget https://guix.gnu.org/
>>> doesn't work).
>> I can confirm this on three machines (two of my own, one from a
>> relative): Having nss-certs in the packages field unexpectedly breaks
>> all known certificates.
>>
>>> My reading of the operating-system-packages code suggests that adding
>>> nss-certs shouldn't have any effect, but this doesn't seem to be
>>> working.
>> It would be really nice to detect the mismatching versions if it's
>> based on that. IIUC we graft nss-certs now, so that we can hot-swap
>> stuff like pythons certifi package. Is this use case broken by any
>> chance?
>
> Apparently having multiple nss-certs of the same version is no problem
> (they get deduped later). The original problem would thus only exist
> when there are multiple versions of nss-certs listed in packages, as
> could happen for installer-generated configs that use
> '(specification->package "nss-certs"), which would pick the latest
> version and clash with the one in %base-packages.
>
> My code could call delete even in the first case, which would clear
> *all* nss-certs because they were the same object. That's now guarded
> against in 35ae95061e1b843e1df069693177519f22f9a16d ("system: Do not
> delete all nss-certs packages when they are the same object."), which
> I've just pushed.
Great, thanks for fixing this Maxim!
Chris
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-05-20 9:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-13 21:38 bug#70926: Having default nss-certs plus nss-certs in operating-system packages causes problems Christopher Baines
2024-05-14 5:44 ` Liliana Marie Prikler
2024-05-16 3:02 ` Maxim Cournoyer
2024-05-20 9:39 ` Christopher Baines
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).