bug#72625: emacs-magit: autoload issue

bug#72625: emacs-magit: autoload issue

[Christopher Howard]

Recipe:

1. Make sure emacs-magit is already install.
2. In Emacs, go to an info manual (e.g., C-h r)
3. Position point on a menu link and press <ENTER>

This attempts to trigger some magit advice, but that fails with this error:

```
Debugger entered--Lisp error: (error "Autoloading file /gnu/store/fllbaw3s1i7b7f970pz3inmflgc5kb0w-emacs-magit-3.3.0-8.538cb2f/share/emacs/site-lisp/magit-3.3.0-8.538cb2f/magit-base.elc failed to define function Info-follow-nearest-node--magit-gitman")
  Info-follow-nearest-node--magit-gitman(#f(advice Info-follow-nearest-node@gitman :around #<subr Info-follow-nearest-node>) nil)
  apply(Info-follow-nearest-node--magit-gitman #f(advice Info-follow-nearest-node@gitman :around #<subr Info-follow-nearest-node>) nil)
  Info-follow-nearest-node(nil)
  funcall-interactively(Info-follow-nearest-node nil)
  command-execute(Info-follow-nearest-node)
```

Maybe magit-base.elc is compiled wrong somehow...?

I see magit 4.0 was just released, so if somebody wants to update the package, maybe the problem would go away.

Here is my system information:

```
christopher@theoden 
------------------- 
OS: Guix System x86_64 
Host: OptiPlex 9020 00 
Kernel: 5.15.161-gnu 
Uptime: 41 days, 21 hours, 44 mins 
Packages: 167 (guix-system), 251 (guix-user) 
Shell: bash 5.1.16 
Resolution: 1920x1080 
DE: GNOME 
Theme: Adwaita [GTK2/3] 
Icons: Adwaita [GTK2/3] 
Terminal: shepherd 
CPU: Intel i5-4570 (4) @ 3.600GHz 
GPU: AMD ATI Radeon HD 8490 / R5 235X OEM 
GPU: Intel HD Graphics 
Memory: 3867MiB / 15914MiB 
```

``` guix describe
Generation 140	Aug 14 2024 10:02:53	(current)
  guix ca5ff8a
    repository URL: https://git.savannah.gnu.org/git/guix.git
    branch: master
    commit: ca5ff8aa8b50ac317003d76cc4ea2a621d5a3819
```

GNU Emacs 29.4 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.41, cairo version 1.18.0)

Magit 3.3.0-8.538cb2f, Transient 0.7.4, Git 2.45.2, Emacs 29.4, gnu/linux

-- 
📛 Christopher Howard
🚀 gemini://gem.librehacker.com
🌐 http://gem.librehacker.com

בראשית ברא אלהים את השמים ואת הארץ

bug#72625: emacs-magit: autoload issue

[Nicolas Goaziou via Bug reports for GNU Guix]

Hello,

Christopher Howard <christopher@librehacker.com> writes:

> Recipe:
>
> 1. Make sure emacs-magit is already install.
> 2. In Emacs, go to an info manual (e.g., C-h r)
> 3. Position point on a menu link and press <ENTER>
>
> This attempts to trigger some magit advice, but that fails with this error:
>
> ```
> Debugger entered--Lisp error: (error "Autoloading file /gnu/store/fllbaw3s1i7b7f970pz3inmflgc5kb0w-emacs-magit-3.3.0-8.538cb2f/share/emacs/site-lisp/magit-3.3.0-8.538cb2f/magit-base.elc failed to define function Info-follow-nearest-node--magit-gitman")
>   Info-follow-nearest-node--magit-gitman(#f(advice Info-follow-nearest-node@gitman :around #<subr Info-follow-nearest-node>) nil)
>   apply(Info-follow-nearest-node--magit-gitman #f(advice Info-follow-nearest-node@gitman :around #<subr Info-follow-nearest-node>) nil)
>   Info-follow-nearest-node(nil)
>   funcall-interactively(Info-follow-nearest-node nil)
>   command-execute(Info-follow-nearest-node)
> ```
>
> Maybe magit-base.elc is compiled wrong somehow...?
>
> I see magit 4.0 was just released, so if somebody wants to update the
> package, maybe the problem would go away.

Magit was updated to 4.0 a few hours ago. I cannot reproduce it (but
I didn't try before the update). Did this change anything on your side?

Regards,
-- 
Nicolas Goaziou

bug#72625: emacs-magit: autoload issue

[Christopher Howard]

Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:

>> I see magit 4.0 was just released, so if somebody wants to update the
>> package, maybe the problem would go away.
>
> Magit was updated to 4.0 a few hours ago. I cannot reproduce it (but
> I didn't try before the update). Did this change anything on your side?
>

Hi, I confirmed I am now running 4.0.0 (using magit-version), but I am still seeing this exact same issue.

I am at the moment running pre-test version of Emacs, GNU Emacs 30.0.91 (build 2, x86_64-pc-linux-gnu, GTK+ Version 3.24.41, cairo version 1.18.0) of 2024-09-11. But I will test this again with Emacs 29.4 from the guix package, just to be thorough.

-- 
Christopher Howard

bug#72625: emacs-magit: autoload issue

[Christopher Howard]

I see this error also when running Emacs 29.4 from the guix package. I used "emacs -q" for the test so it is not an init.el file issue.

-- 
Christopher Howard

bug#72625: Status: emacs-magit: autoload issue

[Christopher Howard]

A non-guix user on #emacs tested this for me and is not able to reproduce the problem on his distro. Said he was running Emacs 31.0.50 and Magit 4.0.0. He also tried 4.1.0. So it is seeming like a guix-specific issue.

-- 
Christopher Howard

bug#72625: emacs-magit: autoload issue

[Christopher Howard]

Hi, after I updated my Emacs this morning to d656be9794d (emacs-30 branch) I am now not seeing this problem. I see in 5eaf0c784bf that there was a small, seemingly unrelated change to to info-look.el, but that is the only thing that jumps out at me. So, I'm not sure how the problem was resolved, but hopefully it is gone for good.

I also vaguely recall doing a home reconfigure a day or two ago, so perhaps that played into it somehow.

-- 
Christopher Howard