Add GNU fdisk

Add GNU fdisk

[Jason Self]

[-- Attachment #1: Type: text/plain, Size: 38 bytes --]

I hope that I've done this correctly.

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: fdisk.patch --]
[-- Type: text/x-patch; name="fdisk.patch", Size: 2263 bytes --]

diff --git a/Makefile.am b/Makefile.am
index b57e7db..d5a4111 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -51,6 +51,7 @@ MODULES =					\
   distro/packages/cpio.scm			\
   distro/packages/ddrescue.scm			\
   distro/packages/ed.scm			\
+  distro/packages/fdisk.scm                     \
   distro/packages/flex.scm			\
   distro/packages/gawk.scm			\
   distro/packages/gdbm.scm			\
diff --git a/distro/packages/fdisk.scm b/distro/packages/fdisk.scm
new file mode 100644
index 0000000..0d9aebf
--- /dev/null
+++ b/distro/packages/fdisk.scm
@@ -0,0 +1,44 @@
+;;; Guix --- Nix package management from Guile.         -*- coding: utf-8 -*-
+;;;
+;;; This file is part of Guix.
+;;;
+;;; Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with Guix.  If not, see <http://www.gnu.org/licenses/>.
+
+(define-module (distro packages fdisk)
+  #:use-module (guix packages)
+  #:use-module (guix download)
+  #:use-module (guix build-system gnu))
+
+(define-public fdisk
+  (package
+    (name "fdisk")
+    (version "2.0.0a1")
+    (source
+     (origin
+      (method url-fetch)
+      (uri (string-append
+            "mirror://gnu/fdisk/fdisk-"
+            version
+            ".tar.gz"))
+      (sha256
+       (base32
+        "MM4TMM3EHA2GIZTGGEYWGNBRGIYTAZTGMY4TSNBXGQZGKOLGHEYGCNZSMRTGIY3CGA2DQMLCMNRTIYRVGMYDEMRTMVSDGNJRGFTGENI="))))
+    (build-system gnu-build-system)
+    (arguments '(#:configure-flags '("CC=gcc")))
+    (home-page "http://www.gnu.org/software/fdisk/")
+    (synopsis
+     "GNU fdisk is a libparted-based partitioning tool.")
+    (description
+     "GNU fdisk GNU fdisk provides libparted-based alternatives to classic partitioning tools like util-linux, fdisk and cfdisk. ")
+    (license "GPLv3+")))

Re: Add GNU fdisk

[Ludovic Courtès]

Hi Jason,

Thanks for the patch!

I believe there are two issues here:

> +      (sha256
> +       (base32
> +        "MM4TMM3EHA2GIZTGGEYWGNBRGIYTAZTGMY4TSNBXGQZGKOLGHEYGCNZSMRTGIY3CGA2DQMLCMNRTIYRVGMYDEMRTMVSDGNJRGFTGENI="))))

This is not a valid nix-base32 string.  It should be shorter, like
1g2zvl560f7p1hd4q50d1msy6qp7949mdkagfy8ki8cayp8fp267.

The ‘guix-download’ tool should give you the right thing.

> +    (synopsis
> +     "GNU fdisk is a libparted-based partitioning tool.")

Since it depends on Parted, there should be an ‘inputs’ field like:

  (inputs `((parted ,parted)))

However, Parted is not packaged yet, so that’d be the place to start.  I
think Nikita was looking into it, maybe?

BTW, the manual briefly mentions ‘guix-import’; it’s really very helpful
as a starting point for simple packages.

HTH,
Ludo’.

Re: Add GNU fdisk

[Nikita Karetnikov]

Hi,

Jason, could you also fix the following?

1. Split the description into several lines. (I usually use Emacs'
'ESC q' for this purpose.)

2. Fix the typo in the description (i.e. "GNU fdisk GNU fdisk").

3. Remove the trailing space from the description.

4. Change the formatting according to this [1] example.

5. Remove the dot from the synopsis.

6. Add a copyright notice.

I have some doubts regarding this line:

(arguments '(#:configure-flags '("CC=gcc")))

Ludo, is it needed?

Ludo is right. 'parted' is the next thing I'm going to package. It may
take a little bit longer than usually because 'parted' has its own
deps which are not available in Guix.

Nikita

[1] https://lists.gnu.org/archive/html/bug-guix/2012-11/msg00032.html

Re: Add GNU fdisk

[Ludovic Courtès]

Hi!

Nikita Karetnikov <nikita.karetnikov@gmail.com> skribis:

> I have some doubts regarding this line:
>
> (arguments '(#:configure-flags '("CC=gcc")))
>
> Ludo, is it needed?

It depends on the package, but packages that use Autoconf normally don’t
need it.

> Ludo is right. 'parted' is the next thing I'm going to package. It may
> take a little bit longer than usually because 'parted' has its own
> deps which are not available in Guix.

Great.  That will unlock quite a number of packages, I guess.

Thanks,
Ludo’.

Re: Add GNU fdisk

[Jason Self]

[-- Attachment #1: Type: text/plain, Size: 385 bytes --]

Nikita Karetnikov said:
> Add a copyright notice.

I left it out because as a series of facts (package name, version,
URL, hash, dependencies, etc.) I'm not sure that these files are even
copyrightable to begin with.

"When there is only one way to express an idea or function, then
everyone is free to do so and no one can monopolize that expression."
(The judge in Oracle v. Google)

Re: Add GNU fdisk

[Ludovic Courtès]

"Jason Self" <jason@bluehome.net> skribis:

> I left it out because as a series of facts (package name, version,
> URL, hash, dependencies, etc.) I'm not sure that these files are even
> copyrightable to begin with.

Yes, I’ve been wondering too.  The thing is, while most are purely
declarative like this, some, like those in base.scm, are trickier and
definitely copyrightable.  In base.scm, the composition of packages in
the bootstrap phase may also be copyrightable in itself.

Thanks,
Ludo’.

Re: Add GNU fdisk

[Nikita Karetnikov]

Hi,

So, what's the policy on copyright statements?

I'm not a lawyer that's why I think that it's better to be safe than
sorry (i.e. to use a copyright statement).

Nikita

Re: Add GNU fdisk

[Jason Self]

[-- Attachment #1: Type: text/plain, Size: 481 bytes --]

Ludovic Courtès said:
> Yes, I’ve been wondering too.  The thing is, while most are purely
> declarative like this, some, like those in base.scm, are trickier
> and definitely copyrightable.  In base.scm, the composition of
> packages in the bootstrap phase may also be copyrightable in itself.

I suppose that there's no harm in adding one, then. Even if it should
turn out that it's not copyrightable an invalid copyright notice
wouldn't cause any harm in this case.

Re: Add GNU fdisk

[Ludovic Courtès]

Hi,

"Jason Self" <jason@bluehome.net> skribis:

> Ludovic Courtès said: 
>> Yes, I’ve been wondering too.  The thing is, while most are purely
>> declarative like this, some, like those in base.scm, are trickier 
>> and definitely copyrightable.  In base.scm, the composition of 
>> packages in the bootstrap phase may also be copyrightable in itself.
>
> I suppose that there's no harm in adding one, then. Even if it should 
> turn out that it's not copyrightable an invalid copyright notice 
> wouldn't cause any harm in this case.

Yes.

Nikita Karetnikov <nikita.karetnikov@gmail.com> skribis:

> So, what's the policy on copyright statements?
>
> I'm not a lawyer that's why I think that it's better to be safe than
> sorry (i.e. to use a copyright statement).

Agreed.  So the policy is unchanged: each file must contain a copyright
statement.

Thanks,
Ludo’.