From: ludo@gnu.org (Ludovic Courtès)
To: Mark H Weaver <mhw@netris.org>
Cc: bug-guix@gnu.org
Subject: Re: [PATCH] Inhibit duplicates in fold-packages
Date: Wed, 13 Feb 2013 22:35:37 +0100 [thread overview]
Message-ID: <87pq03kic6.fsf@gnu.org> (raw)
In-Reply-To: <87d2w5q8wk.fsf@tines.lan> (Mark H. Weaver's message of "Tue, 12 Feb 2013 20:50:35 -0500")
Mark H Weaver <mhw@netris.org> skribis:
> Here's a patch to inhibit the same package (in the sense of eq?) from
> being traversed more than once by fold-packages. One example where this
> helps is the guile-2.0 package in (gnu packages guile), which is
> exported in two different variables: guile-2.0 and guile-2.0/fixed.
Looks good to me; can you update the docstring to mention that each
package is traversed only once? Then feel free to push.
BTW, I think ‘guile-2.0/fixed’ is the only case where this happens
actually, no?
BTW2, when doing non-trivial changes like this one, make sure to add a
copyright line under your name.
Thanks!
Ludo’.
prev parent reply other threads:[~2013-02-13 21:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-13 1:50 [PATCH] Inhibit duplicates in fold-packages Mark H Weaver
2013-02-13 11:06 ` Mark H Weaver
2013-02-13 21:35 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pq03kic6.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=bug-guix@gnu.org \
--cc=mhw@netris.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).