From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
Subject: bug#29537: Core updates broken
Date: Mon, 04 Dec 2017 10:28:36 +0100
Message-ID: <87po7uq1tn.fsf@gnu.org>
References: <CAE4v=phkRUpa5NnZ12Tp0nCBkwXieYN4oXW+FT8rA=q0bOL+kw@mail.gmail.com>
	<87vahnzyq9.fsf@fastmail.com> <87bmjf4r0k.fsf@elephly.net>
	<87fu8rzm83.fsf@fastmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37215)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eLn4f-00005u-AN
	for bug-guix@gnu.org; Mon, 04 Dec 2017 04:30:06 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eLn4c-00007M-6s
	for bug-guix@gnu.org; Mon, 04 Dec 2017 04:30:05 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:35614)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1eLn4c-00007I-41
	for bug-guix@gnu.org; Mon, 04 Dec 2017 04:30:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eLn4b-0007uT-TH
	for bug-guix@gnu.org; Mon, 04 Dec 2017 04:30:01 -0500
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.29537.B29537.151237976730327@debbugs.gnu.org>
In-Reply-To: <87fu8rzm83.fsf@fastmail.com> (Marius Bakke's message of "Sun, 03
	Dec 2017 19:43:08 +0100")
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix/>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: "bug-Guix" <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
To: Marius Bakke <mbakke@fastmail.com>
Cc: 29537@debbugs.gnu.org

Hello!

Marius Bakke <mbakke@fastmail.com> skribis:

> Ricardo Wurmus <rekado@elephly.net> writes:
>
>> Marius Bakke <mbakke@fastmail.com> writes:
>>
>>> G=C3=A1bor Boskovits <boskovits@gmail.com> writes:
>>>
>>>> It seems, that we have a breakage in current core-updates. m4, gettext=
, and
>>>> at least a few other packages fail to build.
>>>
>>> Hello!
>>>
>>> The problem is that the glibc version string is used a couple of places
>>> to determine where locales are found.
>>>
>>> The attached patch fixes it, though I'm not sure if it's the best
>>> approach.  Thoughts?
>>
>> Thank you.
>>
>> I find it a little ugly to replace the exact version string with only
>> the major+minor version substring.  Why can=E2=80=99t we use the full ve=
rsion
>> string?
>
> I think it's because "glibc-versioned-locpath.patch" uses the libc
> VERSION constant.

Right.  That=E2=80=99s akin to the =E2=80=9Ceffective version=E2=80=9D stri=
ng as defined in
Guile and other packages for cases where you only care about
MAJOR.MINOR.

> Perhaps we could substitute glibcs "version.h", but that might break
> other things.  Or introduce a different variable, say
> GUIX_GLIBC_VERSION, and use that.  WDYT?

FWIW I think your patches does the right thing.  If we want to reduce
ugliness, we can always add an =E2=80=98effective-glibc-version=E2=80=99 pr=
operty in the
glibc package, but that probably won=E2=80=99t be much less ugly than calli=
ng
=E2=80=98version-major+minor=E2=80=99.

Thoughts?

Ludo=E2=80=99.