unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Pierre Neidhardt <mail@ambrevar.xyz>
To: 30265@debbugs.gnu.org
Cc: meiyo.peng@gmail.com
Subject: bug#30265: Fish shell has wrong path variables
Date: Wed, 19 Sep 2018 11:09:50 +0200	[thread overview]
Message-ID: <87pnx9yhsx.fsf@ambrevar.xyz> (raw)
In-Reply-To: <87inbnpsx9.fsf@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1541 bytes --]

I haven't investigated too deep into this, but I've figured out a few
things.

First of all, to reproduce the issue:

- Install fish.

- Run `guix build --check fish`, it should output something like

  #+BEGIN_SRC sh
  > guix build --check fish
  Building /gnu/store/g9ra27952ay2a7j3mn7yp13b7m18kl1b-fish-2.7.1.drv - x86_64-linux
  grafting '/gnu/store/vgrav12zra9zky21ahm4x1qg8g4v58fj-fish-2.7.1' -> '/gnu/store/avk637800w1n7z1z0hnzx80r0fpd6729-fish-2.7.1'...
  /gnu/store/avk637800w1n7z1z0hnzx80r0fpd6729-fish-2.7.1
  #+END_SRC

- The graft source is a dead GC item:
	#+BEGIN_SRC sh
	> guix gc --list-dead | grep vgrav12zra9zky21ahm4x1qg8g4v58fj
	/gnu/store/vgrav12zra9zky21ahm4x1qg8g4v58fj-fish-2.7.1
	#+END_SRC

  Collect it:
	#+BEGIN_SRC sh
  guix gc --delete /gnu/store/vgrav12zra9zky21ahm4x1qg8g4v58fj-fish-2.7.1
	#+END_SRC

- Start fish:
  #+BEGIN_SRC sh
  > fish
  fish:
  echo $_ " "; __fish_pwd
                 ^
  in command substitution
          called on standard input
  ...
  #+END_SRC

I think Ricardo got a hunch of what's happening, except that it's not
about cache files in the user home's directory.  Instead, Fish seems to
record the path to the graft source.  A grep in the fish folder does not
seem to reveal anything, nor does `strings
/gnu/store/...-fish.../bin/fish`.

Could this be a grafting issue?  Like what was recently mentioned about
Racket?

Otherwise, as Meiyo pointed out, the solution might lie in patching
fish.cpp if grafting is not responsible for this.

--
Pierre Neidhardt
https://ambrevar.xyz/

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

  parent reply	other threads:[~2018-09-19  9:10 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-27  9:11 bug#30265: Fish shell has wrong path variables Meiyo Peng
2018-01-27 10:36 ` ng0
2018-01-27 16:25   ` Ludovic Courtès
2018-01-27 18:19     ` ng0
2018-01-27 12:19 ` Ricardo Wurmus
2018-01-27 13:45   ` Meiyo Peng
2018-01-27 14:13 ` Meiyo Peng
2018-09-19  9:09 ` Pierre Neidhardt [this message]
2018-09-19 20:39   ` Ludovic Courtès
2018-09-20 16:09     ` Pierre Neidhardt
2018-09-20 17:00       ` Ricardo Wurmus
2018-09-20 17:12         ` Pierre Neidhardt
2018-09-21 12:03           ` Ludovic Courtès
2018-09-21 12:05       ` Ludovic Courtès
2018-09-21 14:42         ` Pierre Neidhardt
2018-09-21 14:46           ` Ricardo Wurmus
2018-09-21 15:11             ` Pierre Neidhardt
2019-02-02  7:20 ` bug#30265: Fish embeds store file names in UCS-4/UTF-32 literal strings Meiyo Peng
2019-02-04 22:16   ` Ludovic Courtès
2020-03-30  6:29 ` John Soo
2022-10-07 19:42   ` Maxim Cournoyer
2022-10-07 19:43   ` Maxim Cournoyer
2022-10-07 19:44     ` John Soo
2022-10-07 20:57       ` Mark H Weaver
2022-10-10  3:38         ` Maxim Cournoyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pnx9yhsx.fsf@ambrevar.xyz \
    --to=mail@ambrevar.xyz \
    --cc=30265@debbugs.gnu.org \
    --cc=meiyo.peng@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).