* bug#39712: Partitions produced by the installer not properly unmounted?
@ 2020-02-21 11:13 Ludovic Courtès
2020-02-21 15:27 ` Mathieu Othacehe
0 siblings, 1 reply; 6+ messages in thread
From: Ludovic Courtès @ 2020-02-21 11:13 UTC (permalink / raw)
To: 39712
Hi Mathieu,
I noticed that partitions created by the installer appear to not be
properly unmounted, at least when running in the context of (gnu tests
install):
--8<---------------cut here---------------start------------->8---
ludo@ribbon ~$ qemu-img convert -O raw /gnu/store/2d3s2nbb3j2c1hmkz52xds9rfbk4q3x3-installation /tmp/broken.raw
ludo@ribbon ~$ sudo losetup -P /dev/loop0 /tmp/broken.raw
ludo@ribbon ~$ sudo dmesg |tail -3
[10703.869334] kvm [8936]: vcpu0, guest rIP: 0xffffffffac073dad disabled perfctr wrmsr: 0xc2 data 0xffff
[10742.475623] kvm [8957]: vcpu0, guest rIP: 0xffffffffaf073dad disabled perfctr wrmsr: 0xc2 data 0xffff
[11774.318468] loop0: p1 p2 p3
ludo@ribbon ~$ sudo fdisk -l /dev/loop0
Disk /dev/loop0: 2.15 GiB, 2306867200 bytes, 4505600 sectors
Units: sectors of 1 * 512 = 512 bytes
Sector size (logical/physical): 512 bytes / 512 bytes
I/O size (minimum/optimal): 512 bytes / 512 bytes
Disklabel type: gpt
Disk identifier: 213AE251-0E91-499E-9184-0CCEC6DA64C7
Dispositiu Start Final Sectors Size Tipus
/dev/loop0p1 2048 6143 4096 2M BIOS boot
/dev/loop0p2 6144 231423 225280 110M Intercanvi Linux
/dev/loop0p3 231424 4503551 4272128 2G Linux filesystem
ludo@ribbon ~$ sudo mount /dev/loop0p3 /mnt/usb
ludo@ribbon ~$ sudo dmesg |tail -3
[11774.318468] loop0: p1 p2 p3
[11803.975300] EXT4-fs (loop0p3): recovery complete
[11803.977277] EXT4-fs (loop0p3): mounted filesystem with ordered data mode. Opts: (null)
--8<---------------cut here---------------end--------------->8---
However, I’ve added logging in ‘umount-user-partitions’ in (gnu
installer parted), and the installer does seem to unmount partitions
correctly.
Could it be a side effect of the MS_MOVE dance in
1d02052067e04d7dd8fd1ec17557ca02a30b9bcf?
(I’m observing this on ‘wip-installer-tests’, roughly based on
117d8467be232bcc1b0136d04f362d95d975ca95.)
Thanks,
Ludo’.
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#39712: Partitions produced by the installer not properly unmounted?
2020-02-21 11:13 bug#39712: Partitions produced by the installer not properly unmounted? Ludovic Courtès
@ 2020-02-21 15:27 ` Mathieu Othacehe
2020-02-21 20:43 ` Ludovic Courtès
0 siblings, 1 reply; 6+ messages in thread
From: Mathieu Othacehe @ 2020-02-21 15:27 UTC (permalink / raw)
To: 39712
Hey Ludo,
Nice progress on that branch :)
> Could it be a side effect of the MS_MOVE dance in
> 1d02052067e04d7dd8fd1ec17557ca02a30b9bcf?
Could be, I ran the following command on wip-installer-test branch:
--8<---------------cut here---------------start------------->8---
make check-system TESTS=gui-installed-os
--8<---------------cut here---------------end--------------->8---
But it appears to get stuck at this step:
--8<---------------cut here---------------start------------->8---
conversation expecting pattern ((quote pause))
--8<---------------cut here---------------end--------------->8---
I'll try to investigate further later on.
Thanks,
Mathieu
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#39712: Partitions produced by the installer not properly unmounted?
2020-02-21 15:27 ` Mathieu Othacehe
@ 2020-02-21 20:43 ` Ludovic Courtès
2020-02-22 10:24 ` Mathieu Othacehe
0 siblings, 1 reply; 6+ messages in thread
From: Ludovic Courtès @ 2020-02-21 20:43 UTC (permalink / raw)
To: Mathieu Othacehe; +Cc: 39712
Hi,
Mathieu Othacehe <m.othacehe@gmail.com> skribis:
>> Could it be a side effect of the MS_MOVE dance in
>> 1d02052067e04d7dd8fd1ec17557ca02a30b9bcf?
>
> Could be, I ran the following command on wip-installer-test branch:
>
> make check-system TESTS=gui-installed-os
>
>
> But it appears to get stuck at this step:
>
> conversation expecting pattern ((quote pause))
>
> I'll try to investigate further later on.
Don’t investigate on that branch yet though, I have quite a lot of
changes that I’ll push soon. :-)
But I think the problem should show up even with “make check-system
TESTS=installed-os” on master.
Thanks,
Ludo’.
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#39712: Partitions produced by the installer not properly unmounted?
2020-02-21 20:43 ` Ludovic Courtès
@ 2020-02-22 10:24 ` Mathieu Othacehe
2020-02-22 17:13 ` Ludovic Courtès
0 siblings, 1 reply; 6+ messages in thread
From: Mathieu Othacehe @ 2020-02-22 10:24 UTC (permalink / raw)
To: Ludovic Courtès; +Cc: 39712
Hey Ludo,
> But I think the problem should show up even with “make check-system
> TESTS=installed-os” on master.
Well this does not involve the graphical installer, so I'm not sure to
understand.
Anyway, testing the installer in Qemu, I can reproduce a failure where
the first umount in "umount-cow-store" throws an exception (busy
device), when umounting a crypted partition.
That's probably what's bitting you, so to be continued!
Thanks,
Mathieu
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#39712: Partitions produced by the installer not properly unmounted?
2020-02-22 10:24 ` Mathieu Othacehe
@ 2020-02-22 17:13 ` Ludovic Courtès
2020-03-13 15:52 ` Mathieu Othacehe
0 siblings, 1 reply; 6+ messages in thread
From: Ludovic Courtès @ 2020-02-22 17:13 UTC (permalink / raw)
To: Mathieu Othacehe; +Cc: 39712
Hi,
Mathieu Othacehe <m.othacehe@gmail.com> skribis:
>> But I think the problem should show up even with “make check-system
>> TESTS=installed-os” on master.
Hmm I’m not sure this is true.
> Well this does not involve the graphical installer, so I'm not sure to
> understand.
>
> Anyway, testing the installer in Qemu, I can reproduce a failure where
> the first umount in "umount-cow-store" throws an exception (busy
> device), when umounting a crypted partition.
On current ‘wip-installer-test’
(0699b97f7df8708a000eb7bfb043c2cef6672dc3), you can run:
make check-system TESTS=gui-installed-os
(It should succeed.)
If you take the /gnu/store/…-installation item produced and mount it as
I showed before in this thread, you should see a “recovery complete”
message from the kernel.
Note that LUKS is not involved at all in this case, and ‘umount’ doesn’t
throw.
Ludo’.
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#39712: Partitions produced by the installer not properly unmounted?
2020-02-22 17:13 ` Ludovic Courtès
@ 2020-03-13 15:52 ` Mathieu Othacehe
0 siblings, 0 replies; 6+ messages in thread
From: Mathieu Othacehe @ 2020-03-13 15:52 UTC (permalink / raw)
To: Ludovic Courtès; +Cc: 39712-done
This is fixed by 64704be417ab6f2788e8e3bc36fede1db35470e7.
Thanks,
Mathieu
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-03-13 15:53 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-21 11:13 bug#39712: Partitions produced by the installer not properly unmounted? Ludovic Courtès
2020-02-21 15:27 ` Mathieu Othacehe
2020-02-21 20:43 ` Ludovic Courtès
2020-02-22 10:24 ` Mathieu Othacehe
2020-02-22 17:13 ` Ludovic Courtès
2020-03-13 15:52 ` Mathieu Othacehe
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).