From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id eNTkGYvFVF9kPwAA0tVLHw (envelope-from ) for ; Sun, 06 Sep 2020 11:18:35 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id 0F6sFYvFVF8FOgAAbx9fmQ (envelope-from ) for ; Sun, 06 Sep 2020 11:18:35 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 878E294028F for ; Sun, 6 Sep 2020 11:18:34 +0000 (UTC) Received: from localhost ([::1]:39648 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kEsgr-0004Qz-1A for larch@yhetil.org; Sun, 06 Sep 2020 07:18:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45780) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kEsgM-0004Qm-UL for bug-guix@gnu.org; Sun, 06 Sep 2020 07:18:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:33353) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kEsgM-0006un-Is for bug-guix@gnu.org; Sun, 06 Sep 2020 07:18:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kEsgM-0006Zb-Cm for bug-guix@gnu.org; Sun, 06 Sep 2020 07:18:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#43228: r-v8 doesn't build since node 10.22 update Resent-From: Pierre Langlois Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sun, 06 Sep 2020 11:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43228 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Mark H Weaver Received: via spool by 43228-submit@debbugs.gnu.org id=B43228.159939102425199 (code B ref 43228); Sun, 06 Sep 2020 11:18:02 +0000 Received: (at 43228) by debbugs.gnu.org; 6 Sep 2020 11:17:04 +0000 Received: from localhost ([127.0.0.1]:44899 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEsfQ-0006YN-3J for submit@debbugs.gnu.org; Sun, 06 Sep 2020 07:17:04 -0400 Received: from mout.gmx.net ([212.227.17.20]:41035) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEsfO-0006Xr-OS for 43228@debbugs.gnu.org; Sun, 06 Sep 2020 07:17:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1599391016; bh=b1PkSgF7X/+hymfpXN4klWwApW0BRskOvb1fQCCqC/M=; h=X-UI-Sender-Class:References:From:To:Cc:Subject:In-reply-to:Date; b=DwdPqGZ80DNZ3LreDaAF2aGeZKCuoeQt3fT3Q5X3X0VXsyCeWNrnQi6Io0UB+o5m7 KNAb93VCmPxqcF1WbGp41Ix6TX/NWi4ta8JZCfOmO/TvRfQBqkvV/Tvu+O8ISlOZ92 oh0kmQvUBlLa3S9lMxUQ1gJZIsFFYti9b0As+eX0= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from labiere ([82.69.64.142]) by mail.gmx.com (mrgmx105 [212.227.17.174]) with ESMTPSA (Nemesis) id 1N2E1G-1kglRG0n0g-013f2q; Sun, 06 Sep 2020 13:16:56 +0200 References: <87sgbwi0dn.fsf@gmx.com> <87tuwcqdek.fsf@netris.org> <87blikhvj2.fsf@gmx.com> <87o8mjrf3u.fsf@netris.org> User-agent: mu4e 1.4.13; emacs 27.1 From: Pierre Langlois In-reply-to: <87o8mjrf3u.fsf@netris.org> Date: Sun, 06 Sep 2020 12:17:00 +0100 Message-ID: <87pn6z5f4j.fsf@gmx.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Provags-ID: V03:K1:D0JTePx/KQjfq1lkMO9YQ+Poj+qjAgX0uokepFaCsT8yY/q52H3 EtYPqy15PF+HtqE7b8/s18JdW5aWW6c3C9EDXbVJ4+5J+xj+YDdtlvBt6dYsWpo/2luPxLo 3F+7Wd0ncrGNW7FX8jNi/hH1UUDypb9UnfWsV1pwI/TDj77waiGerrpQS/qJ9E4jR6ZKl88 uDdresQyXon4UBdSnhsRQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:NIwFkIHe4iI=:M0r6yKX5Fh5Gln7aYpmWfM nRn6HyipmBAR8JHFBiNmrGCiPRvgao/qFx2MQ+BbwUn4GJ6m3g0eOvlp2OILrXffNxvgLCrnV NMh4J+YZ+DvArxhhlg/te3uyHIrFRWvyy7v/j/ONz4F/ZIC1Jqj7WvhTSNURAxRjahPr2RT/R ihAcOfGeMwlYUvStYJA2UhJsM8HkVUNoYkTFNHFsrsXJO1B1yw1SMBFDrYXJ1O9BfIF3ynLMw rcZQ7jWK4do9D6ZiC1IN3Op4LNx4q5Th/f9ZVM3RufdTBg5wQY7nfBHLvmZAv9O6lt2YR/7YF nbSb+h9tAP6/R3pvUrO694n3ZgKCdDvNUL8U3QoYsQbKrXviBiqqBlVTBFPnMGvHPq8J/1z5F wM9guHwjZUoPhnc/J15lql/wGSE+kQoH+8qnWvCKcmgbVfu3injpbXKSF//zmLcUd8GaqMi3n t/Bbc+E33NcrIKkvpDGk9loJCTAC6pbRVxdLzVU0vUsVGT9dhxKO6yCGxviiPcqr8xbO1oKO8 RaOPoWo9n9D0WnQyq2S0qo/X/C5dXebHj5Exp88RBX8zJ8fGDD1LWBdM+2B+zhqf17FCt6Dc1 41bzijlRJkRSdyVAZ3jaIeD2bML+Ls2TYSEE2uDTl3g6uA00dPu3sCLGeu9B/jiRlekmANjhV qP/dT7n/HgH5O0Xq3uFqWcgqF1liSJU8reKtbHjOYE31aPc+2hpWN8fZIGXIK0PiUw1Bp3cvV FIB+zd3/l5g1pXjG27623XC8nQol6TjrsFJJp32c+7vYyssIAFBarJvP5PLfQNshA7du/eF9H nGouF5uaB/528iY9HpmFPwGZxzRRcL0wrVRYbyZD2FLO7ojmGo7kmk2doLeDW2cy0hSl0vkQL Cr1KY8p6KWWMKXOjwPSHwD6AdqJNlxq1RLNlJU9zZqqVr3EMVtXAHWRg9YJijjjQX60sWLQLX SExHTEjCYftlmuhcWCxEJF1bxC9tul43kQzkamQWLmhFQ1muMiYLbhE1YHIYIu3Rex/QCIIj3 6zZW3jQYLfekTfKJFAVDXXDdyJaEU2dI1gaRheGEx6tovhK/aaOMNg0GJ1C0UdRVd2H30p0TE GdHtaRenV6BzunwZ3y8713syzcI/kjELX3SFRqTs4I9uw+HIngUCr9EH04Tewte0c3yKlbR6H RNRbCjeQuBK8mvxw0bIpm6yw3lwEhLwtx/PX8PRY/ac5P3A1xeo4DsWrWqdMxbZ9BjbLDSjC2 hChHxpmI8V19OPl83jemozzuJav4NrXjg97xtHg== X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.7 (-) X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 43228@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=gmx.net header.s=badeba3b8450 header.b=DwdPqGZ8; dmarc=none; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Spam-Score: -2.11 X-TUID: 09efG+45VXfL --=-=-= Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" --==-=-= Content-Type: text/plain Mark H Weaver writes: > Hi Pierre, > > Pierre Langlois writes: > >> Mark H Weaver writes: >> >>> One possible solution might be to update the replacement (graft) for >>> _curl_ so that it's *built* against nghttp2-1.41. Something like this >>> (untested): >> >> I'm afraid this still doesn't solve the problem. AFAIU, grafting the new >> curl happens after building r-v8, so at link time it still sees the old >> nghttp2 version. > > Ah yes, that makes sense. > >> Instead, I'm thinking your suggestion of leaving 'node' at 10.19 for now >> (or 10.20, I can try that) and then introduce a 'node-10.22' package >> that can be used for Icecat is better. > > That indeed might be the best approach for now. > >> I can do that. How does that sound? > > Sure, sounds good. Thanks! Cool, here's a patch to do just that :-). I tried to update node to 10.21 but that still required the newer nghttp2 lib, but it worked for 10.20. Thanks, Pierre --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQFMBAEBCgA2FiEEctU9gYy29KFyWDdMqPyeRH9PfVQFAl9UxSwYHHBpZXJyZS5s YW5nbG9pc0BnbXguY29tAAoJEKj8nkR/T31UcDwH/A3B1ce50Ask2Z4K5pgaIVOs CjSoUsnkIO2UM28ZSshjv1tX9bvt8MfAy6B41v82RCnZYlpug30QOMORT6+9eY2o wYfw/3Ksk5na+N+glP5ME8LuCNVexqP7LZ4vMBbPnR9JtVW/FdmtTM6isltk6AAy YOkt8wMZW/RKD0Dq4tgGVyoCftjyNpS7FAsvQdy8ZkcKD1bN4OLvOzyDM4ya6IpX OtH+9t5xUOAv243ggJ5a3n3IegVFJ4Ft8jtuchlvHRaCkl0WK6LDDsJiN3whnJrV kfCFcQ6odQvEhipVSyf3Jh4YGhEKHwQWlHZ7tkgwbweaSt2gj2/qUjBmBxVhb7A= =2eIH -----END PGP SIGNATURE----- --==-=-=-- --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-gnu-node-Downgrade-to-10.20.0.patch Content-Transfer-Encoding: quoted-printable =46rom eb00ab49df23f7319009a9fec7fc2805016e2e25 Mon Sep 17 00:00:00 2001 From: Pierre Langlois Date: Sat, 5 Sep 2020 21:05:08 +0100 Subject: [PATCH] gnu: node: Downgrade to 10.20.0. But keep version 10.22.0 around with a new node-10.22 variable. * gnu/packages/node.scm (node): Downgrade to 10.22.0. [inputs]: Downgrade nghttp2 to 1.40. (node-10.22): New variable. =2D-- gnu/packages/node.scm | 44 ++++++++++++++++++++++++++++++++++++++++--- 1 file changed, 41 insertions(+), 3 deletions(-) diff --git a/gnu/packages/node.scm b/gnu/packages/node.scm index ed0b5c4f16..345668fa56 100644 =2D-- a/gnu/packages/node.scm +++ b/gnu/packages/node.scm @@ -25,6 +25,7 @@ (define-module (gnu packages node) #:use-module ((guix licenses) #:select (expat)) + #:use-module ((guix build utils) #:select (alist-replace)) #:use-module (guix packages) #:use-module (guix derivations) #:use-module (guix download) @@ -47,14 +48,14 @@ (define-public node (package (name "node") - (version "10.22.0") + (version "10.20.0") (source (origin (method url-fetch) (uri (string-append "https://nodejs.org/dist/v" version "/node-v" version ".tar.xz")) (sha256 (base32 - "1nz18fa550li10r0kzsm28c2rvvq61nq8bqdygip0rmvbi2paxg0")) + "0cvjwnl0wkcsyw3kannbdv01s235wrnp11n2s6swzjx95gpichfi")) (modules '((guix build utils))) (snippet `(begin @@ -186,7 +187,7 @@ ("http-parser" ,http-parser) ("icu4c" ,icu4c) ("libuv" ,libuv) - ("nghttp2" ,nghttp2-1.41 "lib") + ("nghttp2" ,nghttp2 "lib") ("openssl" ,openssl) ("zlib" ,zlib))) (synopsis "Evented I/O for V8 JavaScript") @@ -200,6 +201,43 @@ devices.") (properties '((max-silent-time . 7200) ;2h, needed on ARM (timeout . 21600))))) ;6h +;; TODO: Make this the default node on core-updates. This cannot be done= on +;; master since this version of node requires a newer nghttp2 library at = link +;; time. +(define-public node-10.22 + (package + (inherit node) + (version "10.22.0") + (source (origin + (method url-fetch) + (uri (string-append "https://nodejs.org/dist/v" version + "/node-v" version ".tar.xz")) + (sha256 + (base32 + "1nz18fa550li10r0kzsm28c2rvvq61nq8bqdygip0rmvbi2paxg0")) + (modules '((guix build utils))) + (snippet + `(begin + ;; Remove bundled software. + (for-each delete-file-recursively + '("deps/cares" + "deps/http_parser" + "deps/icu-small" + "deps/nghttp2" + "deps/openssl" + "deps/uv" + "deps/zlib")) + (substitute* "Makefile" + ;; Remove references to bundled software. + (("deps/http_parser/http_parser.gyp") "") + (("deps/uv/include/\\*.h") "") + (("deps/uv/uv.gyp") "") + (("deps/zlib/zlib.gyp") "")) + #t)))) + (inputs + (alist-replace "nghttp2" (list nghttp2-1.41 "lib") + (package-inputs node))))) + (define-public libnode (package (inherit node) =2D- 2.28.0 --=-=-=--