From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id KOFuGZfvil85YAAA0tVLHw (envelope-from ) for ; Sat, 17 Oct 2020 13:20:23 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id 0ERdFZfvil/vIgAAB5/wlQ (envelope-from ) for ; Sat, 17 Oct 2020 13:20:23 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A903E9402A9 for ; Sat, 17 Oct 2020 13:20:22 +0000 (UTC) Received: from localhost ([::1]:51904 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kTm8C-0002i7-J6 for larch@yhetil.org; Sat, 17 Oct 2020 09:20:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57624) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kTlzC-0000gj-Gh for bug-guix@gnu.org; Sat, 17 Oct 2020 09:11:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:50353) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kTlzC-0006PR-7M for bug-guix@gnu.org; Sat, 17 Oct 2020 09:11:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kTlzB-0007g0-Vg for bug-guix@gnu.org; Sat, 17 Oct 2020 09:11:01 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#44027: [PATCH] installer: Create bios_grub partition when it is needed. Resent-From: Miguel =?UTF-8?Q?=C3=81ngel?= Arruga Vivas Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sat, 17 Oct 2020 13:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44027 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Brett Gilio Received: via spool by 44027-submit@debbugs.gnu.org id=B44027.160294023329465 (code B ref 44027); Sat, 17 Oct 2020 13:11:01 +0000 Received: (at 44027) by debbugs.gnu.org; 17 Oct 2020 13:10:33 +0000 Received: from localhost ([127.0.0.1]:33665 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTlyj-0007fA-2z for submit@debbugs.gnu.org; Sat, 17 Oct 2020 09:10:33 -0400 Received: from mail-wr1-f49.google.com ([209.85.221.49]:40239) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTlyi-0007ey-9n for 44027@debbugs.gnu.org; Sat, 17 Oct 2020 09:10:32 -0400 Received: by mail-wr1-f49.google.com with SMTP id h5so6482126wrv.7 for <44027@debbugs.gnu.org>; Sat, 17 Oct 2020 06:10:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=DkEL3r9MxgZ717Mu1u4TvT0pvzubHuFG/kMlKcqIiAk=; b=moev4ndVXT3eGr58wtx4roeJwiAe/qSYlpaVQVaqb7N3IkaFfl4EHZalhJt9c5GSqw Spe8INxdaJmciRvWB4tQIJHiEkcC3Q9jfzMWczqXcL0UjM7F64YGyK//W1FVbtSwMGiC rMPPUhdjHrQtmpPfTls9SO+EWwyMEWsXbyiX0IV9+U1yEvbofqHsCBMSEwPmBxu3fxj/ bMlvJZDtSuuA1F66V3DZJuV3WNJprCJQhseP7RSAKn56DWxxtdbyLgZtGdw4PHkSqm+k 84fD4ARcDdFYlW6R8Bso4r0BMWPiMQCYOqSofbHhUMPxfrKs+BNNlwkNt0JLC/EvUc6n yjcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=DkEL3r9MxgZ717Mu1u4TvT0pvzubHuFG/kMlKcqIiAk=; b=hLpd+qHOYTgC5JQDESpQ2VfO99NgQYL3tacAZOQ2wnTeWGgvXhFyOL4FS3F9BgrkY8 MJqSffTQa19+eW/quJfeU1xwAlMCPOp1/kVookouFLsNZwEBQvdynchEWK2ZWykYbzrz 4z9P6dBdwTsNQYwwuR4k5B1xx231J0DmgJutiEoXtuVJDx2xer66+v76KKzD1U4EC+lZ jtRb5bhyaN6VTovYMH0lCi+BJPQ4lNeY1vdv9/I+qEjyIesdgd4MbpuAfFMMYMhh+KUF aOdXDaG38g5yoBK9AhOAdAAQsOS98R1QqEwS6HG/6kpthOX7+DRA9lCfsSOPxXAYnGBO Sblw== X-Gm-Message-State: AOAM531QTIym3rvH5fIjLj1o0qdn0KUyIqwHHhdchb40Jp97Q/kLFw/s 0FiERrz909yNGW0BHWg4qz5rvMZF8hcpvfMi X-Google-Smtp-Source: ABdhPJw+UDnvS/R8VYU+IwYeIQ8fEjjOdQmfT01gU/pqcH1r3FKC7bsnhYxdyDC3Mnl+6QS9Lt4NLw== X-Received: by 2002:adf:fbc5:: with SMTP id d5mr9575932wrs.232.1602940226140; Sat, 17 Oct 2020 06:10:26 -0700 (PDT) Received: from unfall (218.139.134.37.dynamic.jazztel.es. [37.134.139.218]) by smtp.gmail.com with ESMTPSA id f6sm8207789wru.50.2020.10.17.06.10.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 17 Oct 2020 06:10:25 -0700 (PDT) From: Miguel =?UTF-8?Q?=C3=81ngel?= Arruga Vivas References: <76f35a63-62e8-4653-865b-b14bb273db34@brendan.scot> <87lfg65jho.fsf@gnu.org> <878sc5wzld.fsf@debian> Date: Sat, 17 Oct 2020 15:09:27 +0200 In-Reply-To: <878sc5wzld.fsf@debian> (Brett Gilio's message of "Fri, 16 Oct 2020 17:55:10 -0500") Message-ID: <87pn5hq9rs.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -0.8 (/) X-Mailman-Approved-At: Sat, 17 Oct 2020 09:20:10 -0400 X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: othacehe@gnu.org, Brendan Tildesley , 44027@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=gmail.com header.s=20161025 header.b=moev4ndV; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Spam-Score: -2.01 X-TUID: fCU4bbnor/Rl --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi, Brett Gilio writes: > Ludovic Court=C3=A8s writes: >> Shouldn=E2=80=99t it create a =E2=80=9Clegacy=E2=80=9D partition table r= ather than GPT since >> we=E2=80=99re on an old, non-UEFI platform? > > That is my thinking as well, it should create a legacy MBR table. IMHO the old format should be avoided completely when possible. Why should we enforce it? I think this problem involves having a previous ESP partition on the disk (at least identified as such by parted), because auto-partition! currently checks that before checking if the booted system has EFI support. When that's the case, it doesn't create the needed bios_grub partition that might have been removed previously. The attached patch solves that. What do you think? Happy hacking, Miguel --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-installer-Create-bios_grub-partition-when-it-is-need.patch Content-Transfer-Encoding: quoted-printable Content-Description: 0001-installer-Create-bios_grub-partition-when-it-is-needed.patch From=20a2f13b21a631398689cc5471c1910af294454e80 Mon Sep 17 00:00:00 2001 From: =3D?UTF-8?q?Miguel=3D20=3DC3=3D81ngel=3D20Arruga=3D20Vivas?=3D Date: Sat, 17 Oct 2020 14:20:41 +0200 Subject: [PATCH] installer: Create bios_grub partition when it is needed. * gnu/installer/parted.scm (auto-partition!): Only check for ESP on EFI installations. =2D-- gnu/installer/parted.scm | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/gnu/installer/parted.scm b/gnu/installer/parted.scm index b0c73b837e..fffd5abf3b 100644 =2D-- a/gnu/installer/parted.scm +++ b/gnu/installer/parted.scm @@ -911,13 +911,13 @@ exists." =20 (let* ((start-partition (and (not has-extended?) =2D (not esp-partition) (if (efi-installation?) =2D (user-partition =2D (fs-type 'fat32) =2D (esp? #t) =2D (size new-esp-size) =2D (mount-point (default-esp-mount-point))) + (and (not esp-partition) + (user-partition + (fs-type 'fat32) + (esp? #t) + (size new-esp-size) + (mount-point (default-esp-mount-point)))) (user-partition (fs-type 'ext4) (bootable? #t) =2D-=20 2.28.0 --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAEBCgAdFiEEiIeExBRZrMuD5+hMY0xuiXn6vsIFAl+K7QcACgkQY0xuiXn6 vsKyOQv+JjVmfFSf5ckupfrSBkgAsN7NSic/Q4bk8Ybku6LH61mgvzZJDvwZVv1y aufvLFtsSVLJDQ5WHAlKmXEnlWpt5t+CR4/Nd3XGZ/kuD5t2guw8X06TuI2BDkpE Uly0Y8sB89JFN6boKqU1UO1TKdW2MBexmAA9t8jg5eHkBnqLcyLD1ePJRR0v9dw8 g/gT217NznksJ6XZK4SfiNxcPHSfM4thGAJqy3pxQqTH34XVNPFGBAC89qBPc0DE lYk1rFD4XhNsgE+1BeugAaGM8kzqjkSjlzEu7kDaPJSNDwYkmbfJxQjq+z1TMUIz NdyddtWq1yzJVWhEaqNz+iZz7ElFHwbcJxMVkE8CI2JZVUahBZIz/xiZgfPlrkMT XcCmKV4bpBcL22qWa4GltoXqZroc0EBBt6klRfaNaLev5kHr06pF7J/YrdP4ne2v Z4f02nUcOizw0CFef1FFdfQnDMnJD1TlsrDkrwDPZJDAetDB4wcKh6jrdSbQri/7 KA7Hy4tB =hsTi -----END PGP SIGNATURE----- --==-=-=--