From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 8BRmFz6TjV/ldAAA0tVLHw (envelope-from ) for ; Mon, 19 Oct 2020 13:23:10 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id MEM9Ez6TjV8GUwAA1q6Kng (envelope-from ) for ; Mon, 19 Oct 2020 13:23:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E519B94023B for ; Mon, 19 Oct 2020 13:23:09 +0000 (UTC) Received: from localhost ([::1]:34330 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kUV80-0006C8-Td for larch@yhetil.org; Mon, 19 Oct 2020 09:23:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41926) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kUV7u-0006C2-8v for bug-guix@gnu.org; Mon, 19 Oct 2020 09:23:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:56930) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kUV7t-0004VE-Vs for bug-guix@gnu.org; Mon, 19 Oct 2020 09:23:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kUV7t-0005Jd-TG for bug-guix@gnu.org; Mon, 19 Oct 2020 09:23:01 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#44027: [PATCH] installer: Create bios_grub partition when it is needed. Resent-From: Miguel =?UTF-8?Q?=C3=81ngel?= Arruga Vivas Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Mon, 19 Oct 2020 13:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44027 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Mathieu Othacehe Received: via spool by 44027-submit@debbugs.gnu.org id=B44027.160311375020388 (code B ref 44027); Mon, 19 Oct 2020 13:23:01 +0000 Received: (at 44027) by debbugs.gnu.org; 19 Oct 2020 13:22:30 +0000 Received: from localhost ([127.0.0.1]:40243 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUV7O-0005Im-72 for submit@debbugs.gnu.org; Mon, 19 Oct 2020 09:22:30 -0400 Received: from mail-wr1-f51.google.com ([209.85.221.51]:39454) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUV7M-0005IV-ST for 44027@debbugs.gnu.org; Mon, 19 Oct 2020 09:22:29 -0400 Received: by mail-wr1-f51.google.com with SMTP id y12so11426984wrp.6 for <44027@debbugs.gnu.org>; Mon, 19 Oct 2020 06:22:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=MHMgGSF4nDEZpZxzfw26GfN3k5u15mA+SFFt6/zM8NU=; b=NZ2QqiYuL5W+Ny8CqMor9NV8lziadaQzC3X3JKwX8ahCA62QOQ5B4cgWHvixCJeCe/ OAdes9A1CHTDWhWtmgwSg01vAksTHJ7u+Qv48UtPjmQBjx4pCYTWKa9JFixYvYyJ+W5X BmOM16/oGS+kBxIPryUI2FUDLdBu5mP1Lmn6wiQxDu5Uu5C+lOuibAoNxLhtG/6LNt6Z jzPGegqMwfl0azC3jKtzqt8BCm2Vo2I2AYYzanCIq95pJAjaG4vpWY/HuC2ORweecVrB BdBaUryCBzRUDU+zr2HHdeRfbJQdZFCWqMBeEq5xZMWTNZMrzueILEs6uLS8NB3pxrnz x0qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=MHMgGSF4nDEZpZxzfw26GfN3k5u15mA+SFFt6/zM8NU=; b=oQiEz+CrOEbcSYet4IMzncCZ0FKnQ1dOkn9zOYe9P1D3Y4QOHtO5Rut4JD0wMxhY63 mwIbPke41hA7YXwl1Ok1rj/DzRaKTvT7S+u2v+XSN5tdIEWlcmUVlioywOUBDmgLkcRy kt0jOJYuLo+gEoOf/Pba5UKQbGBSiWog5SO5DThZ8Drn/MsTH2UsOeJdGiEOiMKd75J6 UDAL8lT8nZxJnJ2xlJqphhojllARsp99aw83iHTKhlY94983M+r93iqMmHr5z66M1hm9 nR9s3+rp+aXWgR/KXLVPb7pjeAEaQ9Z3kJWlQiz0SpVloNxSKauJESSPnDy75XfEADJM 41Fw== X-Gm-Message-State: AOAM531PXv9qsdFtTKUEId4kkMG1BUvB2hm2u7pMIUE3I+0R0cqWVBu8 np3DtXz5pWEPVnesi4FwXD9a/VMyWt5TQ3pg X-Google-Smtp-Source: ABdhPJwyE8isx6ud8YLFmEHNZVis7myIv/s/YASWkgQvK1lT7MJ7DVK6wFPJQtGIYDe+39PA6Ii8yQ== X-Received: by 2002:adf:fc08:: with SMTP id i8mr21025619wrr.116.1603113743338; Mon, 19 Oct 2020 06:22:23 -0700 (PDT) Received: from unfall (218.139.134.37.dynamic.jazztel.es. [37.134.139.218]) by smtp.gmail.com with ESMTPSA id a15sm17775118wro.3.2020.10.19.06.22.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Oct 2020 06:22:22 -0700 (PDT) From: Miguel =?UTF-8?Q?=C3=81ngel?= Arruga Vivas References: <76f35a63-62e8-4653-865b-b14bb273db34@brendan.scot> <87lfg65jho.fsf@gnu.org> <878sc5wzld.fsf@debian> <87pn5hq9rs.fsf_-_@gmail.com> <87mu0jpm5b.fsf@gmail.com> <87imb7zctc.fsf@gnu.org> <87pn5emqzc.fsf@gnu.org> Date: Mon, 19 Oct 2020 15:21:18 +0200 In-Reply-To: <87pn5emqzc.fsf@gnu.org> (Mathieu Othacehe's message of "Mon, 19 Oct 2020 12:48:07 +0200") Message-ID: <87pn5enygh.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -0.8 (/) X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 44027@debbugs.gnu.org, Brendan Tildesley Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=gmail.com header.s=20161025 header.b=NZ2QqiYu; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Spam-Score: -2.01 X-TUID: jezr+aUBiY6D --=-=-= Content-Type: text/plain Hi Mathieu, Mathieu Othacehe writes: > Hello Brendan, > >> I feel the installer should not care what was on the drive to begin with, it >> should just >> format the drive how it sees fit. Why should the existing contents of the >> drive >> affect the outcome when we are reformatting everything anyway? > > That's the case except for the ESP partition that is preserved by the > installer because it could contain vendor / operating system specific > files that should not be wiped. Is there any other issue remaining? It doesn't modify this logic at all. Should I apply this patch to master then? Happy hacking! Miguel --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAEBCgAdFiEEiIeExBRZrMuD5+hMY0xuiXn6vsIFAl+Nks4ACgkQY0xuiXn6 vsJ5/Av/RNphssqvyhjqIpVQ2Qs3hunXsmrJUvHJBd6+tZ0EhQRbbW8WqcBFP292 8u0/xfBgS+5dwUuZnweRYEnTy1swNWpFQFfgfdP3WQNznnWgcYlhzlAQR/iG/GUp Zs2FeUBoQj5IjlSRQIh4NvQP9wlkTsFk/nTQhPFA1F+ywM5pwrFxKY1+cPkPdSGi gWDsLzs/h1ZSfKMAXvFKWX5KwSTnHPDUXHQIVE9mFF6PP/rWwquQoFwNQCsUAKXf Oo3R5nzZ7MJYDpeY/5ob7VUio79TaCgJuX6O+1RLeu8/beWbI9twk08JEvYW1Vc+ vGUeW4P9Z8Yd8C43Ibbjup46sYOk2eyO8SBNAuGWY/Zijr8GPNZPB82YmHEzXzV2 /thV+9l1HwARQlI+9dPp2g7ha6WjzlkFrn//Pa6/S+f8QuaKGyz9o9ZFx9VUtIS1 3R9j8unf2UkfgOrEUa+9krnGEhpXqyb9oB3kgROESbLqKImBPrx8xx05JgBP2cgo lENndUzt =KYap -----END PGP SIGNATURE----- --=-=-=--