From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:8:6d80::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id qDJuKrFfjGCuaQAAgWs5BA (envelope-from ) for ; Fri, 30 Apr 2021 21:51:13 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id YEoHJrFfjGBGSgAAbx9fmQ (envelope-from ) for ; Fri, 30 Apr 2021 19:51:13 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D827C2D6E0 for ; Fri, 30 Apr 2021 21:51:12 +0200 (CEST) Received: from localhost ([::1]:57580 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lcZAM-0004Uf-Gv for larch@yhetil.org; Fri, 30 Apr 2021 15:51:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43544) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lcZAE-0004TX-6x for bug-guix@gnu.org; Fri, 30 Apr 2021 15:51:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:48329) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lcZAD-0001Ov-UY for bug-guix@gnu.org; Fri, 30 Apr 2021 15:51:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lcZAD-0000Zm-SH for bug-guix@gnu.org; Fri, 30 Apr 2021 15:51:01 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#48114: Disarchive occasionally fails tests Resent-From: Timothy Sample Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Fri, 30 Apr 2021 19:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48114 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Received: via spool by 48114-submit@debbugs.gnu.org id=B48114.16198122032107 (code B ref 48114); Fri, 30 Apr 2021 19:51:01 +0000 Received: (at 48114) by debbugs.gnu.org; 30 Apr 2021 19:50:03 +0000 Received: from localhost ([127.0.0.1]:59875 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lcZ9G-0000Xj-6Q for submit@debbugs.gnu.org; Fri, 30 Apr 2021 15:50:02 -0400 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:59523) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lcZ9D-0000XK-Nb for 48114@debbugs.gnu.org; Fri, 30 Apr 2021 15:50:00 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 4D14D5C00B5; Fri, 30 Apr 2021 15:49:54 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Fri, 30 Apr 2021 15:49:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=Vb20ZdhziWEIpLGYCsBqFNgF1gXqzRnV3N0+ifg4q Do=; b=f+lIXdTub/gI5YjCxmszmAgjlveFTHY+lRtd5Zl0Q3Ke1D05GHOSSbPMu e+loDLc+DFzGPRdO50s5uPNI8uF5CsEnbRbBltrkF6JRpqVtEpe4fno+kg2LPW1w +x8/8PfbuCTQuhBBYECjewe609HqLLMlN8n3MaAnMlPT9YAqwLU/D6CfWf7OLVXc FEsdTXluA7OvgcBpDy06P/jjJJFE1TSk+BMbMiaiK/Swky7kJO/cmawXR9TIG+qn MWGplOxplncou5FuVbZ9w+wqIr9ivnPpruFGKkKqTX1WBpAbkry/myeHYW10FssI v/bkRMm0sF8rHil26ua6Tf8Yu17/A== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvddviedgudegfecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufhffjgfkfgggtgfgsehtqhertddtreejnecuhfhrohhmpefvihhm ohhthhihucfurghmphhlvgcuoehsrghmphhlvghtsehnghihrhhordgtohhmqeenucggtf frrghtthgvrhhnpeeiudeuhfeggeelleevheegudfguefhieekffdtveeilefglefhvddt gfeiheetgfenucfkphepjeegrdduudeirddukeeirdeggeenucevlhhushhtvghrufhiii gvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehsrghmphhlvghtsehnghihrhhordgt ohhm X-ME-Proxy: Received: from mrblack (74-116-186-44.qc.dsl.ebox.net [74.116.186.44]) by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 30 Apr 2021 15:49:53 -0400 (EDT) From: Timothy Sample References: <87v984gkhn.fsf@inria.fr> Date: Fri, 30 Apr 2021 15:49:52 -0400 In-Reply-To: <87v984gkhn.fsf@inria.fr> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Fri, 30 Apr 2021 12:00:36 +0200") Message-ID: <87pmybeen3.fsf@ngyro.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 48114@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1619812273; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=Vb20ZdhziWEIpLGYCsBqFNgF1gXqzRnV3N0+ifg4qDo=; b=m/B/nqbDxB+D/YKtWxyaYmNMurunOAYqt5NF/T7iJ+HK3yr8BIkj/Br1GoaQlqHjZYkfyQ ULxWc0Y1a41FchSF7nDAStZkFU6/BlEG7OQB7SPXdzQ3RnPHMxsa67mkfGkPqcoG9s05/W JIIkJkXsNOHwnz3mxlbHSKiFQ958l4n5jlm8TluRazajn+ssHe9UNZmniyzT5N60F8s94x JqAiHDFPHs1gNlHW/maUkOhSla5HVDoQ0mG4CJk1HFWsFqqhIY9hyByLHoJZGvA5Ncu1Y9 bslkdItKihO2D9lT5xKV5jlMxbZtVuX/4h+l5uGRFNShUBu61ITyMN+TUxGdfQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1619812273; a=rsa-sha256; cv=none; b=hRDC4eoK+S0nYX3PasEAaItkNMrVOvTpQOYwLOTFg60+ZhiSlzzXKKSWmAtz5tVZCrga8o vhsWJOpltsQbkopy8yIpDy94Ayh5lL4ZLMr2YDWcOaesuQMc/9o2MzrLWzt8wKr1DR7ELS 0lEho2G6BVouxfskmhzDw3NsrOlcIJ7NB9uHGWMzgbuk41KGWdhs9kYuYqhIZM8u4cAbgQ 4KTLcUaNmZSsAXGIybQvR5+QByxolhxy8tGcbR86OkHtMXGvtl0N+oxDT2aYdmBOjK5L3L kP4VR+6ShhuKCvA9nr15Pz5fdaHgEVwQCzLIYDiD2B/0nw9llI1wwbf6UC3KaQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm2 header.b=f+lIXdTu; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Spam-Score: -1.46 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm2 header.b=f+lIXdTu; dmarc=none; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Queue-Id: D827C2D6E0 X-Spam-Score: -1.46 X-Migadu-Scanner: scn0.migadu.com X-TUID: d3gL+X5lLI05 Hey, Ludovic Court=C3=A8s writes: > Disarchive 0.2.0 occasionally fails two tests: > > FAIL: tests/kinds/octal.scm - [prop] Writing is reversible > FAIL: tests/kinds/octal.scm - [prop] Serializing is reversible These two tests have a bit of a problem. They occasionally fail by =E2=80=9Cgiving up=E2=80=9D, which is when too many test cases are discarde= d rather than used. (This happens because you might write a generator for a superset of the values you=E2=80=99re interested in, and then filter out some values= with =E2=80=9Ctest-when=E2=80=9D.) I don=E2=80=99t think this is happening here= , though. You would see something like =E2=80=9CGave up! Passed only 0 ests [sic].=E2=80=9D > I added =E2=80=98pk=E2=80=99 calls like so: > > (test-assert "[prop] Writing is reversible" > (quickcheck > (property ((octal $octal)) > (test-when (valid-octal? octal) > (begin > (equal? (pk 'oct octal) (pk 'decode (decode-octal (encode-octal = octal))))))))) > > (test-assert "[prop] Serializing is reversible" > (quickcheck > (property ((octal $octal)) > (test-when (valid-octal? octal) > (equal? (pk 'OCT octal) (pk 'DECODE (serdeser -octal- octal))))))) > > > and got this output: > > ;;; (oct #< value: 0 source: #< value: "= \U0f94a4\u0912\U025627\U10e96a\u9576\u2077\u048f\U0f2f60\U0f744b" trailer: = #vu8(172 156 23 48 25 29 159 226 210)>>) > > ;;; (decode #< value: 0 source: #< value= : "\U0f94a4\u0912\U025627\U10e96a\u9576\u2077\u048f\U0f2f60\U0f744b" traile= r: #vu8(172 156 23 48 25 29 159 226 210)>>) > actual-value: #f > actual-error: > + (out-of-range > + #f > + "Value out of range ~S to ~S: ~S" > + (8 9 10) > + (10)) > result: FAIL > > [=E2=80=A6] > > ;;; (OCT #< value: 0 source: #< value: "= \U0f94a4\u0912\U025627\U10e96a\u9576\u2077\u048f\U0f2f60\U0f744b" trailer: = #vu8(172 156 23 48 25 29 159 226 210)>>) > > ;;; (DECODE #< value: 0 source: #< value= : "\U0f94a4\u0912\U025627\U10e96a\u9576\u2077\u048f\U0f2f60\U0f744b" traile= r: #vu8(172 156 23 48 25 29 159 226 210)>>) > actual-value: #f > actual-error: > + (out-of-range > + #f > + "Value out of range ~S to ~S: ~S" > + (8 9 10) > + (10)) > result: FAIL > > I=E2=80=99m not sure where the exception comes from though. I can=E2=80=99t seem to reproduce this. I=E2=80=99ve run the test suite ma= ny, many times, but I also tried: ,use (disarchive kinds octal) ,use (disarchive kinds zero-string) ,use (disarchive serialization) (define the-zero-string (make-zero-string "\U0f94a4\u0912\U025627\U10e96a\u9576\u2077\u048f\U0f2f60\U0f744b" #vu8(172 156 23 48 25 29 159 226 210))) (define the-octal (make-unstructured-octal 0 the-zero-string)) (equal? the-octal (decode-octal (encode-octal the-octal))) (equal? the-octal (serdeser -octal- the-octal)) Which works fine. (Does it work for you?) However, isn=E2=80=99t it possible that these values aren=E2=80=99t the cul= prits? With the =E2=80=9Cpk=E2=80=9D calls you added, isn=E2=80=99t it printing the las= t OK value without telling us the value causing the issue? What if you run it with the following? (test-assert "[prop] Writing is reversible" (quickcheck (property ((octal $octal)) (test-when (valid-octal? octal) (false-if-exception ; <-- changed! (equal? octal (decode-octal (encode-octal octal)))))))) This way, Guile-QuickCheck should print the offending value and the seed used for the tests, which could be helpful for reproducing. (The fact that it doesn=E2=80=99t handle exceptions well is a known bug!) -- Tim