bug#49463: [core-updates] libdatrie occasionally fails test

bug#49463: [core-updates] libdatrie occasionally fails test

[Ludovic Courtès]

On ‘core-updates’ commit 7a9f4822c0c431c25071977b68ab79d152887ec3,
libdatrie occasionally has one test failure (on x86_64-linux):

--8<---------------cut here---------------start------------->8---
make[3]: Entering directory '/tmp/guix-build-libdatrie-0.2.13.drv-0/libdatrie-0.2.13/tests'
PASS: test_walk
PASS: test_iterator
PASS: test_store-retrieve
PASS: test_term_state
PASS: test_nonalpha
PASS: test_file
PASS: test_byte_list
FAIL: test_serialization
PASS: test_byte_alpha
PASS: test_null_trie
============================================================================
Testsuite summary for libdatrie 0.2.13
============================================================================
# TOTAL: 10
# PASS:  9
# SKIP:  0
# XFAIL: 0
# FAIL:  1
# XPASS: 0
# ERROR: 0
============================================================================
See tests/test-suite.log
Please report to https://github.com/tlwg/libdatrie/issues
============================================================================
make[3]: *** [Makefile:829: test-suite.log] Error 1
make[3]: Leaving directory '/tmp/guix-build-libdatrie-0.2.13.drv-0/libdatrie-0.2.13/tests'
make[2]: *** [Makefile:937: check-TESTS] Error 2
make[2]: Leaving directory '/tmp/guix-build-libdatrie-0.2.13.drv-0/libdatrie-0.2.13/tests'
make[1]: *** [Makefile:1074: check-am] Error 2
make[1]: Leaving directory '/tmp/guix-build-libdatrie-0.2.13.drv-0/libdatrie-0.2.13/tests'
make: *** [Makefile:471: check-recursive] Error 1

Test suite failed, dumping logs.

--- ./tests/test-suite.log --------------------------------------------------

============================================
   libdatrie 0.2.13: tests/test-suite.log
============================================

# TOTAL: 10
# PASS:  9
# SKIP:  0
# XFAIL: 0
# FAIL:  1
# XPASS: 0
# ERROR: 0

.. contents:: :depth: 2

FAIL: test_serialization
========================

=> Preparing trie...
=> Saving trie to file...
=> Getting serialized trie size...
serialized trie size 1376
=> Allocating...
allocated 0x40ba70
=> Serializing...
=> Serialized...
Failed to reopen trie file test.tri.
FAIL test_serialization (exit status: 1)
--8<---------------cut here---------------end--------------->8---

It’s problematic because it’s a dependency of Guix on that branch:

--8<---------------cut here---------------start------------->8---
$ ./pre-inst-env guix graph --path guix libdatrie
guix@1.3.0-4.4985a42
graphviz@2.47.1
pango@1.48.4
libthai@0.1.28
libdatrie@0.2.13
--8<---------------cut here---------------end--------------->8---

Ludo’.

bug#49463: [core-updates] libdatrie occasionally fails test

[Ludovic Courtès]

Ludovic Courtès <ludo@gnu.org> skribis:

> FAIL: test_serialization
> ========================
>
> => Preparing trie...
> => Saving trie to file...
> => Getting serialized trie size...
> serialized trie size 1376
> => Allocating...
> allocated 0x40ba70
> => Serializing...
> => Serialized...
> Failed to reopen trie file test.tri.
> FAIL test_serialization (exit status: 1)

This is a classical problem of having several tests fiddling with the
same file:

--8<---------------cut here---------------start------------->8---
$ grep --color -nH --null -e 'test\.tri' *.c
test_file.c32:#define TRIE_FILENAME "test.tri"
test_serialization.c34:#define TRIE_FILENAME "test.tri"
--8<---------------cut here---------------end--------------->8---

Fixed by running tests sequentially in commit
5f919605e94b12d7f56656a30f66f205c24cde98.

Ludo’.