From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 0C/DD+fczGED+wAAgWs5BA (envelope-from ) for ; Wed, 29 Dec 2021 23:10:47 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id eCBuCOfczGHdDAEAG6o9tA (envelope-from ) for ; Wed, 29 Dec 2021 23:10:47 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8558327956 for ; Wed, 29 Dec 2021 23:10:46 +0100 (CET) Received: from localhost ([::1]:58882 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n2h9h-0004Fb-22 for larch@yhetil.org; Wed, 29 Dec 2021 17:10:45 -0500 Received: from eggs.gnu.org ([209.51.188.92]:54854) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n2h90-0004FK-JW for bug-guix@gnu.org; Wed, 29 Dec 2021 17:10:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:39010) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n2h90-0008GD-9R for bug-guix@gnu.org; Wed, 29 Dec 2021 17:10:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n2h90-0006Xy-3N for bug-guix@gnu.org; Wed, 29 Dec 2021 17:10:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#41120: uvesafb service is unsupported on aarch64 Resent-From: Tobias Geerinckx-Rice Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Wed, 29 Dec 2021 22:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41120 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Efraim Flashner Cc: 41120@debbugs.gnu.org, leo@famulari.name X-Debbugs-Original-Cc: 41120@debbugs.gnu.org, bug-guix@gnu.org, Leo Famulari Received: via spool by submit@debbugs.gnu.org id=B.164081579225140 (code B ref -1); Wed, 29 Dec 2021 22:10:01 +0000 Received: (at submit) by debbugs.gnu.org; 29 Dec 2021 22:09:52 +0000 Received: from localhost ([127.0.0.1]:50556 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n2h8l-0006XH-VW for submit@debbugs.gnu.org; Wed, 29 Dec 2021 17:09:52 -0500 Received: from lists.gnu.org ([209.51.188.17]:60538) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n2h8h-0006X3-N7 for submit@debbugs.gnu.org; Wed, 29 Dec 2021 17:09:47 -0500 Received: from eggs.gnu.org ([209.51.188.92]:54768) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n2h8h-0004Es-I8 for bug-guix@gnu.org; Wed, 29 Dec 2021 17:09:43 -0500 Received: from [2a02:c205:2020:6054::1] (port=37322 helo=tobias.gr) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n2h8f-0008DG-PA for bug-guix@gnu.org; Wed, 29 Dec 2021 17:09:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=2018; bh=ID3E9Y8sWPWCc 0Q4n5wg0IOlMTfRRhz7veaWk6ssFMg=; h=in-reply-to:date:subject:cc:to: from:references; d=tobias.gr; b=MqdSFX35JeoYmO/8XPP2h6MVo7NsLAz773CyyY tz914VEL1vccq5HF0M3pF9yIZO7cI8PtW6Cjc4tZOpxVsYFmUva7sQsanumoRGGNU4Mohp 9qudVYyjrMNPdEI2Q9le6JJ+8TUQOl0luziU8nq5auqNKnzYM+z/yrsEuoHOZWa4fFTJ44 Phg1zzJ6Mw06tQDuhAtZDhEdM5NRYnunRj5t/UrIjH9huCV/etECBk+uu5QZ6k+E573hVQ VnVNG6IAz54oJuH+U9u/WnbQWAF1ZcjVOjoM1GX/MKpzh71djRDWDVMuWJ7jAjngfxvl+t Mn4Bx4nOQJLMKfV1NulzFpvQ== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id 9f96b9cd (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Wed, 29 Dec 2021 22:09:37 +0000 (UTC) References: <20200507054015.GG2359@E5400> Date: Wed, 29 Dec 2021 23:03:25 +0100 In-reply-to: BIMI-Selector: v=BIMI1; s=default; Message-ID: <87pmpfdpwd.fsf@nckx> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a02:c205:2020:6054::1 (failed) Received-SPF: pass client-ip=2a02:c205:2020:6054::1; envelope-from=me@tobias.gr; helo=tobias.gr X-Spam_score_int: 6 X-Spam_score: 0.6 X-Spam_bar: / X-Spam_report: (0.6 / 5.0 requ) DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RDNS_NONE=0.793, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" Reply-to: Tobias Geerinckx-Rice From: Tobias Geerinckx-Rice via Bug reports for GNU Guix X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1640815846; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=ID3E9Y8sWPWCc0Q4n5wg0IOlMTfRRhz7veaWk6ssFMg=; b=VF26JLYuYgCEY0Zfw+opKwnh7/yHoADs1RwR5lC7qhSWMTF9CcEdjLzSdjgQmlyMt72rpR yhHhPna/rSJvQ84bQaxdeTA3dFdj+6AOyFJUxDu4PGS0RV+SWGgCcNJDsf2oXdppJ/HDKJ WfG3YlAHaGrzEN4+sQ6KhyFArwOcscupXI8w3PbzMwDrp4zDSTdE1uLZ/guynC08p1F7jz w8CycKdItp15BZQH+drpYPMSgRnpKmTPjSLojnPvB1M6OW/R1n8Fqc8HhEJ1wY8+v9dw+7 uQCnJvgnBkWsY6Wx7DO2lQhBthanTGUQuO4YYt81GXpoTdG09GV+h02qwjAHtg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1640815846; a=rsa-sha256; cv=none; b=BsORGN67bw+gkw5vErhziOLBFBdEh3rNHNHttZrTXTXapzGJ4KyYOD2MrZ/OS5I9fSfYLj zMOnKZIhXL/nhmk+BIDNcOayqHV8TZC5klRm3jzfUqZ1u0dRmTgBTFtX+HZLVOBWzuKwTA wuO9WdHu8M3PMbcPLfXCM19m0Jobv+4zW03TgNmtuMFbGvXKXpK3XYvgO01Znw8TZXbRRy 9dNjndkpW84DFSpF/fBGPAr4fIw2V6ieAi8DZhp2J4KGRwfJlGRhmFzrZ3e3+lu0rezetI VVdBJYiI+5S94eNJwctrO6dkq3rlFpfJraPkiW0GCbnj0JcbT2895ILQHy0mow== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tobias.gr header.s=2018 header.b=MqdSFX35; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -5.37 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tobias.gr header.s=2018 header.b=MqdSFX35; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 8558327956 X-Spam-Score: -5.37 X-Migadu-Scanner: scn1.migadu.com X-TUID: 5hhfRuwzOzlZ --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain; format=flowed I wrote the attached quick fix, then noticed that this bug is paired with #29296 which seems to propose a whole 'nother mechanism? I'm not sure I grok the latter's advantage yet. Kind regards, T G-R --=-=-= Content-Type: text/x-patch; charset=utf-8 Content-Disposition: inline; filename=0001-install-Add-uvesafb-service-only-on-x86.patch Content-Transfer-Encoding: quoted-printable From=2029d6ce59a0f3953de627d110adaa7978051ca077 Mon Sep 17 00:00:00 2001 From: Tobias Geerinckx-Rice Date: Wed, 29 Dec 2021 23:01:11 +0100 Subject: [PATCH] install: Add uvesafb service only on x86. MIME-Version: 1.0 Content-Type: text/plain; charset=3DUTF-8 Content-Transfer-Encoding: 8bit * gnu/system/install.scm (%installation-services): Turn into=E2=80=A6 (installation-services): =E2=80=A6this procedure. Adjust sole user. Add the uvesafb-service-type only when targetting x86. =2D-- gnu/system/install.scm | 25 +++++++++++++++---------- 1 file changed, 15 insertions(+), 10 deletions(-) diff --git a/gnu/system/install.scm b/gnu/system/install.scm index 073d7df1db..36c24992bd 100644 =2D-- a/gnu/system/install.scm +++ b/gnu/system/install.scm @@ -3,7 +3,7 @@ ;;; Copyright =C2=A9 2015 Mark H Weaver ;;; Copyright =C2=A9 2016 Andreas Enge ;;; Copyright =C2=A9 2017 Marius Bakke =2D;;; Copyright =C2=A9 2017, 2019 Tobias Geerinckx-Rice +;;; Copyright =C2=A9 2017, 2019, 2021 Tobias Geerinckx-Rice ;;; Copyright =C2=A9 2020 Florian Pelz ;;; Copyright =C2=A9 2020 Efraim Flashner ;;; @@ -33,6 +33,7 @@ (define-module (gnu system install) #:use-module (guix modules) #:use-module ((guix packages) #:select (package-version)) #:use-module ((guix store) #:select (%store-prefix)) + #:use-module (guix utils) #:use-module (gnu installer) #:use-module (gnu system locale) #:use-module (gnu services avahi) @@ -303,7 +304,7 @@ (define uvesafb-service-type "Load the @code{uvesafb} kernel module with the right options.") (default-value #t))) =20 =2D(define %installation-services +(define (installation-services) ;; List of services of the installation system. (let ((motd (plain-file "motd" " \x1b[1;37mWelcome to the installation of GNU Guix!\x1b[0m @@ -320,7 +321,9 @@ (define (normal-tty tty) (define bare-bones-os (load "examples/bare-bones.tmpl")) =20 =2D (list (service virtual-terminal-service-type) + (append + (list + (service virtual-terminal-service-type) =20 (service kmscon-service-type (kmscon-configuration @@ -426,13 +429,15 @@ (define bare-bones-os glibc-utf8-locales texinfo guile-3.0) =2D %default-locale-libcs)) + %default-locale-libcs))) =20 =2D ;; Machines without Kernel Mode Setting (those with many old a= nd =2D ;; current AMD GPUs, SiS GPUs, ...) need uvesafb to show the G= UI =2D ;; installer. Some may also need a kernel parameter like nomo= deset =2D ;; or vga=3D793, but we leave that for the user to specify in = GRUB. =2D (service uvesafb-service-type)))) + (if (or (target-x86-32?) (target-x86-64?)) + ;; x86 machines without Kernel Mode Setting (those with many o= ld and + ;; current AMD GPUs, SiS GPUs, ...) need uvesafb to show the G= UI + ;; installer. Some may also need a kernel parameter like nomo= deset + ;; or vga=3D793, but we leave that for the user to specify in = GRUB. + (list (service uvesafb-service-type)) + '())))) =20 (define %issue ;; Greeting. @@ -496,7 +501,7 @@ (define installation-os (comment "Guest of GNU")))) =20 (issue %issue) =2D (services %installation-services) + (services (installation-services)) =20 ;; We don't need setuid programs, except for 'passwd', which can be ha= ndy ;; if one is to allow remote SSH login to the machine being installed. =2D-=20 2.34.0 --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIMEARYKACsWIQT12iAyS4c9C3o4dnINsP+IT1VteQUCYczcog0cbWVAdG9iaWFz LmdyAAoJEA2w/4hPVW15XssBAIHTtskPeLlO0Move9HIgNOeVlY6csO8KIR1je48 poz/AQDCu1+x67VvQoOot0UU1hYESmzXYeR9/c0M4Y3YoAj9Cg== =rKtj -----END PGP SIGNATURE----- --==-=-=--