From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id oNrsFdbs7mPPDQAAbAwnHQ (envelope-from ) for ; Fri, 17 Feb 2023 03:56:22 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id 6C34FNbs7mMfdwEAG6o9tA (envelope-from ) for ; Fri, 17 Feb 2023 03:56:22 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D306E3892 for ; Fri, 17 Feb 2023 03:56:21 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pSqup-0001PV-Nf; Thu, 16 Feb 2023 21:56:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pSquo-0001FZ-Hf for bug-guix@gnu.org; Thu, 16 Feb 2023 21:56:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pSquo-00058u-A8 for bug-guix@gnu.org; Thu, 16 Feb 2023 21:56:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pSqun-0000jb-UP for bug-guix@gnu.org; Thu, 16 Feb 2023 21:56:01 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#32026: [PATCH 03/10] gnu: Define UPSTREAM-FIREFOX-SOURCE at the top level. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Fri, 17 Feb 2023 02:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32026 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Mark H Weaver Cc: 32026@debbugs.gnu.org, ludo@gnu.org, Jonathan Brielmaier Received: via spool by 32026-submit@debbugs.gnu.org id=B32026.16766025502802 (code B ref 32026); Fri, 17 Feb 2023 02:56:01 +0000 Received: (at 32026) by debbugs.gnu.org; 17 Feb 2023 02:55:50 +0000 Received: from localhost ([127.0.0.1]:38135 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pSqub-0000j8-W2 for submit@debbugs.gnu.org; Thu, 16 Feb 2023 21:55:50 -0500 Received: from mail-qt1-f181.google.com ([209.85.160.181]:44667) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pSqua-0000it-5W for 32026@debbugs.gnu.org; Thu, 16 Feb 2023 21:55:48 -0500 Received: by mail-qt1-f181.google.com with SMTP id s22so18854qtw.11 for <32026@debbugs.gnu.org>; Thu, 16 Feb 2023 18:55:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=2tkejtWpkUcPDVzs+BT+8GrYqScMw7jaYr3aEC9WmUs=; b=Dd2aS9Cm3ieZRD6w0eKYol5l+G+Q3B1YypEVUW0oZWcFL+3uS/zpvqMb4RgKa6zdb8 Wv90mD5ysRt0QVN13jQGFUYKLbwuAata5AqFqJH/4KXE18z2MkKwQsxKyRZjdt6UUuOQ 8NPhplXJ1xFth5y5WDI+aA+IkNCo/m2vTacTbdWwR6b6iJ0tqNi2E4CXTnXMrtNyD1Ak lyyGdA3MrfOtDLW0Sjb5t+ag0jcQf3Hw493k2kPSOAeF5Y2+eBV4idhLLc06di5AIByC OZc3T8NSb3cY59Mx+Nf/Qplwqcun/08heDYQeyFuwNs6MS/fvik/dzZZ86Q62mcOdA5b lpzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=2tkejtWpkUcPDVzs+BT+8GrYqScMw7jaYr3aEC9WmUs=; b=yokZXZ69p5cTIHyHkCo/+MuVUss/4l1ds4/S93wfbIHrRkNPQ77i+XiPFGtyeM8Aec Ln6NbUUIZqYlTTThn/OT/wSug7DxgjnbhcdNMYW0Hiudng4L+zvMt1WQxw/loQbVRZn4 d5N7dN+7Oq+B5n5pX1oF9uVSicdRDN6ozWPbR+cwG7exK67za2JJgDBwhNWF7P5q/Wme 5vvdMvj/8NglKH3u8LEzUz01HJ/jajB1iJOBKA7Ary3shZLpflAnszeAeL8IhmuWUEGy uP/ad9X7Y1DTgDTYy2QBfPkqSOCfeIFsaqZ5TFMRZTkUXMt3zjNewPfkUL58ah8E6eJV VR3A== X-Gm-Message-State: AO0yUKW9vx7x3WiuHZqcqs68UPWSAG2bEare5CIBb4mEqGAH/NfasArl SNYcLEVco2BsqWkhyRKOwUo= X-Google-Smtp-Source: AK7set+XxFOnDr6YQ8CIAhdmAyi72Z+v+iMqDW0rPpAdTVDG77y+7nHLRKxBRZ6BGSMYgsZzgj4r0Q== X-Received: by 2002:a05:622a:c4:b0:3b6:2f22:75bd with SMTP id p4-20020a05622a00c400b003b62f2275bdmr12581471qtw.28.1676602542565; Thu, 16 Feb 2023 18:55:42 -0800 (PST) Received: from hurd (dsl-152-188.b2b2c.ca. [66.158.152.188]) by smtp.gmail.com with ESMTPSA id p20-20020a05622a13d400b003b86b088755sm2485590qtk.15.2023.02.16.18.55.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Feb 2023 18:55:42 -0800 (PST) From: Maxim Cournoyer References: <20230216043649.32119-1-maxim.cournoyer@gmail.com> <20230216043649.32119-3-maxim.cournoyer@gmail.com> <87h6vlfdq0.fsf@netris.org> Date: Fri, 17 Feb 2023 03:55:40 +0100 In-Reply-To: <87h6vlfdq0.fsf@netris.org> (Mark H. Weaver's message of "Thu, 16 Feb 2023 17:26:52 -0500") Message-ID: <87pma9t2z7.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=Dd2aS9Cm; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1676602582; a=rsa-sha256; cv=none; b=q4lP9k2Y2ATRGUXAnCLXV2fd8mV4PXQgHJ69aA5Dnsd7sjp9iTG0K85rLrpBy3LiSgYXp/ QBBgLPOcyGs1Vf31p7uF3/uxkUzvI3WyuS3GCftuZsUK1YGddHOKBzqLHT+t4TnINPljed E6qhMJq10c6Q5u0Yf2GVVYmlYU/O2UANF58hx8Xz8m+g0kwm8rOG48enIL+P7WK7wfK/cL drvPhRzWnMDksTDq/nbt4LrOl0RpAWwlg7hjv+boI5teTrSHCnJ1V+rJm1p5HNJF30xOIy i4QgTWeAfQkolMch9Yya1DoD9ZOplaNzxYarPJVPCn4rhAehu36E/HQOUeV1Zw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1676602582; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=2tkejtWpkUcPDVzs+BT+8GrYqScMw7jaYr3aEC9WmUs=; b=XVLeUJisVdMjXrL2PjzJvzeev6pnUuRDx75D5Oe1HcgUfxh+JXvwQFzB1UC1Rs+fhXf17y A465dLVdKMS6znRObXzEuNTT7uEhubIHnIzfT5hIRETYfgvtATrn/sKoq2kunsMSySzEtX 6Ll245epAeF81aQG7+rztsmsG3M3c8H0doMvDtUpZsBmBBdjGMTPOJ2NFNcpPepXQDMfi/ +WmMazBwvRDlAZuwPLb6VRO6opmEZe2KnbMLngw3p3yFTtK6vLkHc7f+4b9Sygjut+9vOQ l2+rajYVLE6PRZEZVLWCkgQu1sb1NzQ5IceFeaZQ4Qc/WCwPxYeU2jF1YZtwpQ== Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=Dd2aS9Cm; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) X-Migadu-Scanner: scn1.migadu.com X-Migadu-Spam-Score: -2.02 X-Spam-Score: -2.02 X-Migadu-Queue-Id: D306E3892 X-TUID: d3RLU9yOuPlp Hi Mark, Mark H Weaver writes: > Hi Maxim, > > Maxim Cournoyer writes: > >> * gnu/packages/gnuzilla.scm (%icecat-base-version): New variable. >> (%upstream-firefox-version): Likewise. >> (%icecat-version): Define in terms of %icecat-base-version. >> (upstream-firefox-source): New variable. >> (icecat-source): Adjust to use the above newly introduced variables. > > I'm deeply uncomfortable binding toplevel variables, even unexported > ones, that provide non-FSDG-complaint software. I guess that the > primary motivation for this commit was to make it easier to use the > 'update-mozilla-locales' helper. While I appreciate your concern, I think "hiding" the upstream source would be akin to putting our head in the sand. We do need that upstream source to produce GNU IceCat from source, so it may as well be convenient to handle while hacking on the GNU IceCat package. As you've noted, it isn't exported, so I think it'd be a stretch to say that this private binding "steers" users toward non-FSDG software. Note that we also have a %upstream-linux-source procedure in (gnu packages linux). > In an earlier message , I suggested an > alternative way to use the code in your proposed > 'update-mozilla-locales' helper which would eliminate the need to expose > any *firefox* toplevel variables. I hope you'll find that alternative > approach acceptable, so that we can avoid exposing non-FSDG-compliant > software in our toplevel bindings. > > What do you think? See my explanation there that the need to maintain the various l10n repositories commits/hashes is going away soon. -- Thanks, Maxim