From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: 37300-done@debbugs.gnu.org
Subject: bug#37300: Imported packages' indentation doesn't respect Guix conventions
Date: Thu, 20 Jul 2023 09:23:28 -0400 [thread overview]
Message-ID: <87pm4mlnsf.fsf@gmail.com> (raw)
In-Reply-To: <87woeoycll.fsf@gmail.com> (Maxim Cournoyer's message of "Wed, 04 Sep 2019 12:17:10 +0900")
Hello,
Maxim Cournoyer <maxim.cournoyer@gmail.com> writes:
> The package definitions imported by Guix importers do not respect Guix
> conventions regarding indentation.
>
> Consider:
>
> guix pypi import transaction
>
> (package
> (name "python-transaction")
> (version "2.4.0")
> (source
> (origin
> (method url-fetch)
> (uri (pypi-uri "transaction" version))
> (sha256
> (base32
> "17wz1y524ca07vr03yddy8dv0gbscs06dbdywmllxv5rc725jq3j"))))
> (build-system python-build-system)
> (propagated-inputs
> `(("python-zope.interface" ,python-zope.interface)))
> (native-inputs
> `(("python-coverage" ,python-coverage)
> ("python-mock" ,python-mock)
> ("python-nose" ,python-nose)))
> (home-page
> "https://github.com/zopefoundation/transaction")
> (synopsis "Transaction management for Python")
> (description "Transaction management for Python")
> (license #f))
>
> Re-identing this in Emacs with the Guix .dir-local.el indentation
> customizations yields:
>
> (define-public python-transaction
> (package
> (name "python-transaction")
> (version "2.4.0")
> (source
> (origin
> (method url-fetch)
> (uri (pypi-uri "transaction" version))
> (sha256
> (base32
> "17wz1y524ca07vr03yddy8dv0gbscs06dbdywmllxv5rc725jq3j"))))
> (build-system python-build-system)
> (propagated-inputs
> `(("python-zope.interface" ,python-zope.interface)))
> (native-inputs
> `(("python-coverage" ,python-coverage)
> ("python-mock" ,python-mock)
> ("python-nose" ,python-nose)))
> (home-page
> "https://github.com/zopefoundation/transaction")
> (synopsis "Transaction management for Python")
> (description "Transaction management for Python")
> (license #f)))
That's been taken care of by applying 'guix style' to the
importer-generated definitions; it now looks like:
(define-public python-transaction
(package
(name "python-transaction")
(version "3.1.0")
(source (origin
(method url-fetch)
(uri (pypi-uri "transaction" version))
(sha256
(base32
"191gj6pzvgw0726dsywy8pbj7shxnkc6pyrpnbiw9ryvjbmb3l35"))))
(build-system pyproject-build-system)
(propagated-inputs (list python-zope.interface))
(native-inputs (list python-coverage python-mock python-nose))
(home-page "https://github.com/zopefoundation/transaction")
(synopsis "Transaction management for Python")
(description "Transaction management for Python")
(license #f)))
which is correct.
Closing.
--
Thanks,
Maxim
prev parent reply other threads:[~2023-07-20 13:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-04 3:17 bug#37300: Imported packages' indentation doesn't respect Guix conventions Maxim Cournoyer
2023-07-20 13:23 ` Maxim Cournoyer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pm4mlnsf.fsf@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=37300-done@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).