From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id oLd+ELKv+GT8SQAAauVa8A:P1 (envelope-from ) for ; Wed, 06 Sep 2023 18:58:26 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id oLd+ELKv+GT8SQAAauVa8A (envelope-from ) for ; Wed, 06 Sep 2023 18:58:26 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B1A1543156 for ; Wed, 6 Sep 2023 18:58:25 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b=ksPkeoq1; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1694019506; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=IqDFn2ZTeGIfHUc3gd7ZBXtQrgpEGdHr9960R9IHNsE=; b=QNZD7aoaxsa7wE97w4u0t2P3nSg/58Do6Py5zlWyh2AwBZ62Fr0oPknLpNr/6J4JA6ogd0 Qjmx003nCXgdxdM8TFDMXhmseCD9SuJaeMFXvz+0QI5k16Fs8ORN9RST42zYvqTKbKPHBy vpniZseUXR395OcSd5HWhev3AgmEdKPjChya+dhOBqAXBK2FlMrD4o/eZnIiseM6jqIhja OgecKlCQGJG0HqCi4TrMcteDGDop3nY8ksbIxrZfUvGbz3ZOwNN4qJYhlU/hrkXAwQ6xbx 8UK5C9fRKs1Cc4XzlWn2J735IhDoZSVCYdOJXCbBfVdB6DXHYyxrWwICLzTWkg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1694019506; a=rsa-sha256; cv=none; b=EvH7oKxXoRWkD9BUK0IxiQPpCA40QBy4Ih4XN53hFssxnNVXMdonyq7YcHzn7Qdx7uPGmX saj5qS+0JVX1LPcPDxALjI+XQheqcPYxyv9u5v7AoPvZCvUQPZ7quKHFMELqfazuD84zI8 Tvlq3Qn/hdhxlNZ0+e2ETZ8hVaGeRAih5FvnxQ+QhUCxlYSGDbSaxYk7gL0DZoPKbaa8tR NakMVuV+rVtNw5ON46fA4l+pCXmLXTM8Fr0PI0uloPdCXPm1kigzNZbEMQHt+Kx28ddtpN xwBBCiMRWyDvQOojeIeyj1jAPDPSIQgT+KNN46OGCAYtgUok8RKFO5z1UA5TwA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b=ksPkeoq1; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qdvqt-00069w-Lt; Wed, 06 Sep 2023 12:58:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qdvqr-00069T-Si for bug-guix@gnu.org; Wed, 06 Sep 2023 12:58:01 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qdvqr-0008Av-Kn for bug-guix@gnu.org; Wed, 06 Sep 2023 12:58:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qdvqs-0007Q7-Jc for bug-guix@gnu.org; Wed, 06 Sep 2023 12:58:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#65788: poor information when updating using =?UTF-8?Q?=E2=80=9Cguix_?= =?UTF-8?Q?time-machine=E2=80=9D?= Resent-From: Simon Tournier Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Wed, 06 Sep 2023 16:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 65788 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 65788@debbugs.gnu.org X-Debbugs-Original-To: bug-guix@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.169401947928510 (code B ref -1); Wed, 06 Sep 2023 16:58:02 +0000 Received: (at submit) by debbugs.gnu.org; 6 Sep 2023 16:57:59 +0000 Received: from localhost ([127.0.0.1]:37325 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qdvqp-0007Pk-00 for submit@debbugs.gnu.org; Wed, 06 Sep 2023 12:57:59 -0400 Received: from lists.gnu.org ([2001:470:142::17]:46298) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qdvqn-0007PU-66 for submit@debbugs.gnu.org; Wed, 06 Sep 2023 12:57:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qdvqd-00067T-9Z for bug-guix@gnu.org; Wed, 06 Sep 2023 12:57:48 -0400 Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qdvqa-00083r-DF for bug-guix@gnu.org; Wed, 06 Sep 2023 12:57:47 -0400 Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-3fe4f3b5f25so233035e9.0 for ; Wed, 06 Sep 2023 09:57:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694019461; x=1694624261; darn=gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=IqDFn2ZTeGIfHUc3gd7ZBXtQrgpEGdHr9960R9IHNsE=; b=ksPkeoq14PIkLDMGwHhpSCZireOagxJNi3+BOyjomUE3nbQhHGweymwvbN+BQijIBx HpRgtI5QHUhufc6uIiMDP/h4dYukSs1DeTnCc0BVkO4pCEDi12YYBMHLGQjKip8gOdxO lfeLSI/90dBJ4wgNarRgn6WPDapLKySgNxhzXecpSrVl8hl9LHuUfQ6cZ4xo6Dr6wNaO HMGMWUJ43iG4KwuB1qNrvWslky3ZKIh13oVZX/+eA+DnkF9av/GmQGOw/8dnW+MR2lT5 r18uN5lLc49lUahVUg6wQeYEiBbrVL6nDXGKkVnhFdIG/2qCgXhzVqXYD1T51wX7sgd3 SRJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1694019461; x=1694624261; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=IqDFn2ZTeGIfHUc3gd7ZBXtQrgpEGdHr9960R9IHNsE=; b=T765ZX94cVDNlUtNxEBOcTyFVZLOHpvUUS874bkWI3hFGlYNsNZhpDLKw0k5YtnWuA HgOC12gRM7mXP+UY9t+AECXyO5lQRUrPc6NewHyWkLDwoRg7a7sIaH+Svwuqw2S2dvAu oiBm5ouW7yBSSuo3GPmCXrNJ+p8TQkp2WHZwJadjHCQv65aZ8RSRQYt0wBcd+hHlD9yl cJIgwaTemzfMItX/KfgXxTKovEJuTKFkaGgWvaqt3HVZN+oxpeotBpkl+vhlrfJ2Ht4B n9TkRMqiRkqzM8tOP/fIhU55FkqrVXS2VD4PPjZMMlIrDDPJ6hnDWXNuqkr/YGb94PcO TAuQ== X-Gm-Message-State: AOJu0YzAJE8TumnquHW0g9QvJvnlvEuzpIbsbWKdujCSKbnhjCvfjIn3 DbXVphJOwkPkk2lHmsPHhlgUH3k8KXc= X-Google-Smtp-Source: AGHT+IEu+W+3bdYOSbhI3VgUmiDnTnPVy8tCQKQfEEoxJKxCQPZew+1AXe6HvkbGjq9ZcFNkk7OG6Q== X-Received: by 2002:a05:600c:3ac8:b0:401:bb6e:453a with SMTP id d8-20020a05600c3ac800b00401bb6e453amr13316878wms.0.1694019461420; Wed, 06 Sep 2023 09:57:41 -0700 (PDT) Received: from pfiuh07 ([193.48.40.241]) by smtp.gmail.com with ESMTPSA id n17-20020a1c7211000000b003feef5b0bb7sm44886wmc.40.2023.09.06.09.57.40 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Sep 2023 09:57:41 -0700 (PDT) From: Simon Tournier Date: Wed, 06 Sep 2023 18:57:38 +0200 Message-ID: <87pm2vme7x.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::333; envelope-from=zimon.toutoune@gmail.com; helo=mail-wm1-x333.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx0.migadu.com X-Migadu-Spam-Score: -5.13 X-Spam-Score: -5.13 X-Migadu-Queue-Id: B1A1543156 X-TUID: zdjskGTdDgwB Hi, Tangential of bug#65787 [1], the annoyance is the order of the updates. It leads to poor messages. Let exemplify at the extreme case. --8<---------------cut here---------------start------------->8--- $ guix describe Generation 28 sept. 06 2023 14:54:50 (current) guix 6113e05 repository URL: https://git.savannah.gnu.org/git/guix.git commit: 6113e0529d61df7425f64e30a6bf77f7cfdfe5a5 $ rm -fr ~/.cache/guix/checkouts/pjmkglp4t7znuugeurpurzikxq3tnlaywmisyr27sh= j7apsnalwq $ guix time-machine -q --commit=3D6113e05 -- describe receiving objects 2% =E2=96=95=E2=96=88=E2=96=8B =E2=80=A6some time flies=E2=80=A6 indexing objects 21% =E2=96=95=E2=96=88=E2=96=88=E2=96=88=E2=96=88=E2=96= =88=E2=96=88=E2=96=88=E2=96=88=E2=96=88=E2=96=88=E2=96=88=E2=96=88=E2=96=88= =E2=96=88=E2=96=88=E2=96=88=E2=96=88=E2=96=88=E2=96=88=E2=96=88=E2=96=88=E2= =96=88=E2=96=88 = =E2=96=8F =E2=80=A6some time flies=E2=80=A6 Updating channel 'guix' from Git repository at 'https://git.savannah.gnu.or= g/git/guix.git'... =E2=80=A6instant=E2=80=A6 Computing Guix derivation for 'x86_64-linux'... \ --8<---------------cut here---------------end--------------->8--- The reason is because the logic: (when (procedure? validate-channels) (validate-channels channels)) (run-with-store store (mlet* %store-monad ((instances -> (latest-channel-instances store channels #:authenticate? authenticate?)) where =E2=80=99validate-channels=E2=80=99 (validate-guix-channel) reads, (checkout commit relation (update-cached-checkout (channel-url guix-channel) #:ref reference #:starting-commit %oldest-possible-commit))) and =E2=80=99latest-channel-instances=E2=80=99 which is the ones that displ= ays, (format (current-error-port) (G_ "Updating channel '~a' from Git repository= at '~a'...~%") (channel-name channel) (channel-url channel)) this =E2=80=99latest-channel-instances=E2=80=99 reads under the hood, ((checkout commit relation) (update-cached-checkout (channel-url channel) #:ref (channel-reference channel) #:starting-commit starting-commit))) Why not move this =E2=80=99validate-guix-channel=E2=80=99 to internals. So= mehow, it is in guix/scripts/ because it captures =E2=80=99ref=E2=80=99. However, this = capture is redundant and is normally managed by =E2=80=99channel-list=E2=80=99. There= fore, I would be tempted to have this validation for the reachable commit close to the =E2=80=9CUpdating=E2=80=9D message. WDYT? Cheers, simon 1: