From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id kAN5NEjeEmULzAAAauVa8A:P1 (envelope-from ) for ; Tue, 26 Sep 2023 15:36:09 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id kAN5NEjeEmULzAAAauVa8A (envelope-from ) for ; Tue, 26 Sep 2023 15:36:08 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8AA3CD5DF for ; Tue, 26 Sep 2023 15:36:08 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=lLbSuU4R; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1695735368; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=puPkpq3IyiYw4ii5CkjUabmfcCsPZEcGSWwMWRD7ro8=; b=i4kp4F4xPoT8NMncn+7hrhj39bwGLx41aqeF5hueICQincnuVS98yUMDnj7x1yIB5T+xQh 8Q3yUpIeu/cKIImxnTAZDL3mLwQO1VKouphG1AFvssKuusmjicqZH4fKrs1MqA9CETwMpB U8nkv8Qbn++EzLm+Z1LTaeX+GCz8e2XrSVliS2c3246yFmRMeC3EgQeWUad5olydxkwQFd uo89rDpxleeDpH+x5uTTlqZ/ToYZZxBgiPBYVBYDAoceXwcOkT2xbaybsbbZV95ph8YpoJ Im1r0lQkyNe0bQhvmeSQEiFCpugZWZ/f9NMU63ulmnSc0FouCNw9yhblhpSHig== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1695735368; a=rsa-sha256; cv=none; b=lnKupbQHKOSymQGiIKKnlzKkumAZoxHtsPeRtQ/Ka8WbhzBbEMabd2NNpj9fOQDJNPuAPw RDuRUHqVvgI+CaH1cTGuXro/qS7Ed3nfvvlmq54qygtY6f13zR1+8MZUA4sa+oWM9XAAhd bgsJlZaC41Z93oTV5jiRTsV8yiEweV0EGKBXg+yr+qkuXkuk6yB0igddHeArMgAzgLrMpA zba50gouLWsgszIFgkJDG9Wlb5oRv9vS6IDz/uolycUM0c29x/7p7DhgRd1jtSGbW30ETh YcDvHRONx82VFNy/5LDOG0G+sEgK8NtaDrjRvWC8z4gYnaWc3bF7H2eLiA708g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=lLbSuU4R; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ql8EB-0005qG-7z; Tue, 26 Sep 2023 09:35:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ql8E9-0005q0-5Z for bug-guix@gnu.org; Tue, 26 Sep 2023 09:35:49 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ql8E8-0004WX-QL for bug-guix@gnu.org; Tue, 26 Sep 2023 09:35:48 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ql8EL-0004jF-OT for bug-guix@gnu.org; Tue, 26 Sep 2023 09:36:01 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#65979: incorrect =?UTF-8?Q?=E2=80=9Cguix_?= =?UTF-8?Q?hash=E2=80=9D?= for FastQC Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Tue, 26 Sep 2023 13:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65979 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Simon Tournier Cc: 65979@debbugs.gnu.org Received: via spool by 65979-submit@debbugs.gnu.org id=B65979.169573530918094 (code B ref 65979); Tue, 26 Sep 2023 13:36:01 +0000 Received: (at 65979) by debbugs.gnu.org; 26 Sep 2023 13:35:09 +0000 Received: from localhost ([127.0.0.1]:47618 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ql8DV-0004hm-Dk for submit@debbugs.gnu.org; Tue, 26 Sep 2023 09:35:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34652) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ql8DT-0004hY-Id for 65979@debbugs.gnu.org; Tue, 26 Sep 2023 09:35:08 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ql8DB-0004AS-6P; Tue, 26 Sep 2023 09:34:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=puPkpq3IyiYw4ii5CkjUabmfcCsPZEcGSWwMWRD7ro8=; b=lLbSuU4RZvcuR7jKTZXC T0WwVq3q+GT+KhJCCs1+yC6aY9WlXsbmaYYHz8p3gMfnVu/lE12MxhmUx4FWHPA3vavpERZxXKTPq vlynttLPZB3+VVI6tr8G2ZWCTi+hfGOSNV+CcdE4tbmoPJYkHChVK5VaifFgsvZ3wLGlybwyUkA7s TJWkxUbb1HqzDuX8Ad/Yfco+ZxlPC+WIVe5M+Sm6uFAv3xQrEeAIKEfAo00KMKXXoi/owTpKd6cxD iAArZXAoink8eb/pLmE8xbRG6yGcJlvNmFKTK1GxHqt5v2A583w3zoenkPz2YsgTzCc4EB9fd9glf EVJHyr4lb0RP8g==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <87v8ccd7oy.fsf@gmail.com> <87fs313x92.fsf@gmail.com> Date: Tue, 26 Sep 2023 15:34:47 +0200 In-Reply-To: <87fs313x92.fsf@gmail.com> (Simon Tournier's message of "Tue, 26 Sep 2023 15:00:25 +0200") Message-ID: <87pm252h3c.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx0.migadu.com X-Migadu-Spam-Score: -6.68 X-Spam-Score: -6.68 X-Migadu-Queue-Id: 8AA3CD5DF X-TUID: IPu9jVg3/6uX (Oops, now I see you had already found the reason.) Simon Tournier skribis: > What do we fix? The procedure vcs-file? or fixed-output computation? There are two things are: 1. =E2=80=98vcs-file?=E2=80=99, used by =E2=80=98guix hash -rx=E2=80=99; 2. =E2=80=98git-fetch=E2=80=99, which does (delete-file-recursively ".git= "). Clearly #2 is correct (it=E2=80=99s perfectly fine to have a =E2=80=98.svn= =E2=80=99 directory in a Git repo), whereas #1 is an approximation that, in corner cases like this one, gives the wrong answer. My take is that it=E2=80=99s OK to keep =E2=80=98vcs-file?=E2=80=99 as is: = the best we could do would be to add complicated heuristics in the hope corner cases like this one would be better dealt with, but it wouldn=E2=80=99t be bullet-proof anyway. WDYT? Ludo=E2=80=99.