unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Evgeny Pisemsky <mail@pisemsky.site>
To: 68036@debbugs.gnu.org
Subject: bug#68036: pcb2gcode build fix
Date: Wed, 03 Jul 2024 16:50:25 +0300	[thread overview]
Message-ID: <87plruvb32.fsf@pisemsky.site> (raw)
In-Reply-To: <87plyt3o7b.fsf@pisemsky.com>

[-- Attachment #1: Type: text/plain, Size: 275 bytes --]

Found two issues - unspecified version in pkgconfig of gerbv and some
incompatibility with optional geos library.

Related discussions:

- https://github.com/gerbv/gerbv/issues/130
- https://github.com/pcb2gcode/pcb2gcode/issues/626

The attached patch fixes those problems.

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-pcb2gcode-Fix-build.patch --]
[-- Type: text/x-patch, Size: 1861 bytes --]

From 2f73c340abf3df2690b3778cbf0eb1de7a63ab33 Mon Sep 17 00:00:00 2001
Message-ID: <2f73c340abf3df2690b3778cbf0eb1de7a63ab33.1720013503.git.mail@pisemsky.site>
From: Evgeny Pisemsky <mail@pisemsky.site>
Date: Wed, 3 Jul 2024 15:15:25 +0300
Subject: [PATCH] gnu: pcb2gcode: Fix build.

* gnu/packages/engineering.scm (pcb2gcode): Fix build.

Change-Id: Id9a167c8859520f6e051c9b5efb4b960d50e4b7b
---
 gnu/packages/engineering.scm | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/engineering.scm b/gnu/packages/engineering.scm
index 64335d89f7..0855f44d13 100644
--- a/gnu/packages/engineering.scm
+++ b/gnu/packages/engineering.scm
@@ -844,7 +844,15 @@ (define-public gerbv
                 "06bcm5zw7whsnnmfld3gl2j907lxc68gnsbzr2pc4w6qc923rgmj"))))
     (build-system gnu-build-system)
     (arguments
-     '(#:configure-flags '("CFLAGS=-fcommon")))
+     (list
+      #:configure-flags '(list "CFLAGS=-fcommon")
+      #:phases #~(modify-phases %standard-phases
+                   (add-after 'install 'fix-pkg-config-version
+                     (lambda* (#:key outputs #:allow-other-keys)
+                       (substitute* (string-append (assoc-ref outputs "out")
+                                     "/lib/pkgconfig/libgerbv.pc")
+                         (("^Version:.*$")
+                          (string-append "Version: " #$version "\n"))))))))
     (native-inputs (list autoconf
                          automake
                          desktop-file-utils
@@ -3257,7 +3265,8 @@ (define-public pcb2gcode
    (build-system gnu-build-system)
    (inputs
     (list boost
-          geos
+          ;; TODO: Try to build with geos in the following revisions.
+          ;; geos
           gerbv
           glibmm
           gtkmm-2

base-commit: bab73e413b3421f4aa051e9438d147040a52e1be
-- 
2.45.2


  reply	other threads:[~2024-07-04  9:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-25 22:35 bug#68036: pcb2gcode does not build Evgeny Pisemsky
2024-07-03 13:50 ` Evgeny Pisemsky [this message]
2024-07-04  7:00 ` bug#68036: Sorry Evgeny Pisemsky
2024-08-09 14:23 ` bug#68036: pcb2gcode does not build Evgeny Pisemsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87plruvb32.fsf@pisemsky.site \
    --to=mail@pisemsky.site \
    --cc=68036@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).