bug#72233: emacs-magit build broken

bug#72233: emacs-magit build broken

[Wilko Meyer]

hi guix,

building emacs-magit currently breaks, tested via ./pre-inst-env guix
build emacs-magit as well as guix build emacs-magit after a recent guix
pull (maybe since 7a2fc32ba2cec79b087932f30d77751f9133d740 ?):

#+BEGIN_SRC
starting phase `check'
make[1]: Entering directory '/tmp/guix-build-emacs-magit-3.3.0-8.538cb2f.drv-0/source/test'
Testing...
Loading /tmp/guix-build-emacs-magit-3.3.0-8.538cb2f.drv-0/source/test/magit-tests.el (source)...
Symbol’s function definition is void: static-if

Error: void-function (static-if)
  mapbacktrace(#f(compiled-function (evald func args flags) #<bytecode -0x1bffaf306510e41>))
  debug-early-backtrace()
  debug-early(error (void-function static-if))
  static-if(nil transient--wrap-command transient--wrap-command)
  byte-code("\301\10\302Y\303\304\305\"\303\304\306\"#\207" [emacs-major-version static-if 30 defalias transient--wrap-command #f(compiled-function () #<bytecode -0x106e88d0d986e22f>) #f(compiled-function () #<bytecode 0x70ad76e8d144163>)] 6)
  require(transient)
  eval-buffer(#<buffer  *load*-174996> nil "/tmp/guix-build-emacs-magit-3.3.0-8.538cb2f.drv-0/source/lisp/magit-mode.el" nil t)
  load-with-code-conversion("/tmp/guix-build-emacs-magit-3.3.0-8.538cb2f.drv-0/source/lisp/magit-mode.el" "/tmp/guix-build-emacs-magit-3.3.0-8.538cb2f.drv-0/source/lisp/magit-mode.el" nil t)
  require(magit-mode)
  eval-buffer(#<buffer  *load*-929028> nil "/tmp/guix-build-emacs-magit-3.3.0-8.538cb2f.drv-0/source/lisp/magit-core.el" nil t)
  load-with-code-conversion("/tmp/guix-build-emacs-magit-3.3.0-8.538cb2f.drv-0/source/lisp/magit-core.el" "/tmp/guix-build-emacs-magit-3.3.0-8.538cb2f.drv-0/source/lisp/magit-core.el" nil t)
  require(magit-core)
  eval-buffer(#<buffer  *load*-451227> nil "/tmp/guix-build-emacs-magit-3.3.0-8.538cb2f.drv-0/source/lisp/magit.el" nil t)
  load-with-code-conversion("/tmp/guix-build-emacs-magit-3.3.0-8.538cb2f.drv-0/source/lisp/magit.el" "/tmp/guix-build-emacs-magit-3.3.0-8.538cb2f.drv-0/source/lisp/magit.el" nil t)
  require(magit)
  eval-buffer(#<buffer  *load*> nil "/tmp/guix-build-emacs-magit-3.3.0-8.538cb2f.drv-0/source/test/magit-tests.el" nil t)
  load-with-code-conversion("/tmp/guix-build-emacs-magit-3.3.0-8.538cb2f.drv-0/source/test/magit-tests.el" "/tmp/guix-build-emacs-magit-3.3.0-8.538cb2f.drv-0/source/test/magit-tests.el" nil nil)
  load("/tmp/guix-build-emacs-magit-3.3.0-8.538cb2f.drv-0/source/test/magit-tests.el" nil nil t)
  load-file("../test/magit-tests.el")
  (progn (load-file "../test/magit-tests.el") (ert-run-tests-batch-and-exit))
  eval((progn (load-file "../test/magit-tests.el") (ert-run-tests-batch-and-exit)) t)
  command-line-1(("-L" "../lisp" "-L" "../../compat" "-L" "../../dash" "-L" "../../seq" "-L" "../../transient/lisp" "-L" "../../with-editor/lisp" "--eval" "(progn(load-file \"../test/magit-tests.el\")(ert-run-tests-batch-and-exit))"))
  command-line()
  normal-top-level()
make[1]: *** [Makefile:6: test] Error 255
make[1]: Leaving directory '/tmp/guix-build-emacs-magit-3.3.0-8.538cb2f.drv-0/source/test'
make: *** [Makefile:114: test] Error 2
error: in phase 'check': uncaught exception:
%exception #<&invoke-error program: "make" arguments: ("test" "-j" "16") exit-status: 2 term-signal: #f stop-signal: #f> 
phase `check' failed after 0.6 seconds
command "make" "test" "-j" "16" failed with status 2
builder for `/gnu/store/v66hxgb1jryr7l1hhm9vmflr0694f8hy-emacs-magit-3.3.0-8.538cb2f.drv' failed with exit code 1
build of /gnu/store/v66hxgb1jryr7l1hhm9vmflr0694f8hy-emacs-magit-3.3.0-8.538cb2f.drv failed
View build log at '/var/log/guix/drvs/v6/6hxgb1jryr7l1hhm9vmflr0694f8hy-emacs-magit-3.3.0-8.538cb2f.drv.gz'.
guix build: error: build of `/gnu/store/v66hxgb1jryr7l1hhm9vmflr0694f8hy-emacs-magit-3.3.0-8.538cb2f.drv' failed
#+END_SRC

haven't had the time yet to look into how to fix it.

-- 
Kind regards,
Wilko Meyer

bug#72233: emacs-magit build broken

[Ludovic Courtès]

Hi,

Wilko Meyer <w@wmeyer.eu> skribis:

> building emacs-magit currently breaks, tested via ./pre-inst-env guix
> build emacs-magit as well as guix build emacs-magit after a recent guix
> pull (maybe since 7a2fc32ba2cec79b087932f30d77751f9133d740 ?):

According to <https://ci.guix.gnu.org/build/5188871/details>, it broke
with the a7aa7a8 → 92f3d20 commits.

Nicolas, any idea what happened?

Ludo’.

bug#72233: emacs-magit build broken

[Nicolas Goaziou via Bug reports for GNU Guix]

Hello,

Ludovic Courtès <ludo@gnu.org> writes:

> Wilko Meyer <w@wmeyer.eu> skribis:
>
>> building emacs-magit currently breaks, tested via ./pre-inst-env guix
>> build emacs-magit as well as guix build emacs-magit after a recent guix
>> pull (maybe since 7a2fc32ba2cec79b087932f30d77751f9133d740 ?):
>
> According to <https://ci.guix.gnu.org/build/5188871/details>, it broke
> with the a7aa7a8 → 92f3d20 commits.
>
> Nicolas, any idea what happened?

It required an updated emacs-compat, done in
6c783ecc1f930f4176035fedaf9c179d931c0149.

AFAICT, emacs-magit builds again.

Regards,
-- 
Nicolas Goaziou

bug#72233: emacs-magit build broken

[Wilko Meyer]

Thanks for the quick fix!

-- 
Kind regards,
Wilko Meyer