unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
* Impossible to remove all offload machines
@ 2024-08-17 16:40 Ian Eure
       [not found] ` <87zfoaqo7p.fsf@gmail.com>
  0 siblings, 1 reply; 2+ messages in thread
From: Ian Eure @ 2024-08-17 16:40 UTC (permalink / raw)
  To: bug-guix; +Cc: guix-devel

Ran into this issue last week.  If you:

- Configure some offload build machines in your operating-system
  configuration.
- Reconfigure your system.
- Remove all offload build machines.
- Reconfigure your system again.

...then various guix operations will still try to connect to 
offload machines, even if you reboot the affected client.

This is caused by a bug in the `guix-activation' procedure:

   ;; ... and /etc/guix/machines.scm.
   #$(if (null? (guix-configuration-build-machines config))
         #~#f
         (guix-machines-files-installation
          #~(list #$@(guix-configuration-build-machines
           config))))

If there are no build machines defined in the configuration, no
operation is performed (#f is returned), which leaves the previous
generation’s /etc/guix/machines.scm in place.

The same issue appears to affect channels:

   ;; ... and /etc/guix/channels.scm...
   #$(and channels (install-channels-file channels))

I’d be happy to take a stab at fixing this, but I’m not certain 
what
direction to go, or how much to refactor to get there. Should the
channels/machines files be removed (ignoring errors if they don’t
exist)?  Should empty files be installed?  Should that happen 
inline
in `guix-activation', or in another procedure? Should the 
filenames be
extracted to %variables to avoid duplicating between the two 
places
they’ll be used?

If someone would like to provide answered, I would contribute a 
patch.

Thanks,

 — Ian


^ permalink raw reply	[flat|nested] 2+ messages in thread

* bug#72686: Impossible to remove all offload machines
       [not found]       ` <875xqwivoa.fsf@wolfsden.cz>
@ 2024-09-19  0:35         ` Ian Eure
  0 siblings, 0 replies; 2+ messages in thread
From: Ian Eure @ 2024-09-19  0:35 UTC (permalink / raw)
  To: Tomas Volf; +Cc: guix-devel, 72686, Maxim Cournoyer


Tomas Volf <~@wolfsden.cz> writes:

> [[PGP Signed Part:Undecided]]
>
> Hello,
>
> Ian Eure <ian@retrospec.tv> writes:
>
>> Disregard this, I continued thinking after sending the email 
>> (as one does) and
>> realized that any managed file will be a link into the store -- 
>> so if the system
>> is reconfigured with no build-machines or channels *and* the 
>> corresponding file
>> is a store link, it should be removed; otherwise, it should 
>> remain untouched. I
>> can work with this.
>
> Will this correctly handle cases where user is managing the file 
> using
> for example extra-special-file?
>

No, it wouldn’t.


> I wonder whether fat-warning approach would not be better.
>

I think I agree.

  — Ian




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-09-19  0:37 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-17 16:40 Impossible to remove all offload machines Ian Eure
     [not found] ` <87zfoaqo7p.fsf@gmail.com>
     [not found]   ` <87plp560ji.fsf@meson>
     [not found]     ` <87ldzt606c.fsf@meson>
     [not found]       ` <875xqwivoa.fsf@wolfsden.cz>
2024-09-19  0:35         ` bug#72686: " Ian Eure

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).