unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Christopher Howard <christopher@librehacker.com>
To: 74236@debbugs.gnu.org
Subject: bug#74236: emacs-guix: guix-command-popup not displaying argument improvers
Date: Wed, 06 Nov 2024 14:51:49 -0900	[thread overview]
Message-ID: <87pln7ncoa.fsf@librehacker.com> (raw)

Note that to even display the guix-command-popup, you have to either set guix-repl-use-server to nil, or apply the patch from bug#73462.

The magit popup code for the guix-command-popup (M-x guix c) appears to be broken so that it skips the popup menu where you would construct your command line argument. Instead, it assumes an empty argument, and jumps to the popup where you select whether you want to run the command in the REPL or from a shell.

This code is in guix-command.el, and uses the old magit-popup interface (now superceded by transient). Presumably either something has changed in magit-popup since the code was written (2015-2020) or some Emacs change has broken guix-command.el. I hope to investigate this further. My hope is that some minor fix can be made to guix-command.el rather than having to rewrite everything for transient.

One part I am fuzzy on is how to debug it as it is apparently not possible to run edebug-instrument-function on guix-command-popup, as guix-command-popup is a function generated by other code. If anybody has any advice concerning this, that would be helpful.

Testing this on GNU Emacs 30.0.92 (build 2, x86_64-pc-linux-gnu, GTK+ Version 3.24.41, cairo version 1.18.0) of 2024-10-29.

-- 
📛 Christopher Howard
🚀 gemini://gem.librehacker.com
🌐 http://gem.librehacker.com

בראשית ברא אלהים את השמים ואת הארץ




             reply	other threads:[~2024-11-06 23:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-06 23:51 Christopher Howard [this message]
2024-11-07 21:25 ` bug#74236: [PATCH] Tweaks command parsing regex to address debbugs bug#74236 Christopher Howard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pln7ncoa.fsf@librehacker.com \
    --to=christopher@librehacker.com \
    --cc=74236@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).