From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Subject: bug#20081: patch-source-shebangs crashes on broken symlink Date: Thu, 12 Mar 2015 10:30:55 +0100 Message-ID: <87oanyv9yo.fsf@gnu.org> References: <20150311150211.GK16813@crashnator.suse.cz> <20150311173230.GA12508@debian.math.u-bordeaux1.fr> <20150311191235.GA29520@venom> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:53835) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YVzSJ-00029D-TO for bug-guix@gnu.org; Thu, 12 Mar 2015 05:31:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YVzSJ-0001rz-1B for bug-guix@gnu.org; Thu, 12 Mar 2015 05:31:03 -0400 Received: from debbugs.gnu.org ([140.186.70.43]:44882) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YVzSI-0001rq-Ux for bug-guix@gnu.org; Thu, 12 Mar 2015 05:31:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YVzSI-0007Mz-GM for bug-guix@gnu.org; Thu, 12 Mar 2015 05:31:02 -0400 Sender: "Debbugs-submit" Resent-Message-ID: In-Reply-To: <20150311191235.GA29520@venom> ("=?UTF-8?Q?Tom=C3=A1=C5=A1_?= =?UTF-8?Q?=C4=8Cech?="'s message of "Wed, 11 Mar 2015 20:13:39 +0100") List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org To: =?UTF-8?Q?Tom=C3=A1=C5=A1_?= =?UTF-8?Q?=C4=8Cech?= Cc: 20081@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Tom=C3=A1=C5=A1 =C4=8Cech skribis: > On Wed, Mar 11, 2015 at 06:32:30PM +0100, Andreas Enge wrote: >>On Wed, Mar 11, 2015 at 04:02:11PM +0100, Tom=C3=A1=C5=A1 =C4=8Cech wrote: >>> I'm trying to create package for taskwarrior. >>> Source tarball contain symlinks to nonexisting file `task': >> >>I would argue that this is not a bug in guix, but in the tarball. >>You can remove the link with an additional phase before 'configure, see, = for >>instance, the dvdisaster package in cdrom.scm. > > I agree with you that the fishy part is in tarball, but we could make > build more robust. Getting backtrace is not nice way to end a build. I agree. I think we should patch =E2=80=98find-files=E2=80=99 in core-upda= tes to not follow symlinks: --=-=-= Content-Type: text/x-patch Content-Disposition: inline diff --git a/guix/build/utils.scm b/guix/build/utils.scm index a5a6167..9cbddcd 100644 --- a/guix/build/utils.scm +++ b/guix/build/utils.scm @@ -288,7 +288,8 @@ matches REGEXP." file (strerror errno)) result) '() - dir) + dir + lstat) string