unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Alex Kost <alezost@gmail.com>
To: myglc2 <myglc2@gmail.com>
Cc: 22587@debbugs.gnu.org
Subject: bug#22587: ‘guix edit’ & ‘M-x guix-edit' typo, rename, & mode change
Date: Mon, 08 Feb 2016 11:34:47 +0300	[thread overview]
Message-ID: <87oabrr460.fsf@gmail.com> (raw)
In-Reply-To: <8737t4jt1j.fsf@gmail.com> (myglc2@gmail.com's message of "Sun, 07 Feb 2016 13:04:40 -0500")

myglc2 (2016-02-07 21:04 +0300) wrote:

> From guix INFO:
>
> 6.2 Invoking ‘guix edit’
> [...]
> launches the program specified in the ‘VISUAL’ or in the ‘EDITOR’
> environment variable to edit the recipe of GCC 4.8.4 and that of Vim."
>
> TYPO:
>
> "edit" (last line above) should be replaced with "view", "inspect", or
> "examine".

Just to mention - I like "edit" name :-)

> RENAME:
>
> Calling these functions 'guix edit' and 'M-x guix-edit' implies that the
> user will be able to modify the recipe, but this is not actually the
> case. The functions should be given a more informative and accurate
> name, such as: 'guix view', 'guix inspect', or 'guix examine'.

Along with the package recipes that come with Guix, a user can also have
his/her own packages (specified using GUIX_PACKAGE_PATH env var), and
"guix edit my-super-package" opens a user's file with this package.  It
is highly likely that this file is editable, so "guix edit" is a perfect
name in this case I think.  IMO it's a user responsibility to understand
what files can be edited and what cannot.

But I agree that this may be confusing, so maybe we should clarify the
manual to explain in (info "(guix) Invoking guix edit") that store files
must not be edited.

> MODE CHANGE:
>
> In emacs, read-only .scm files should be opened in view-mode.

I don't agree.  For example, when you open "/etc/hosts" (or whatever)
file in Emacs, you get a message:

  Note: file is write protected

which indicates that it is opened read-only, but view-mode is not used
by default.  You can enable it manually if you wish.  The same thing
happens with package files.

-- 
Alex

  parent reply	other threads:[~2016-02-08  8:35 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-07 18:04 bug#22587: ‘guix edit’ & ‘M-x guix-edit' typo, rename, & mode change myglc2
2016-02-07 18:58 ` Andreas Enge
2016-02-07 19:22   ` myglc2
2016-02-07 19:34     ` Andreas Enge
2016-02-07 20:26       ` myglc2
2016-02-08  8:34 ` Alex Kost [this message]
2016-02-08 15:30   ` Ludovic Courtès
2016-02-08 18:29   ` myglc2
2016-04-18  8:37     ` Alex Kost
2016-04-18 17:41       ` Ludovic Courtès
2016-04-19  8:18         ` Alex Kost
2016-04-19 10:50           ` Ludovic Courtès
2016-04-20  7:20             ` Alex Kost
2016-04-20 15:31               ` Ludovic Courtès
2016-04-21 10:40                 ` Alex Kost
2016-06-02 19:40                   ` Ludovic Courtès
2016-06-03 19:04                     ` Alex Kost
2016-06-04 11:21                       ` Ludovic Courtès
2016-04-18 21:10       ` myglc2

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87oabrr460.fsf@gmail.com \
    --to=alezost@gmail.com \
    --cc=22587@debbugs.gnu.org \
    --cc=myglc2@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).