From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
Subject: bug#23605: /dev/urandom not seeded across reboots
Date: Sat, 28 May 2016 22:53:08 +0200
Message-ID: <87oa7pj45n.fsf@gnu.org>
References: <20160523175832.GA10646@jasmine> <87d1obabj8.fsf@gnu.org>
	<20160525163815.GA19996@jasmine> <87vb229ixp.fsf@gnu.org>
	<20160526164707.GA11671@jasmine> <878tyumgjx.fsf@gnu.org>
	<20160528180535.GA27711@jasmine>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41658)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1b6lFG-0005cP-O6
	for bug-guix@gnu.org; Sat, 28 May 2016 16:54:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1b6lFC-0005RI-1T
	for bug-guix@gnu.org; Sat, 28 May 2016 16:54:06 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:60969)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1b6lFB-0005RE-Uf
	for bug-guix@gnu.org; Sat, 28 May 2016 16:54:01 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1b6lFB-0004qP-Ot
	for bug-guix@gnu.org; Sat, 28 May 2016 16:54:01 -0400
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.23605.B23605.146446880418574@debbugs.gnu.org>
In-Reply-To: <20160528180535.GA27711@jasmine> (Leo Famulari's message of "Sat,
	28 May 2016 14:05:35 -0400")
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix/>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: "bug-Guix" <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
To: Leo Famulari <leo@famulari.name>
Cc: 23605@debbugs.gnu.org

Leo Famulari <leo@famulari.name> skribis:

> Please find my latest patch attached. It seems to work for me!

\o/

> From 18979451b1af7eebaa354c1753ad4c90af288589 Mon Sep 17 00:00:00 2001
> From: Leo Famulari <leo@famulari.name>
> Date: Sat, 28 May 2016 13:41:21 -0400
> Subject: [PATCH] services: Add urandom-seed-service.

Add =E2=80=9CFixes <http://bugs.gnu.org/23605>.=E2=80=9D

> * gnu/services/base.scm (urandom-seed-service): New procedure.
> (%random-seed-file, urandom-seed-service-type): New variables.
> (%urandom-seed-shepherd-service): New procedure.

Mention the addition to =E2=80=98%base-services=E2=80=99 too.

> * doc/guix.texi (Base Services): Document it.

[...]

> +@deftp {Data Type} %random-seed-file

Should be:

  @defvr {Scheme Variable} %random-seed-file

> +This is where some random bytes are saved by @var{urandom-seed-service}

s/This is where/This is the name of the file where/

> +to seed @file{/dev/urandom} when rebooting.

Maybe add =E2=80=9CIt defaults to @file{/var/run/=E2=80=A6}.=E2=80=9D

OK with these changes.

Thanks a lot!

Ludo=E2=80=99.