From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxim Cournoyer Subject: bug#25988: [PATCH] bug#25988: python2-urwid tests fail Date: Sun, 30 Apr 2017 15:44:12 +0900 Message-ID: <87o9veo0n7.fsf_-_@gmail.com> References: <87innn8goq.fsf@gmail.com> <87o9vsh19x.fsf@gmail.com> <8737d4ks8l.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:51961) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d4ibR-0007ZK-FC for bug-guix@gnu.org; Sun, 30 Apr 2017 02:45:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d4ibO-0000zY-Ar for bug-guix@gnu.org; Sun, 30 Apr 2017 02:45:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:48656) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d4ibO-0000zU-77 for bug-guix@gnu.org; Sun, 30 Apr 2017 02:45:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1d4ibO-00034K-0h for bug-guix@gnu.org; Sun, 30 Apr 2017 02:45:02 -0400 Sender: "Debbugs-submit" Resent-Message-ID: In-Reply-To: <8737d4ks8l.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Wed, 19 Apr 2017 23:22:18 +0200") List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 25988@debbugs.gnu.org --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Ludovic, ludo@gnu.org (Ludovic Court=C3=A8s) writes: [...] > > I=E2=80=99ve seen the failure once and it succeeded on a subsequent rebui= ld, so > I came to the conclusion that this is a non-deterministic failure. That > would explain why the problem doesn=E2=80=99t show up on Hydra. > > Does it fail systematically for you? > Yes, it does! I can re-run the `guix system reconfigure ...' as many times as I want and always get the same two failures. However, if I keep the failed derivation and run the tests manually, I've found that using 'strace' will cause more failures/errors; so it seems non-deterministic; maybe a racing issue? I've opened an issue on their GitHub tracker (https://github.com/urwid/urwid/issues/230). Interestingly the same tests run fine with Python 3, with or without using strace. I've attached a patch that disables the problematic vterm tests, only for the python2-urwid package. Maxim --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-gnu-Disable-vterm-tests-for-python2-urwid.patch Content-Transfer-Encoding: quoted-printable From=2056e769bee4a47136e0eee251c87a58b8359a8611 Mon Sep 17 00:00:00 2001 From: Maxim Cournoyer Date: Sun, 30 Apr 2017 14:55:47 +0900 Subject: [PATCH] gnu: Disable vterm tests for python2-urwid * gnu/packages/python.scm (python2-urwid)['delete-test_vterm]: Add phase to delete problematic test modules. =2D-- gnu/packages/python.scm | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm index 22fadea275..c6c0978038 100644 =2D-- a/gnu/packages/python.scm +++ b/gnu/packages/python.scm @@ -5509,7 +5509,18 @@ features useful for text console applications.") (license license:lgpl2.1+))) =20 (define-public python2-urwid =2D (package-with-python2 python-urwid)) + (let ((python2-urwid (package-with-python2 python-urwid))) + (package + (inherit python2-urwid) + (arguments + (append + '(#:phases + (modify-phases %standard-phases + ;; Disable the vterm tests because of non-deterministic failur= es + ;; with Python 2. See https://github.com/urwid/urwid/issues/23= 0. + (add-after 'unpack 'delete-test_vterm.py + (delete-file "urwid/tests/test_vterm.py")))) + (package-arguments python-urwid)))))) =20 (define-public python-openid (package =2D-=20 2.12.0 --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEJ9WGpPiQCFQyn/CfEmDkZILmNWIFAlkFh7wACgkQEmDkZILm NWI+tg//VZANS4OUObH8BkpXyBQ1XiS6++Og8OeeP5kjxwabNlQC7AfCirO9ke/S EiL/ogr1gqp+SVLMHyjT1pexC6urIuYq6xbJGytqukRsSQcDYmblJ1XeoJN6LI7e F0PqVHcHcatT6R9hXAFcsVF1XUWd1iE0S6e3Dh80l4QzS2fj8Smg6J358/0NaDFD St7/awhNOfaa6TtYsxvKK4B49ZKFBKHPQWqJ7CnORWsI8aG5n+mhfGKRkaEs+cAq P34ZrpDf/Hy86BeuF4YK37zHE0XTpdIM32Ncm/XakucefNCCHxsG99kOhNWh0jE/ MHkMhhwa3YYRTlZJ4mZyVxZod8yw1+5EJkxSiKpClsdi9F8TwdDxOVw0xc3C9tnY P8pl2rbI2yxBzaFwrzw7Mhg0fjPO9tPVQHPh+t6Of1o8qP0qEEcBo27iQVj/ZZd3 ry30NQumQvDfy5z7WJfB5v+c/3+IfKroZP3GxDwyA6SbU65KVUev6qLcMfJkBrpV fNQcaThg3Tr9d5mjoKy0wWkcHmFodDyb7VNeDwOyn9nq+lwOkXFkA+M6G+o7eX52 R1HcKpoezhxtD7gWKfNVJTZQIfn1KZjHxPfkt5VxaCYWI3mDf1sRAVloMB66HL3l MbHY8fyvOGmKHmYIg729MnBudFco7HSRmMPhiwYuZCvvUPIeh0Q= =nKxL -----END PGP SIGNATURE----- --==-=-=--